Add a semi-automatic test for #221 #224
Conversation
This fixes a regression for the py-sdl2 test suite, which exercises the (now-deprecated) TTF_SetDirection() and TTF_SetScript(), and expects setting a new global value to have an effect on pre-existing font objects. Resolves: libsdl-org#221 Signed-off-by: Simon McVittie <[email protected]>
This needs to be given a valid font as a command-line argument, but is otherwise automatic. Signed-off-by: Simon McVittie <[email protected]>
|
Given how long it took to get the SDL_image test passing reliably, if @slouken is doing 2.20.0 soon then I'm inclined to wait for 2.21.x to add this - it's just not as high a priority as the CMake build system or getting a release out. |
1 similar comment
|
Given how long it took to get the SDL_image test passing reliably, if @slouken is doing 2.20.0 soon then I'm inclined to wait for 2.21.x to add this - it's just not as high a priority as the CMake build system or getting a release out. |
|
I'm okay with adding this now. The SDL_image test found bugs that were good to fix for the next release, so if that happens here, that makes me happy. :) |
|
OK, I'll try to get it integrated into CI in a way that isn't randomly regressing, but please don't block on this for 2.20. (Also please don't imagine that this is a thorough test - it doesn't even render any text.) |
|
@madebr, I'm working on updating SDL_ttf 3.0, do you want to take a look at this again? |
|
@smcv, I'm working on a 3.0 preview release, feel free to update this PR for review and inclusion. |
This needs to be given a valid font as a command-line argument, but is
otherwise automatic.
Includes #223.
I haven't wired this up to the CMake build system or the CI, because I don't want to put this on the critical path for 2.20.0, but it does seem to work.