Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix configuration file location display getting bold + hide cursor while running #38

Merged
merged 11 commits into from
Jul 8, 2024

Conversation

ruby-R53
Copy link
Contributor

@ruby-R53 ruby-R53 commented Jul 6, 2024

Just some visual improvements to the interface. Because the last row of text ("Playing...") is bold, this parameter ends up applying to the first one too ("Config loaded from...") when another subtune is loaded, so I made it restore the console parameters when reaching that point to keep it the same.

And then I also made it hide the cursor while playing, just to make it look a bit cleaner :)

@drfiemost drfiemost self-assigned this Jul 7, 2024
@drfiemost
Copy link
Member

Nice touch hiding the cursor!

Anyway the filter curve messages are still in bold:

6581 filter range: 0.5
6581 filter curve: 0.5
8580 filter curve: 0.5

Config loaded from

Also please check the indentation, no tabs.

@ruby-R53
Copy link
Contributor Author

ruby-R53 commented Jul 7, 2024

the filter curve messages are still in bold

that's weird, those don't appear here when ANSI is enabled

it clears the screen to make a new page after the player throws those messages

Also please check the indentation, no tabs.

right, my bad

@drfiemost
Copy link
Member

it clears the screen to make a new page after the player throws those messages

Ah, you're right!

BTW, you've put the files in the wrong dir in your last commit.

@ruby-R53
Copy link
Contributor Author

ruby-R53 commented Jul 7, 2024

yeah, i deleted them and put on the right one after

@drfiemost
Copy link
Member

Copy link
Contributor Author

@ruby-R53 ruby-R53 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here it is, didn't pay much attention when removing the wrong files lol

@drfiemost
Copy link
Member

Something went wrong, indentation is not fixed

Copy link
Contributor Author

@ruby-R53 ruby-R53 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there, i think the ones i deleted were the ones that had the correct identation, i apologize

@drfiemost
Copy link
Member

Ok, thanks!

@drfiemost drfiemost merged commit 2c15def into libsidplayfp:master Jul 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants