Added checks for PRNG generated values #552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjaeckel
reviewed
May 30, 2023
demo/test.c
Outdated
Comment on lines
1576
to
1579
| DO(mp_rand(&a, i)); | ||
| if (mp_cmp_d(&a,2u) == MP_LT) { | ||
| continue; | ||
| } |
There was a problem hiding this comment.
Would it maybe make sense to do the following instead?
Suggested change
| DO(mp_rand(&a, i)); | |
| if (mp_cmp_d(&a,2u) == MP_LT) { | |
| continue; | |
| } | |
| do { | |
| DO(mp_rand(&a, i)); | |
| } while (mp_cmp_d(&a,2u) == MP_LT); |
sjaeckel
reviewed
May 30, 2023
demo/test.c
Outdated
Comment on lines
1581
to
1584
| DO(mp_rand(&base, j)); | ||
| if (mp_cmp_d(&base,2u) == MP_LT) { | ||
| continue; | ||
| } |
|
Why are you always have to be right? ;-) Rebase into single commit? |
Yes please! Thanks |
czurnieden
force-pushed
the
sanitize_log_tests
branch
from
a9cdaa8 to
ecfbf6f
Compare
sjaeckel
approved these changes
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #551 : randomly generated values for restricted input must be checked before use.