Remove tainting

Changes

@@ -1,6 +1,9 @@
 Revision history for WWW::Mechanize
 
 {{$NEXT}}
+    [ENHANCEMENTS]
+    - WWW::Mechanize no longer taints the responses it receives.  This also
+    removes Test::Taint as a prerequisite.
 
 2.19      2024-09-16 15:25:45Z
     [DOCUMENTATION]

dist.ini

@@ -25,7 +25,6 @@ dir = script
 [Prereqs / RuntimeRequires]
 perl = 5.008
 HTML::Form = 6.08
-Scalar::Util = 1.14
 
 [Prereqs / TestRequires]
 HTTP::Daemon = 6.12

lib/WWW/Mechanize.pm

@@ -140,7 +140,6 @@ use Tie::RefHash       ();
 use HTTP::Request 1.30 ();
 use HTML::Form 1.00    ();
 use HTML::TokeParser   ();
-use Scalar::Util       qw( tainted );
 
 use parent 'LWP::UserAgent';
 
@@ -3364,8 +3363,6 @@ sub _update_page {
     my $content = $res->decoded_content();
     $content = $res->content if ( not defined $content );
 
-    $content .= _taintedness();
-
     if ( $self->is_html ) {
         $self->update_html($content);
     }
@@ -3376,43 +3373,6 @@ sub _update_page {
     return $res;
 }    # _update_page
 
-our $_taintbrush;
-
-# This is lifted wholesale from Test::Taint
-sub _taintedness {
-    return $_taintbrush if defined $_taintbrush;
-
-    # Somehow we need to get some taintedness into our $_taintbrush.
-    # Let's try the easy way first. Either of these should be
-    # tainted, unless somebody has untainted them, so this
-    # will almost always work on the first try.
-    # (Unless, of course, taint checking has been turned off!)
-    $_taintbrush = substr( "$0$^X", 0, 0 );
-    return $_taintbrush if tainted($_taintbrush);
-
-    # Let's try again. Maybe somebody cleaned those.
-    $_taintbrush = substr( join( q{}, grep { defined } @ARGV, %ENV ), 0, 0 );
-    return $_taintbrush if tainted($_taintbrush);
-
-    # If those don't work, go try to open some file from some unsafe
-    # source and get data from them.  That data is tainted.
-    # (Yes, even reading from /dev/null works!)
-    for my $filename ( qw(/dev/null / . ..), values %INC, $0, $^X ) {
-        if ( open my $fh, '<', $filename ) {
-            my $data;
-            if ( defined sysread $fh, $data, 1 ) {
-                $_taintbrush = substr( $data, 0, 0 );
-                last if tainted($_taintbrush);
-            }
-        }
-    }
-
-    # Sanity check
-    die("Our taintbrush should have zero length!") if length $_taintbrush;
-
-    return $_taintbrush;
-}
-
 =head2 $mech->_modify_request( $req )
 
 Modifies a L<HTTP::Request> before the request is sent out,

lib/WWW/Mechanize/Examples.pod

@@ -182,7 +182,7 @@ WWW::Mechanize.
 
 =back
 
-    #!/usr/bin/perl -w -T
+    #!/usr/bin/perl -w
 
     use strict;
     use WWW::Mechanize;

t/00-load.t

@@ -1,4 +1,4 @@
-#!perl -T
+#!perl
 
 use warnings;
 use strict;

t/add_header.t

@@ -1,4 +1,4 @@
-#!perl -T
+#!perl
 
 use warnings;
 use strict;

t/aliases.t

@@ -1,4 +1,4 @@
-#!perl -T
+#!perl
 
 use warnings;
 use strict;

t/area_link.t

@@ -1,4 +1,4 @@
-#!perl -T
+#!perl
 # WWW::Mechanize tests for <area> tags
 
 use warnings;

t/autocheck.t

@@ -1,4 +1,4 @@
-#!perl -T
+#!perl
 
 use warnings;
 use strict;

t/clone.t

@@ -1,4 +1,4 @@
-#!perl -T
+#!perl
 
 use warnings;
 use strict;

t/credentials.t

@@ -1,4 +1,4 @@
-#!perl -T
+#!perl
 
 use warnings;
 use strict;

t/die.t

@@ -1,4 +1,4 @@
-#!perl -T
+#!perl
 
 use warnings;
 use strict;

t/field.t

@@ -1,4 +1,4 @@
-#!perl -T
+#!perl
 
 use warnings;
 use strict;

t/find_frame.t

@@ -1,4 +1,4 @@
-#!perl -T
+#!perl
 
 use warnings;
 use strict;

t/find_image.t

@@ -1,4 +1,4 @@
-#!perl -T
+#!perl
 
 use warnings;
 use strict;

t/find_inputs.t

@@ -1,4 +1,4 @@
-#!perl -T
+#!perl
 
 use warnings;
 use strict;

t/find_link.t

@@ -1,4 +1,4 @@
-#!perl -T
+#!perl
 
 use warnings;
 use strict;

t/find_link_id.t

@@ -1,4 +1,4 @@
-#!perl -T
+#!perl
 
 use warnings;
 use strict;

t/find_link_xhtml.t

@@ -1,4 +1,4 @@
-#!perl -T
+#!perl
 
 use warnings;
 use strict;

t/form-parsing.t

@@ -1,4 +1,4 @@
-#!perl -T
+#!perl
 
 use strict;
 use warnings;

t/form_with_fields.t

@@ -1,4 +1,4 @@
-#!perl -T
+#!perl
 
 use warnings;
 use strict;

t/form_with_fields_passthrough_params.t

@@ -1,4 +1,4 @@
-#!perl -T
+#!perl
 
 use warnings;
 use strict;

t/frames.t

@@ -1,4 +1,4 @@
-#!perl -T
+#!perl
 
 use warnings;
 use strict;

t/image-new.t

@@ -1,4 +1,4 @@
-#!perl -T
+#!perl
 
 use warnings;
 use strict;

t/image-parse.t

@@ -1,4 +1,4 @@
-#!perl -T
+#!perl
 
 use warnings;
 use strict;

t/link-base.t

@@ -1,4 +1,4 @@
-#!perl -T
+#!perl
 
 use warnings;
 use strict;

t/link-relative.t

@@ -1,4 +1,4 @@
-#!perl -T
+#!perl
 
 use warnings;
 use strict;

t/link.t

@@ -1,4 +1,4 @@
-#!perl -T
+#!perl
 
 use warnings;
 use strict;

t/mech-dump/mech-dump.t

@@ -1,4 +1,4 @@
-#!perl -T
+#!perl
 
 use warnings;
 use strict;

t/new.t

@@ -1,4 +1,4 @@
-#!perl -T
+#!perl
 
 use warnings;
 use strict;

t/regex-error.t

@@ -1,4 +1,4 @@
-#!perl -T
+#!perl
 
 use warnings;
 use strict;

t/save_content.t

@@ -1,4 +1,4 @@
-#!perl -T
+#!perl
 
 use warnings;
 use strict;

t/select.t

@@ -1,4 +1,4 @@
-#!perl -T
+#!perl
 
 use warnings;
 use strict;

t/tick.t

@@ -1,4 +1,4 @@
-#!perl -T
+#!perl
 
 use warnings;
 use strict;

t/upload.t

@@ -1,4 +1,4 @@
-#!perl -T
+#!perl
 
 use strict;
 use warnings;

t/warn.t

@@ -1,4 +1,4 @@
-#!perl -T
+#!perl
 
 use warnings;
 use strict;

t/warnings.t

@@ -1,4 +1,4 @@
-#!perl -T
+#!perl
 
 use warnings;
 use strict;

xt/author/live/wikipedia.t

@@ -1,4 +1,4 @@
-#!perl -T
+#!perl
 
 use warnings;
 use strict;