feat: CSStrikes #392
feat: CSStrikes #392
Conversation
src/CSStrikes.sol
Outdated
| if (isSameRoot) revert InvalidTreeRoot(); | ||
| } | ||
|
|
||
| if (!isSameCid && !isSameRoot) { |
There was a problem hiding this comment.
that's a pretty strange condition, don't get it
it allows to ignore setting if any of these are the same, but it seems to be an illegal values, isn't it? in which cases we will receive such values?
There was a problem hiding this comment.
We don't want to update values from 0 to 0. But in the same time the new one can be empty when the old one not
There was a problem hiding this comment.
If you have the same root, you should have the same CID, right?
There was a problem hiding this comment.
If you have the same root, you should have the same CID, right?
Yes
There was a problem hiding this comment.
so why do we have this condition here then
There was a problem hiding this comment.
I would prefer to keep it as is to be more solid and don't allow setting invalid data
There was a problem hiding this comment.
Found one more edge case. Updated
src/interfaces/ICSModule.sol
Outdated
| /// See `CSStrikes.processValidatorEjection` to use this method permissionless | ||
| /// @param nodeOperatorId ID of the Node Operator | ||
| /// @param keyIndex Index of the withdrawn key in the Node Operator's keys storage | ||
| /// @param strikesData Strikes of the Node Operator |
There was a problem hiding this comment.
it's about node operator keys i believe
it's not clear what are the values supposed to be in this list
There was a problem hiding this comment.
TODO added, because we don't know what values will be there yet
src/CSModule.sol
Outdated
| uint256[] calldata strikesData | ||
| ) internal view returns (bool) { | ||
| uint256 strikesDataLength = strikesData.length; | ||
| if (strikesDataLength != strikesLifetime) revert InvalidStrikesData(); |
There was a problem hiding this comment.
what stops me of sending a proof for a stale key, such as:
- these are not the last X strikes but some from the past frames
- key has been withdrawn or exited already
There was a problem hiding this comment.
Oracle is in charge of setting the root with actual and valid strikes
src/CSStrikes.sol
Outdated
| if (isSameRoot) revert InvalidTreeRoot(); | ||
| } | ||
|
|
||
| if (!isSameCid && !isSameRoot) { |
There was a problem hiding this comment.
If you have the same root, you should have the same CID, right?
vgorkavenko
force-pushed
the
feat/cs-strikes
branch
from
6c46f37 to
263e586
Compare
No description provided.