Add actions #10
Open
Add actions #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheDZhon
requested changes
Feb 5, 2025
README.md
Outdated
| - `fork` - deploy and test on forked network | ||
| - `deploy` - deploy on live network | ||
| - `verify` - verify on live network | ||
| - `check` - check on live network |
There was a problem hiding this comment.
the difference between verify and check maybe not so clear for external viewers
There was a problem hiding this comment.
The 'verify' step is about contracts source code verification. Since it is somewhat unstable (requiring a wait for the block explorer to recognize the address as a contract and multiple attempts), I have placed it in a separate action.
There was a problem hiding this comment.
let's name it publish-sources?
arwer13
approved these changes
Feb 7, 2025
|
|
||
| function parseCmdLineArgs() { | ||
| program | ||
| .argument("<config-path>", "path to .yaml config file") | ||
| .option("--onlyCheck", "only check the real network deployment") | ||
| .option("--onlyForkDeploy", "only deploy to the forked network") | ||
| .option("--actions [actions...]", "list of actions: fork deploy verify check", ["all"]) |
There was a problem hiding this comment.
From this line the format of the list isn't clear. Let's provide an example, smth like:
"list of actions: 'fork' 'deploy' 'verify' 'check'". E.g. "[deploy,verify,check]". Default ["all"]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add possibility to provide actions instead of steps in a format: fork, deploy, verify, check or all