Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CTP: example of usage for TH1FRatio #1

Open
wants to merge 1 commit into
base: ctpqc
Choose a base branch
from
Open

CTP: example of usage for TH1FRatio #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Modules/CTP/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ target_include_directories(
$<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/include>
PRIVATE ${CMAKE_CURRENT_SOURCE_DIR}/src)

target_link_libraries(O2QcCTP PUBLIC O2QualityControl O2::DataFormatsCTP O2::CTPReconstruction)
target_link_libraries(O2QcCTP PUBLIC O2QualityControl O2QcCommon O2::DataFormatsCTP O2::CTPReconstruction)

install(TARGETS O2QcCTP
LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR}
Expand Down
6 changes: 5 additions & 1 deletion Modules/CTP/include/CTP/RawDataQcTask.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,14 @@

#include "QualityControl/TaskInterface.h"
#include "CTPReconstruction/RawDataDecoder.h"
#include "Common/TH1Ratio.h"

#include <memory>

class TH1F;

using namespace o2::quality_control::core;
using namespace o2::quality_control_modules::common;

namespace o2::quality_control_modules::ctp
{
Expand All @@ -48,7 +52,7 @@ class CTPRawDataReaderTask final : public TaskInterface

private:
o2::ctp::RawDataDecoder mDecoder;
TH1F* mHistoInputs = nullptr;
std::unique_ptr<TH1FRatio> mHistoInputs;
TH1F* mHistoClasses = nullptr;
TH1F* mHistoInputRatios = nullptr;
TH1F* mHistoClassRatios = nullptr;
Expand Down
2 changes: 1 addition & 1 deletion Modules/CTP/include/CTP/RawDataReaderCheck.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ class RawDataReaderCheck : public o2::quality_control::checker::CheckInterface
private:
int getRunNumberFromMO(std::shared_ptr<MonitorObject> mo);
int getNumberFilledBins(TH1F* hist);
int checkChange(TH1F* fHistDiference, TH1F* fHistPrev, std::vector<int>& vIndexBad, std::vector<int>& vIndexMedium);
int checkChange(TH1F* fHist, TH1F* fHistPrev, std::vector<int>& vIndexBad, std::vector<int>& vIndexMedium);
int mRunNumber;
long int mTimestamp;
float mThreshold;
Expand Down
25 changes: 19 additions & 6 deletions Modules/CTP/src/RawDataQcTask.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,13 +29,14 @@
#include <Framework/InputRecord.h>
#include <Framework/InputRecordWalker.h>
#include "Framework/TimingInfo.h"
#include "DetectorsBase/GRPGeomHelper.h"

namespace o2::quality_control_modules::ctp
{

CTPRawDataReaderTask::~CTPRawDataReaderTask()
{
delete mHistoInputs;
//delete mHistoInputs; <= not needed with smart pointers
delete mHistoClasses;
delete mHistoMTVXBC;
delete mHistoInputRatios;
Expand All @@ -48,14 +49,14 @@ void CTPRawDataReaderTask::initialize(o2::framework::InitContext& /*ctx*/)
int ninps = o2::ctp::CTP_NINPUTS + 1;
int nclasses = o2::ctp::CTP_NCLASSES + 1;
int norbits = o2::constants::lhc::LHCMaxBunches;
mHistoInputs = new TH1F("inputs", "Inputs distribution", ninps, 0, ninps);
mHistoInputs->SetCanExtend(TH1::kAllAxes);
mHistoInputs = std::make_unique<TH1FRatio>("inputs", "Inputs distribution;;rate (kHz)", ninps, 0, ninps, true);
mHistoInputs->getNum()->SetCanExtend(TH1::kAllAxes);
mHistoClasses = new TH1F("classes", "Classes distribution", nclasses, 0, nclasses);
mHistoMTVXBC = new TH1F("bcMTVX", "BC position of MTVX", norbits, 0, norbits);
mHistoInputRatios = new TH1F("inputRatio", "Input Ratio distribution", ninps, 0, ninps);
mHistoInputRatios->SetCanExtend(TH1::kAllAxes);
mHistoClassRatios = new TH1F("classRatio", "Class Ratio distribution", nclasses, 0, nclasses);
getObjectsManager()->startPublishing(mHistoInputs);
getObjectsManager()->startPublishing(mHistoInputs.get());
getObjectsManager()->startPublishing(mHistoClasses);
getObjectsManager()->startPublishing(mHistoClassRatios);
getObjectsManager()->startPublishing(mHistoInputRatios);
Expand All @@ -82,12 +83,16 @@ void CTPRawDataReaderTask::startOfCycle()

void CTPRawDataReaderTask::monitorData(o2::framework::ProcessingContext& ctx)
{
static constexpr double sOrbitLengthInMS = o2::constants::lhc::LHCOrbitMUS / 1000;

// LOG(info) << "============ Starting monitoring ================== ";
// get the input
std::vector<o2::framework::InputSpec> filter;
std::vector<o2::ctp::LumiInfo> lumiPointsHBF1;
std::vector<o2::ctp::CTPDigit> outputDigits;

auto nOrbitsPerTF = o2::base::GRPGeomHelper::instance().getNHBFPerTF();

o2::framework::InputRecord& inputs = ctx.inputs();
mDecoder.decodeRaw(inputs, filter, outputDigits, lumiPointsHBF1);

Expand All @@ -99,7 +104,8 @@ void CTPRawDataReaderTask::monitorData(o2::framework::ProcessingContext& ctx)
if (digit.CTPInputMask.count()) {
for (int i = 0; i < o2::ctp::CTP_NINPUTS; i++) {
if (digit.CTPInputMask[i]) {
mHistoInputs->Fill(ctpinputs[i], 1);
// store counts in numerator
mHistoInputs->getNum()->Fill(ctpinputs[i], 1);
mHistoInputRatios->Fill(ctpinputs[i], 1);
if (i == indexTvx - 1)
mHistoMTVXBC->Fill(bcid);
Expand All @@ -115,14 +121,21 @@ void CTPRawDataReaderTask::monitorData(o2::framework::ProcessingContext& ctx)
}
}
}
mHistoInputs->Fill(o2::ctp::CTP_NINPUTS);
mHistoInputs->getNum()->Fill(o2::ctp::CTP_NINPUTS);
mHistoClasses->Fill(o2::ctp::CTP_NCLASSES);

// store total duration (in milliseconds) in denominator
mHistoInputs->getDen()->Fill((double)0, sOrbitLengthInMS * nOrbitsPerTF);

// std::cout << " N TFs:" << mNTF << std::endl;
}

void CTPRawDataReaderTask::endOfCycle()
{
ILOG(Debug, Devel) << "endOfCycle" << ENDM;

// update the ratio of histograms
mHistoInputs->update();
}

void CTPRawDataReaderTask::endOfActivity(const Activity& /*activity*/)
Expand Down
25 changes: 13 additions & 12 deletions Modules/CTP/src/RawDataReaderCheck.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,10 +132,12 @@ Quality RawDataReaderCheck::check(std::map<std::string, std::shared_ptr<MonitorO
}
} else if (mo->getName() == "inputs") {
// std::cout << "bin 48:" << h->GetBinContent(o2::ctp::CTP_NINPUTS+1) << " 1 " << h->GetBinContent(1) << std::endl;
h->Scale(1. / h->GetBinContent(o2::ctp::CTP_NINPUTS + 1) / TimeTF);
TH1F* fHistDifference = (TH1F*)h->Clone();

// no need to scale the plot, since it is already normalized
//h->Scale(1. / h->GetBinContent(o2::ctp::CTP_NINPUTS + 1) / TimeTF);

if (fHistInputPrevious) {
checkChange(fHistDifference, fHistInputPrevious, vIndexBad, vIndexMedium);
checkChange(h, fHistInputPrevious, vIndexBad, vIndexMedium);
delete fHistInputPrevious;
}
fHistInputPrevious = (TH1F*)h->Clone();
Expand All @@ -150,9 +152,8 @@ Quality RawDataReaderCheck::check(std::map<std::string, std::shared_ptr<MonitorO
} else if (mo->getName() == "classes") {
// std::cout << "bin 64:" << h->GetBinContent(o2::ctp::CTP_NCLASSES+1) << " 1 " << h->GetBinContent(1) << std::endl;
h->Scale(1. / h->GetBinContent(o2::ctp::CTP_NCLASSES + 1) / TimeTF);
TH1F* fHistDifference = (TH1F*)h->Clone();
if (fHistClassesPrevious) {
checkChange(fHistDifference, fHistClassesPrevious, vIndexBad, vIndexMedium);
checkChange(h, fHistClassesPrevious, vIndexBad, vIndexMedium);
delete fHistClassesPrevious;
}
fHistClassesPrevious = (TH1F*)h->Clone();
Expand All @@ -179,21 +180,21 @@ Quality RawDataReaderCheck::check(std::map<std::string, std::shared_ptr<MonitorO
// LOG(info) << "Cycle ===================>" << cycleCounter;
return result;
}
int RawDataReaderCheck::checkChange(TH1F* fHistDifference, TH1F* fHistPrev, std::vector<int>& vIndexBad, std::vector<int>& vIndexMedium)
int RawDataReaderCheck::checkChange(TH1F* fHist, TH1F* fHistPrev, std::vector<int>& vIndexBad, std::vector<int>& vIndexMedium)
{
fHistDifference->Add(fHistPrev, -1); // Calculate relative difference w.r.t. rate in previous cycle
fHistDifference->Divide(fHistPrev);

float thrBad = mThresholdRateBad;
float thrMedium = mThresholdRateMedium;
if (flagRatio) {
thrBad = mThresholdRateRatioBad;
thrMedium = mThresholdRateRatioMedium;
}
for (size_t i = 1; i < fHistDifference->GetXaxis()->GetNbins() + 1; i++) { // Check how many inputs/classes changed more than a threshold value
if (TMath::Abs(fHistDifference->GetBinContent(i)) > thrBad) {
for (size_t i = 1; i < fHist->GetXaxis()->GetNbins() + 1; i++) { // Check how many inputs/classes changed more than a threshold value
double val = fHist->GetBinContent(i);
double valPrev = fHistPrev->GetBinContent(i);
double relDiff = (valPrev != 0) ? (val - valPrev) / valPrev : 0;
if (TMath::Abs(relDiff) > thrBad) {
vIndexBad.push_back(i);
} else if (TMath::Abs(fHistDifference->GetBinContent(i)) > thrMedium) {
} else if (TMath::Abs(relDiff) > thrMedium) {
vIndexMedium.push_back(i);
}
}
Expand Down