enforce hiding of concepts children if not in the scheme even if has …

…children
lifewatch-eric · Nov 19, 2024 · 8bb88d6 · 8bb88d6
1 parent 674976e
commit 8bb88d6
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/lib/ontologies_linked_data/models/ontology_submission.rb b/lib/ontologies_linked_data/models/ontology_submission.rb
@@ -773,11 +773,11 @@ def children(cls, includes_param: [], concept_schemes: [], concept_collections:
         end
 
         unless concept_schemes.empty?
-          page_data.delete_if { |c| Array(c.isInActiveScheme).empty? && !c.load_has_children }
+          page_data.delete_if { |c| Array(c.isInActiveScheme).empty? }
           if (page_data.size < size) && page_data.next_page
             page_data += children(cls, includes_param: includes_param, concept_schemes: concept_schemes,
-                                      concept_collections: concept_collections,
-                                 page: page_data.next_page, size: size)
+                                       concept_collections: concept_collections,
+                                       page: page_data.next_page, size: size)
           end
         end
 

diff --git a/test/models/test_skos_submission.rb b/test/models/test_skos_submission.rb
@@ -152,7 +152,7 @@ def test_children_of_scheme
     refute_empty roots
 
     roots = sub.children(cls, concept_schemes: concept_schemes, size: 10)
-    assert_equal 1, roots.size, 'Children should be filtered by the scheme in this case only one'
+    assert_equal 0, roots.size, 'Children should be filtered by the scheme'
   end
 
 end