feat(AcrossV3): adds support for AcrossV3 (AcrossFacetV3 v1.0.0, AcrossFacetPackedV3 v1.0.0, ReceiverAcrossV3 v1.0.0)

.github/workflows/enforceTestCoverage.yml

@@ -46,7 +46,7 @@ jobs:
 
       - name: Generate Coverage Report
         run: |
-          forge coverage --report lcov --force
+          forge coverage --report lcov --force --evm-version 'shanghai' --ir-minimum
 
           echo "Filtering coverage report to only contain coverage info for 'src/'' folder now"
 

.github/workflows/forge.yml

@@ -48,6 +48,6 @@ jobs:
       - name: Run forge tests (with auto-repeat in case of error)
         uses: Wandalen/[email protected]
         with:
-          command: forge test
+          command: forge test --evm-version 'shanghai'
           attempt_limit: 10
-          attempt_delay: 15000
+          attempt_delay: 15000

.github/workflows/unreviewedPRReminder.yml

@@ -41,6 +41,11 @@ jobs:
               continue
             fi
 
+            # Continue loop if the PR has the label "WaitForBackend"
+            if echo "$PR_LABELS" | grep -q "WaitForBackend"; then
+              continue
+            fi
+
             # Convert date to Unix timestamp
             PR_CREATED_AT=$(date -d"$PR_CREATED_AT" +%s)
             NOW=$(date +%s)

.solhint.json

@@ -9,12 +9,12 @@
       }
     ],
     "code-complexity": ["error", 20],
-    "compiler-version": ["error", "^0.8.7"],
+    "compiler-version": ["error", "^0.8.17"],
     "const-name-snakecase": "off",
     "func-name-mixedcase": "off",
     "constructor-syntax": "error",
-    "func-visibility": ["error", {"ignoreConstructors": true}],
+    "func-visibility": ["error", { "ignoreConstructors": true }],
     "not-rely-on-time": "off",
-    "reason-string": ["warn", {"maxLength": 64}]
+    "reason-string": ["warn", { "maxLength": 64 }]
   }
 }

archive/scripts/Deploy/DeployLiFiDiamondImmutable.s.sol

@@ -4,12 +4,13 @@ pragma solidity ^0.8.17;
 import { DeployScriptBase } from "./utils/DeployScriptBase.sol";
 import { stdJson } from "forge-std/Script.sol";
 import { LiFiDiamondImmutable } from "lifi/LiFiDiamondImmutable.sol";
-import { DiamondCutFacet, IDiamondCut } from "lifi/Facets/DiamondCutFacet.sol";
+import { DiamondCutFacet } from "lifi/Facets/DiamondCutFacet.sol";
+import { LibDiamond } from "lifi/Libraries/LibDiamond.sol";
 
 contract DeployScript is DeployScriptBase {
     using stdJson for string;
 
-    IDiamondCut.FacetCut[] internal cut;
+    LibDiamond.FacetCut[] internal cut;
     address internal diamondImmutable;
     DiamondCutFacet internal cutter;
 

archive/scripts/Deploy/DeployNonStandardSelectorsRegistryFacet.s.sol

@@ -1,5 +1,5 @@
 // // SPDX-License-Identifier: MIT
-pragma solidity 0.8.17;
+pragma solidity ^0.8.17;
 
 import { DeployScriptBase } from "./utils/DeployScriptBase.sol";
 import { NonStandardSelectorsRegistryFacet } from "lifi/Facets/NonStandardSelectorsRegistryFacet.sol";

archive/scripts/Deploy/UpdateNonStandardSelectorsRegistryFacet.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: MIT
-pragma solidity 0.8.17;
+pragma solidity ^0.8.17;
 
 import { UpdateScriptBase } from "./utils/UpdateScriptBase.sol";
 import { stdJson } from "forge-std/StdJson.sol";

archive/scripts/Deploy/zkSync/008_deploy_service_fee_collector.ts → archive/scripts/zkSync/008_deploy_service_fee_collector.ts

@@ -1,13 +1,13 @@
 import { HardhatRuntimeEnvironment } from 'hardhat/types'
 import { DeployFunction } from 'hardhat-deploy/types'
 import { ethers, network } from 'hardhat'
-import { PeripheryRegistryFacet } from '../../../../typechain'
+import { PeripheryRegistryFacet } from '../../../typechain'
 import {
   diamondContractName,
   updateDeploymentLogs,
   verifyContract,
-} from '../../../../script/deploy/zksync/9999_utils'
-import globalConfig from '../../../../config/global.json'
+} from '../../../script/deploy/zksync/9999_utils'
+import globalConfig from '../../../config/global.json'
 
 const func: DeployFunction = async function (hre: HardhatRuntimeEnvironment) {
   // Protect against unwanted redeployments

archive/src/Facets/CelerIMFacetImmutable.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: MIT
-pragma solidity 0.8.17;
+pragma solidity ^0.8.17;
 
 import { CelerIMFacetBase, IMessageBus, MsgDataTypes, IERC20, CelerIM } from "../Helpers/CelerIMFacetBase.sol";
 

archive/src/Facets/CircleBridgeFacet.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: MIT
-pragma solidity 0.8.17;
+pragma solidity ^0.8.17;
 
 import { ILiFi } from "../Interfaces/ILiFi.sol";
 import { ITokenMessenger } from "../Interfaces/ITokenMessenger.sol";

archive/src/Facets/DeBridgeFacet.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: MIT
-pragma solidity 0.8.17;
+pragma solidity ^0.8.17;
 
 import { ILiFi } from "../Interfaces/ILiFi.sol";
 import { IDeBridgeGate } from "../Interfaces/IDeBridgeGate.sol";

archive/src/Facets/GnosisBridgeL2Facet.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: MIT
-pragma solidity 0.8.17;
+pragma solidity ^0.8.17;
 
 import { ILiFi } from "../Interfaces/ILiFi.sol";
 import { IXDaiBridgeL2 } from "../Interfaces/IXDaiBridgeL2.sol";

archive/src/Facets/MakerTeleportFacet.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: MIT
-pragma solidity 0.8.17;
+pragma solidity ^0.8.17;
 
 import "@openzeppelin/contracts/token/ERC20/IERC20.sol";
 import "@openzeppelin/contracts/utils/math/SafeCast.sol";

archive/src/Facets/MultichainFacet.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: MIT
-pragma solidity 0.8.17;
+pragma solidity ^0.8.17;
 
 import { ILiFi } from "../Interfaces/ILiFi.sol";
 import { LibAsset, IERC20 } from "../Libraries/LibAsset.sol";

archive/src/Facets/NonStandardSelectorsRegistryFacet.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: MIT
-pragma solidity 0.8.17;
+pragma solidity ^0.8.17;
 
 import { LibDiamond } from "../Libraries/LibDiamond.sol";
 

archive/src/Facets/SynapseBridgeFacet.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: MIT
-pragma solidity 0.8.17;
+pragma solidity ^0.8.17;
 
 import { ILiFi } from "../Interfaces/ILiFi.sol";
 import { ISynapseRouter } from "../Interfaces/ISynapseRouter.sol";

archive/src/LiFiDiamondImmutable.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: MIT
-pragma solidity 0.8.17;
+pragma solidity ^0.8.17;
 
 import { LibDiamond } from "./Libraries/LibDiamond.sol";
 import { IDiamondCut } from "./Interfaces/IDiamondCut.sol";
@@ -14,12 +14,12 @@ contract LiFiDiamondImmutable {
         LibDiamond.setContractOwner(_contractOwner);
 
         // Add the diamondCut external function from the diamondCutFacet
-        IDiamondCut.FacetCut[] memory cut = new IDiamondCut.FacetCut[](1);
+        LibDiamond.FacetCut[] memory cut = new LibDiamond.FacetCut[](1);
         bytes4[] memory functionSelectors = new bytes4[](1);
         functionSelectors[0] = IDiamondCut.diamondCut.selector;
-        cut[0] = IDiamondCut.FacetCut({
+        cut[0] = LibDiamond.FacetCut({
             facetAddress: _diamondCutFacet,
-            action: IDiamondCut.FacetCutAction.Add,
+            action: LibDiamond.FacetCutAction.Add,
             functionSelectors: functionSelectors
         });
         LibDiamond.diamondCut(cut, address(0), "");

archive/src/Periphery/GasRebateDistributor.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: MIT
-pragma solidity 0.8.17;
+pragma solidity ^0.8.17;
 
 import { TransferrableOwnership } from "../Helpers/TransferrableOwnership.sol";
 import { MerkleProof } from "@openzeppelin/contracts/utils/cryptography/MerkleProof.sol";

archive/src/Periphery/ServiceFeeCollector.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: UNLICENSED
-pragma solidity 0.8.17;
+pragma solidity ^0.8.17;
 
 import { LibAsset } from "../Libraries/LibAsset.sol";
 import { TransferrableOwnership } from "../Helpers/TransferrableOwnership.sol";

archive/test/CircleBridgeFacet.t.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: Unlicense
-pragma solidity 0.8.17;
+pragma solidity ^0.8.17;
 
 import { LibSwap, LibAllowList, TestBaseFacet, console } from "../utils/TestBaseFacet.sol";
 import { InsufficientBalance } from "src/Errors/GenericErrors.sol";

archive/test/DeBridgeDlnFacet.t.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: Unlicense
-pragma solidity 0.8.17;
+pragma solidity ^0.8.17;
 
 import { LibAllowList, TestBaseFacet, console, ERC20, LibSwap } from "../utils/TestBaseFacet.sol";
 import { DeBridgeDlnFacet } from "lifi/Facets/DeBridgeDlnFacet.sol";

archive/test/DeBridgeFacet.t.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: Unlicense
-pragma solidity 0.8.17;
+pragma solidity ^0.8.17;
 
 import { LibAllowList, TestBaseFacet, console } from "../utils/TestBaseFacet.sol";
 import { DeBridgeFacet } from "lifi/Facets/DeBridgeFacet.sol";

archive/test/GasRebateDistributor.t.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: Unlicensed
-pragma solidity 0.8.17;
+pragma solidity ^0.8.17;
 
 import { Test, stdJson } from "forge-std/Test.sol";
 import { console } from "../utils/Console.sol";

archive/test/GnosisBridgeL2Facet.t.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: Unlicense
-pragma solidity 0.8.17;
+pragma solidity ^0.8.17;
 
 import { LibSwap, LibAllowList, TestBaseFacet, console } from "../utils/TestBaseFacet.sol";
 import { InsufficientBalance } from "src/Errors/GenericErrors.sol";

archive/test/LiFiDiamondImmutable.t.sol

@@ -2,6 +2,7 @@
 pragma solidity 0.8.17;
 
 import { LiFiDiamondImmutable } from "lifi/LiFiDiamondImmutable.sol";
+import { LibDiamond } from "lifi/Libraries/LibDiamond.sol";
 import { DiamondCutFacet } from "lifi/Facets/DiamondCutFacet.sol";
 import { DiamondLoupeFacet } from "lifi/Facets/DiamondLoupeFacet.sol";
 import { OwnershipFacet } from "lifi/Facets/OwnershipFacet.sol";
@@ -17,7 +18,7 @@ contract LiFiDiamondImmutableTest is DSTest {
     address public diamondOwner;
 
     event DiamondCut(
-        IDiamondCut.FacetCut[] _diamondCut,
+        LibDiamond.FacetCut[] _diamondCut,
         address _init,
         bytes _calldata
     );
@@ -40,10 +41,10 @@ contract LiFiDiamondImmutableTest is DSTest {
         functionSelectors[0] = ownershipFacet.owner.selector;
 
         // prepare parameters for diamondCut (OwnershipFacet)
-        IDiamondCut.FacetCut[] memory cut = new IDiamondCut.FacetCut[](1);
-        cut[0] = IDiamondCut.FacetCut({
+        LibDiamond.FacetCut[] memory cut = new LibDiamond.FacetCut[](1);
+        cut[0] = LibDiamond.FacetCut({
             facetAddress: address(ownershipFacet),
-            action: IDiamondCut.FacetCutAction.Add,
+            action: LibDiamond.FacetCutAction.Add,
             functionSelectors: functionSelectors
         });
 
@@ -83,10 +84,10 @@ contract LiFiDiamondImmutableTest is DSTest {
         functionSelectors[3] = diamondLoupe.facetAddress.selector;
 
         // prepare diamondCut
-        IDiamondCut.FacetCut[] memory cuts = new IDiamondCut.FacetCut[](1);
-        cuts[0] = IDiamondCut.FacetCut({
+        LibDiamond.FacetCut[] memory cuts = new LibDiamond.FacetCut[](1);
+        cuts[0] = LibDiamond.FacetCut({
             facetAddress: address(diamondLoupe),
-            action: IDiamondCut.FacetCutAction.Add,
+            action: LibDiamond.FacetCutAction.Add,
             functionSelectors: functionSelectors
         });
 
@@ -104,10 +105,10 @@ contract LiFiDiamondImmutableTest is DSTest {
         functionSelectors[3] = diamondLoupe.facetAddress.selector;
 
         // prepare diamondCut
-        IDiamondCut.FacetCut[] memory cuts = new IDiamondCut.FacetCut[](1);
-        cuts[0] = IDiamondCut.FacetCut({
+        LibDiamond.FacetCut[] memory cuts = new LibDiamond.FacetCut[](1);
+        cuts[0] = LibDiamond.FacetCut({
             facetAddress: address(diamondLoupe),
-            action: IDiamondCut.FacetCutAction.Add,
+            action: LibDiamond.FacetCutAction.Add,
             functionSelectors: functionSelectors
         });
 

archive/test/MakerTeleportFacet.t.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: Unlicense
-pragma solidity 0.8.17;
+pragma solidity ^0.8.17;
 
 import { LibAllowList, LibSwap, TestBaseFacet, console, ERC20 } from "../utils/TestBaseFacet.sol";
 import { MakerTeleportFacet } from "lifi/Facets/MakerTeleportFacet.sol";

archive/test/MultiChainFacet.t.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: Unlicense
-pragma solidity 0.8.17;
+pragma solidity ^0.8.17;
 
 import { LibAllowList, TestBaseFacet, console, ERC20, LiFiDiamond } from "../utils/TestBaseFacet.sol";
 import { OnlyContractOwner, NotInitialized, AlreadyInitialized } from "src/Errors/GenericErrors.sol";

archive/test/NonStandardSelectorsRegistryFacet.t.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: MIT
-pragma solidity 0.8.17;
+pragma solidity ^0.8.17;
 
 import "../utils/TestBase.sol";
 import "lifi/Facets/NonStandardSelectorsRegistryFacet.sol";

archive/test/ServiceFeeCollector.t.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: Unlicense
-pragma solidity 0.8.17;
+pragma solidity ^0.8.17;
 
 import { DSTest } from "ds-test/test.sol";
 import { console } from "../utils/Console.sol";

archive/test/SynapseBridgeFacet.t.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: Unlicense
-pragma solidity 0.8.17;
+pragma solidity ^0.8.17;
 
 import { LibAllowList, TestBaseFacet, console } from "../utils/TestBaseFacet.sol";
 import { SynapseBridgeFacet } from "lifi/Facets/SynapseBridgeFacet.sol";

audit/auditLog.json

@@ -14,6 +14,13 @@
       "auditReportPath": "./audit/reports/2024.09.13_EmergencyPauseFacet.pdf",
       "auditCommitHash": "77441a088e0789513db4e068f7ef6c5c0988ee42"
     },
+    "audit20241007": {
+      "auditCompletedOn": "07.10.2024",
+      "auditedBy": "Sujith Somraaj (individual security researcher)",
+      "auditorGitHandle": "sujithsomraaj",
+      "auditReportPath": "./audit/reports/2024.10.07_AcrossV3.pdf",
+      "auditCommitHash": "ef2d7bc478ce1e7f5ad6f1060f657864124fa85e"
+    },
     "audit20241014": {
       "auditCompletedOn": "14.10.2024",
       "auditedBy": "Sujith Somraaj (individual security researcher)",
@@ -26,6 +33,15 @@
     "EmergencyPauseFacet": {
       "1.0.0": ["audit20240913"]
     },
+    "AcrossFacetV3": {
+      "1.0.0": ["audit20241007"]
+    },
+    "AcrossFacetPackedV3": {
+      "1.0.0": ["audit20241007"]
+    },
+    "ReceiverAcrossV3": {
+      "1.0.0": ["audit20241007"]
+    },
     "StargateFacetV2": {
       "1.0.1": ["audit20240814"]
     },