Redeploy stargate v2 #763
Redeploy stargate v2 #763
Conversation
WalkthroughThis update introduces significant enhancements to the deployment and auditing of smart contracts across multiple blockchain networks. It features a structured logging system for audits, updates to contract addresses, and improved management of contract versions. These changes enhance transparency and traceability, ensuring better operational efficiency within the deployment configurations. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Script
participant Network
User->>Script: Select Network
Script->>Network: Fetch Contract Information
Network-->>Script: Return Contract Details
Script->>User: Display Updated Contracts
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (8)
deployments/sei.json (1)
24-24: Update References to the New Contract AddressThe old contract address
0x139e0a9c4C90cC40D562859e8D6d3246C1915FD4is still present in several files. Please update these references to the new address0x6e378C84e657C57b2a8d183CFf30ee5CC8989b61to ensure consistency.
deployments/_deployments_log_file.jsondeployments/bsc.diamond.jsondeployments/base.diamond.jsondeployments/avalanche.diamond.jsondeployments/aurora.diamond.jsondeployments/arbitrum.diamond.jsonAnalysis chain
Verify the correctness of the new contract address.
The address for
StargateFacetV2has been updated. Ensure that this new address is correct and that all references to this contract in the codebase are updated to reflect this change.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all references to the updated `StargateFacetV2` address in the codebase. # Test: Search for the old and new addresses. Expect: No occurrences of the old address. rg --type json '0x139e0a9c4C90cC40D562859e8D6d3246C1915FD4' rg --type json '0x6e378C84e657C57b2a8d183CFf30ee5CC8989b61'Length of output: 4729
deployments/mantle.json (1)
25-25: Verify inconsistent contract address updates for StargateFacetV2The new contract address for
StargateFacetV2is not consistently applied across all deployment files. The following files contain different addresses forStargateFacetV2:
deployments/bsc.staging.jsondeployments/linea.jsondeployments/metis.jsondeployments/polygon.staging.jsonPlease review these files to ensure consistency and update the addresses as necessary.
Analysis chain
Verify the updated contract address.
Ensure that the new address for
StargateFacetV2(0x6e378C84e657C57b2a8d183CFf30ee5CC8989b61) is correctly updated in all relevant parts of the system and that any dependencies or documentation are also updated accordingly.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the usage of the new StargateFacetV2 address in the codebase. # Test: Search for the new address in the codebase. Expect: Consistent usage across all references. rg --type json '0x6e378C84e657C57b2a8d183CFf30ee5CC8989b61'Length of output: 3051
Script:
#!/bin/bash # Description: Search for any references to the old address in the codebase. # Test: Search for any potential references to the old address. rg --type json 'StargateFacetV2' --not '0x6e378C84e657C57b2a8d183CFf30ee5CC8989b61'Length of output: 514
Script:
#!/bin/bash # Description: Search for any references to the old address in the codebase. # Test: Search for any potential references to the old address by excluding the new address. rg --type json 'StargateFacetV2' | grep -v '0x6e378C84e657C57b2a8d183CFf30ee5CC8989b61'Length of output: 3792
deployments/gravity.diamond.json (1)
48-51: Incomplete Version Update for StargateFacetV2The update to version "1.0.1" for
StargateFacetV2is incomplete. The old version "1.0.0" is still present in multiple deployment files, includinggravity.diamond.json. Please ensure that all instances of the version are updated to "1.0.1" throughout the codebase.
- Files with old version "1.0.0" include:
deployments/gravity.diamond.jsondeployments/boba.diamond.jsondeployments/opbnb.diamond.jsondeployments/velas.diamond.json- And many others...
Analysis chain
Verify the new contract address and version for StargateFacetV2.
Ensure that the new address
0x6e378C84e657C57b2a8d183CFf30ee5CC8989b61and the version update to1.0.1are correct. Verify that all dependencies and documentation reflect these changes.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the usage of the new StargateFacetV2 address and version in the codebase. # Test: Search for occurrences of the new address and version. Expect: All references should be updated to the new address and version. rg --type json '0x6e378C84e657C57b2a8d183CFf30ee5CC8989b61' rg --type json '"Version": "1.0.1"'Length of output: 11167
Script:
#!/bin/bash # Search for occurrences of the old address and version in documentation and other files to ensure they have been updated. rg '0x[0-9a-fA-F]{40}' --type md --type js --type ts --type yaml --type yml rg '"Version": "1.0.0"' --type json --type md --type js --type ts --type yaml --type ymlLength of output: 224
Script:
#!/bin/bash # Correct the file type specification and search for occurrences of the old address and version. rg '0x[0-9a-fA-F]{40}' --type md --type js --type ts --type yaml rg '"Version": "1.0.0"' --type json --type md --type js --type ts --type yamlLength of output: 69769
deployments/sei.diamond.json (1)
56-58: Ensure Consistent Address forStargateFacetV2The address for
StargateFacetV2should be consistently updated to0x6e378C84e657C57b2a8d183CFf30ee5CC8989b61across all relevant files. The following files are using different addresses and may need to be updated:
deployments/polygon.staging.json:0xeb3f9490d8cbD0C34C0642a8d0495e5E0B0745AAdeployments/bsc.staging.json:0x089153117bffd37CBbE0c604dAE8e493D4743fA8deployments/linea.json:0x113E97921874646413572F2C43562463c378b6f5deployments/metis.json:0xCb667deA2894ab64e8e75EACB0d5d027AC672e25Please verify and update these files as necessary.
Analysis chain
Confirm new address for
StargateFacetV2.The address for
StargateFacetV2has been updated. Ensure that all references to this facet are updated accordingly in the codebase.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that all references to `StargateFacetV2` use the new address. # Test: Search for `StargateFacetV2` usage. Expect: Only occurrences of the new address. rg --type json 'StargateFacetV2'Length of output: 4831
Script:
#!/bin/bash # Description: List all occurrences of `StargateFacetV2` along with their addresses to identify discrepancies. # Extract all occurrences of `StargateFacetV2` and their associated addresses. rg --type json '"StargateFacetV2":' -A 1Length of output: 7547
deployments/mantle.diamond.json (3)
64-66: Inconsistent version update forStargateFacetV2.The address for
StargateFacetV2has been updated correctly in multiple deployment files. However, the version remains1.0.0inscript/deploy/_targetState.json, while it should be1.0.1as per the change indeployments/mantle.diamond.json. Please review and update the version in thescript/deploy/_targetState.jsonfile to maintain consistency.
script/deploy/_targetState.json: UpdateStargateFacetV2version to1.0.1.Analysis chain
Confirm address and version update for
StargateFacetV2.The address and version for
StargateFacetV2have been updated. Ensure that all references to this facet are updated accordingly in the codebase.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that all references to `StargateFacetV2` use the new address and version. # Test: Search for `StargateFacetV2` usage. Expect: Only occurrences of the new address and version. rg --type json 'StargateFacetV2'Length of output: 4831
77-77: UpdateReceiverStargateV2Address Across All FilesThe address for
ReceiverStargateV2should be updated to0x1493e7B8d4DfADe0a178dAD9335470337A3a219Aacross all relevant files. However, some files still reference different addresses. Please ensure consistency in the following files:
deployments/gravity.diamond.json: Uses0x6A3d6652fb7be72200a47313C092342218aAeb72deployments/gravity.json: Uses0x6A3d6652fb7be72200a47313C092342218aAeb72deployments/linea.json: Uses0x6CA57d9846f9a1fd48368762b743a047eC4f81A6deployments/metis.diamond.json: Uses0xe7392Fc0f61503dB53C70789c6F2c34C0675C929deployments/metis.json: Uses0xe7392Fc0f61503dB53C70789c6F2c34C0675C929deployments/optimism.staging.json: Uses0xCcC863C0BDae52EA076C44711f3C92D65f07DEb9Ensure these files are updated to maintain consistency.
Analysis chain
Confirm new address for
ReceiverStargateV2.The address for
ReceiverStargateV2has been updated. Ensure that all references to this component are updated accordingly.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that all references to `ReceiverStargateV2` use the new address. # Test: Search for `ReceiverStargateV2` usage. Expect: Only occurrences of the new address. rg --type json 'ReceiverStargateV2'Length of output: 5219
74-74: LiFiDEXAggregator Address MissingThe
LiFiDEXAggregatorshould have an address specified in thedeployments/mantle.diamond.jsonfile. The presence of deployment scripts and reminders about whitelisting indicate that an address is necessary. Please ensure that the correct address is provided.
deployments/mantle.diamond.json:"LiFiDEXAggregator": ""Analysis chain
Check for
LiFiDEXAggregatoraddress.The
LiFiDEXAggregatorentry is currently set to an empty string. Verify if this is intentional or if an address should be provided.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check if `LiFiDEXAggregator` should have an address. # Test: Search for `LiFiDEXAggregator` references. Expect: Clarification on address requirement. rg --type json 'LiFiDEXAggregator'Length of output: 1561
Script:
#!/bin/bash # Description: Search for `LiFiDEXAggregator` references in non-JSON files to understand its usage context. rg 'LiFiDEXAggregator' --type-not json -A 5Length of output: 2582
deployments/polygon.json (1)
51-51: Incomplete Update ofStargateFacetV2AddressThe address for
StargateFacetV2has not been fully updated across the codebase. The old address0x139e0a9c4C90cC40D562859e8D6d3246C1915FD4still exists in several files. Please ensure all references are updated to the new address0x6e378C84e657C57b2a8d183CFf30ee5CC8989b61to avoid inconsistencies.
deployments/bsc.diamond.jsondeployments/base.diamond.jsondeployments/avalanche.diamond.jsondeployments/aurora.diamond.jsondeployments/arbitrum.diamond.jsonAnalysis chain
Verify the impact of changing the
StargateFacetV2address.The address for
StargateFacetV2has been updated. Ensure that all references to this address in the codebase are updated accordingly to prevent any disruptions in contract interactions.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all references to the `StargateFacetV2` address are updated. # Test: Search for the old and new addresses in the codebase. rg --type json '0x139e0a9c4C90cC40D562859e8D6d3246C1915FD4|0x6e378C84e657C57b2a8d183CFf30ee5CC8989b61'Length of output: 4714
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
audit/reports/2024.08.14_StargateFacetV2_ReAudit.pdfis excluded by!**/*.pdf
Files selected for processing (34)
- audit/auditLog.json (1 hunks)
- deployments/_deployments_log_file.json (15 hunks)
- deployments/arbitrum.json (1 hunks)
- deployments/aurora.json (1 hunks)
- deployments/avalanche.json (1 hunks)
- deployments/base.json (1 hunks)
- deployments/bsc.json (1 hunks)
- deployments/gravity.diamond.json (1 hunks)
- deployments/gravity.json (1 hunks)
- deployments/linea.json (1 hunks)
- deployments/mainnet.diamond.immutable.json (2 hunks)
- deployments/mainnet.diamond.json (6 hunks)
- deployments/mainnet.diamond.staging.json (2 hunks)
- deployments/mainnet.json (1 hunks)
- deployments/mantle.diamond.json (1 hunks)
- deployments/mantle.json (1 hunks)
- deployments/metis.diamond.json (1 hunks)
- deployments/metis.json (1 hunks)
- deployments/optimism.diamond.immutable.json (3 hunks)
- deployments/optimism.diamond.json (5 hunks)
- deployments/optimism.diamond.staging.json (1 hunks)
- deployments/optimism.json (1 hunks)
- deployments/polygon.diamond.immutable.json (3 hunks)
- deployments/polygon.diamond.json (4 hunks)
- deployments/polygon.diamond.staging.json (1 hunks)
- deployments/polygon.json (1 hunks)
- deployments/scroll.diamond.json (2 hunks)
- deployments/scroll.json (1 hunks)
- deployments/sei.diamond.json (2 hunks)
- deployments/sei.json (1 hunks)
- script/deploy/safe/config.ts (1 hunks)
- script/deploy/safe/confirm-safe-tx.ts (2 hunks)
- script/helperFunctions.sh (1 hunks)
- script/scriptMaster.sh (1 hunks)
Files skipped from review due to trivial changes (1)
- script/helperFunctions.sh
Additional context used
Gitleaks
deployments/mainnet.diamond.staging.json
112-112: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.
(generic-api-key)
deployments/optimism.diamond.json
148-148: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.
(generic-api-key)
Additional comments not posted (91)
audit/auditLog.json (1)
1-16: Ensure accuracy and completeness of audit metadata.The audit log is well-structured and provides essential details about the audit. Verify that the metadata, such as the audit date, auditor's name, and commit hash, are accurate and up-to-date. Ensure that the audit report path is correct and accessible.
deployments/gravity.json (1)
20-20: Verify the correctness of the new contract address.The address for
StargateFacetV2has been updated. Ensure that this new address is correct and that all references to this contract in the codebase are updated to reflect this change.deployments/metis.json (1)
25-25: Verify the updated contract address.Ensure that the new address for
StargateFacetV2(0xCb667deA2894ab64e8e75EACB0d5d027AC672e25) is correctly updated in all relevant parts of the system and that any dependencies or documentation are also updated accordingly.Verification successful
Address Update Verified: StargateFacetV2
The new contract address for
StargateFacetV2(0xCb667deA2894ab64e8e75EACB0d5d027AC672e25) is correctly updated in the relevant deployment files. There are no additional references to this specific address elsewhere in the codebase, which is typical for deployment-specific configurations. The update appears consistent and complete.
deployments/metis.jsondeployments/metis.diamond.jsondeployments/_deployments_log_file.jsonScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the usage of the new StargateFacetV2 address in the codebase. # Test: Search for the new address in the codebase. Expect: Consistent usage across all references. rg --type json '0xCb667deA2894ab64e8e75EACB0d5d027AC672e25'Length of output: 342
Script:
#!/bin/bash # Search for references to StargateFacetV2 in the codebase to ensure all dependencies and documentation are updated. rg 'StargateFacetV2'Length of output: 8377
deployments/scroll.json (1)
27-27: Verify the updated contract address.Ensure that the new address for
StargateFacetV2(0x6e378C84e657C57b2a8d183CFf30ee5CC8989b61) is correctly updated in all relevant parts of the system and that any dependencies or documentation are also updated accordingly.deployments/aurora.json (1)
31-31: Verify the new contract address for StargateFacetV2.Ensure that the new address
0x6e378C84e657C57b2a8d183CFf30ee5CC8989b61is correct and that all dependencies and documentation are updated accordingly.Verification successful
New contract address for StargateFacetV2 is correctly updated.
The new address
0x6e378C84e657C57b2a8d183CFf30ee5CC8989b61is consistently used across deployment files, and there are no outdated references. Documentation does not require address updates as it doesn't specify addresses.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the usage of the new StargateFacetV2 address in the codebase. # Test: Search for occurrences of the new address. Expect: All references should be updated to the new address. rg --type json '0x6e378C84e657C57b2a8d183CFf30ee5CC8989b61'Length of output: 3051
Script:
#!/bin/bash # Description: Search for occurrences of the old StargateFacetV2 address in the codebase. # Test: Identify any remaining references to the old address. rg --type json 'StargateFacetV2' # Description: Check for documentation files mentioning StargateFacetV2. rg --type md 'StargateFacetV2'Length of output: 5387
deployments/linea.json (1)
35-35: Verify the new contract address for StargateFacetV2.Ensure that the new address
0x113E97921874646413572F2C43562463c378b6f5is correct and that all dependencies and documentation are updated accordingly.deployments/gravity.diamond.json (2)
62-62: Ensure the LiFiDEXAggregator entry is completed.The
LiFiDEXAggregatorentry is currently empty. Ensure that this is intentional and update it with the correct address if available.
52-54: Verify the new entry for GenericSwapFacetV3.Ensure that the new entry for
GenericSwapFacetV3with address0x83037e2fF2B3Ea09fED5A6e8150bf9899673f33Aand version1.0.1is correctly integrated and documented.Verification successful
GenericSwapFacetV3 Entry Verified
The new entry for
GenericSwapFacetV3with address0x83037e2fF2B3Ea09fED5A6e8150bf9899673f33Aand version1.0.1is correctly integrated and documented in the codebase. It is referenced in source code, tests, and a dedicated documentation file. The address and version are consistently used across deployment configurations.
- Source and test files:
src/Facets/GenericSwapFacetV3.sol,test/solidity/Facets/GenericSwapFacetV3.t.sol- Documentation:
docs/GenericSwapFacetV3.md- Deployment files:
deployments/gravity.json,deployments/gravity.diamond.json, and others with version1.0.1Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the usage of the new GenericSwapFacetV3 entry in the codebase. # Test: Search for occurrences of the new address and version. Expect: All references should be updated to the new address and version. rg --type json '0x83037e2fF2B3Ea09fED5A6e8150bf9899673f33A' rg --type json '"Version": "1.0.1"'Length of output: 8465
Script:
#!/bin/bash # Search for mentions of GenericSwapFacetV3 in the codebase to verify its documentation and integration. rg 'GenericSwapFacetV3'Length of output: 16277
deployments/sei.diamond.json (3)
69-69: Confirm new address forReceiverStargateV2.The address for
ReceiverStargateV2has been updated. Ensure that all references to this component are updated accordingly.
66-66: Check forLiFiDEXAggregatoraddress.The
LiFiDEXAggregatorentry is currently set to an empty string. Verify if this is intentional or if an address should be provided.
52-55: Verify removal ofGenericSwapFacetV3.The entry for
GenericSwapFacetV3has been removed. Ensure that this removal is intentional and does not affect any dependent components.deployments/base.json (1)
38-38: Verify address update forStargateFacetV2.The address for
StargateFacetV2has been updated. Ensure that all references to this facet are updated accordingly in the codebase.deployments/metis.diamond.json (4)
65-66: Clarify the purpose ofCalldataVerificationFacet.The facet
CalldataVerificationFacethas been named and versioned. Ensure that the purpose and functionality of this facet are documented, as it is crucial for understanding its role in the deployment.
68-70: Verify the update ofStargateFacetV2address and version.The address and version for
StargateFacetV2have been updated. Ensure that this change is reflected in all relevant documentation and that the new version has been tested.
78-78: Specify the address forLiFiDEXAggregator.The entry for
LiFiDEXAggregatoris currently without an address. Ensure that this is intentional and that the address will be specified before deployment.
81-81: Confirm the address forReceiverStargateV2.The address for
ReceiverStargateV2has been specified. Verify that this address is correct and corresponds to the intended contract.deployments/scroll.diamond.json (4)
36-38: Verify the update ofStandardizedCallFacetaddress and version.The address and version for
StandardizedCallFacethave been updated. Ensure that this change is reflected in all relevant documentation and that the new version has been tested.
72-74: Verify the update ofStargateFacetV2address and version.The address and version for
StargateFacetV2have been updated. Ensure that this change is reflected in all relevant documentation and that the new version has been tested.
82-82: Specify the address forLiFiDEXAggregator.The entry for
LiFiDEXAggregatoris currently without an address. Ensure that this is intentional and that the address will be specified before deployment.
85-85: Confirm the address forReceiverStargateV2.The address for
ReceiverStargateV2has been specified. Verify that this address is correct and corresponds to the intended contract.deployments/avalanche.json (1)
45-45: Verify the update ofStargateFacetV2address.The address for
StargateFacetV2has been updated. Ensure that this change is reflected in all relevant documentation and that the new address has been tested for correctness.deployments/bsc.json (1)
47-47: Verify the consistency of theStargateFacetV2address update.Ensure that the new address
"0x6e378C84e657C57b2a8d183CFf30ee5CC8989b61"is consistently updated across all relevant deployment configuration files.Verification successful
StargateFacetV2 Address Consistency Verified
The
StargateFacetV2address0x6e378C84e657C57b2a8d183CFf30ee5CC8989b61has been consistently updated across all relevant deployment configuration files. No inconsistencies were found.
- Files verified:
sei.json,polygon.json,scroll.json,optimism.json,mantle.json,gravity.json,bsc.json,base.json,avalanche.json,aurora.json,arbitrum.json,mainnet.jsonScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the consistency of the `StargateFacetV2` address across all deployment files. # Test: Search for the `StargateFacetV2` address in all JSON files. Expect: Only the new address should be present. rg --type json '"StargateFacetV2": "0x6e378C84e657C57b2a8d183CFf30ee5CC8989b61"'Length of output: 1174
deployments/optimism.json (1)
47-47: Verify the consistency of theStargateFacetV2address update.Ensure that the new address
"0x6e378C84e657C57b2a8d183CFf30ee5CC8989b61"is consistently updated across all relevant deployment configuration files.deployments/arbitrum.json (1)
48-48: Verify the consistency of theStargateFacetV2address update.Ensure that the new address
"0x6e378C84e657C57b2a8d183CFf30ee5CC8989b61"is consistently updated across all relevant deployment configuration files.deployments/optimism.diamond.immutable.json (2)
5-6: Consider the implications of removingNameandVersionattributes.The removal of
NameandVersionattributes for multiple facets might impact how these facets are referenced or managed. Ensure that this change aligns with the overall system architecture and does not affect any dependent components.Also applies to: 9-10, 13-14, 17-18, 21-22, 25-26, 29-30, 41-42, 45-46, 49-50, 53-54, 57-58, 61-62, 65-66, 77-78, 81-82, 85-86, 93-94
Verification successful
Removal of
NameandVersionAttributes VerifiedThe removal of the
NameandVersionattributes indeployments/optimism.diamond.immutable.jsondoes not impact any dependent components, as no dependencies or references to these fields were found elsewhere in the codebase. This change appears to be safe and consistent with the current system architecture.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify if the removal of `Name` and `Version` attributes affects any dependent components. # Test: Search for references to these attributes in the codebase. rg --type json '"Name":| "Version":'Length of output: 165819
101-103: Review the addition of new entries in thePeripherysection.The new entries in the
Peripherysection are initialized with empty strings. Ensure that these entries are configured correctly in the deployment process and that their initialization aligns with the intended functionality.Also applies to: 105-105, 107-108
deployments/polygon.diamond.immutable.json (2)
5-6: Consider the implications of removingNameandVersionattributes.The removal of
NameandVersionattributes for multiple facets might impact how these facets are referenced or managed. Ensure that this change aligns with the overall system architecture and does not affect any dependent components.Also applies to: 9-10, 13-14, 17-18, 21-22, 25-26, 29-30, 33-34, 45-46, 49-50, 53-54, 57-58, 61-62, 65-66, 81-82, 85-86, 89-90, 97-98, 101-102
109-111: Review the addition of new entries in thePeripherysection.The new entries in the
Peripherysection are initialized with empty strings. Ensure that these entries are configured correctly in the deployment process and that their initialization aligns with the intended functionality.Also applies to: 113-113, 115-116
deployments/mainnet.diamond.staging.json (4)
105-112: Complete thePeripheryentries.The new entries in the
Peripherysection are currently empty strings. Ensure these are placeholders and will be populated with valid addresses or values before deployment.Tools
Gitleaks
112-112: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.
(generic-api-key)
112-112: Investigate potential API key exposure.Static analysis detected a potential API key exposure at this line. Ensure this is not sensitive information or replace it with a secure reference.
Verification successful
No API Key Exposure Detected
The address "0x5215E9fd223BC909083fbdB2860213873046e45d" is used as a "TokenWrapper" in multiple deployment files. This indicates it is a smart contract address, which is public information and not sensitive like an API key. No action is needed.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check for potential API key exposure in the file. # Test: Search for sensitive information patterns. Expect: No sensitive data exposure. rg --type json --json '5215E9fd223BC909083fbdB2860213873046e45d'Length of output: 35868
Tools
Gitleaks
112-112: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.
(generic-api-key)
96-98: Define the new facet entry.The new entry with an empty
NameandVersionsuggests it might be a placeholder. Ensure this entry is correctly defined before deployment.
66-66: Clarify the version reset forAllBridgeFacet.The
VersionforAllBridgeFacethas been changed to an empty string. Ensure this is intentional and verify if this change impacts any dependent systems or documentation.deployments/mainnet.json (1)
56-56: Validate the new address forStargateFacetV2.The address for
StargateFacetV2has been updated. Ensure this change is correct and verify its impact on the deployment and any related contracts.deployments/mainnet.diamond.immutable.json (3)
129-136: Complete thePeripheryentries.The new entries in the
Peripherysection are currently empty strings. Ensure these are placeholders and will be populated with valid addresses or values before deployment.
127-127: Verify the updatedExecutoraddress.The
Executoraddress has been changed. Ensure this update is correct and verify its impact on the deployment.
Line range hint
5-122: Confirm the reset of facet names and versions.The
NameandVersionfields for multiple facets have been reset to empty strings. Confirm this is intentional and assess the impact on the system's configuration and documentation.deployments/polygon.diamond.staging.json (1)
122-122: EnsureLiFiDEXAggregatoris configured properly.The entry for
LiFiDEXAggregatorhas been added with an empty value. Ensure that this is updated with the correct address or configuration details before deployment to avoid runtime issues.deployments/optimism.diamond.staging.json (3)
112-114: Specify contract details for address0xa137Fe4C41A2E04ca34578DC9023ad45cC194389.The contract entry has an empty
NameandVersion. Ensure these are specified to maintain clarity and traceability within the deployment configuration.
122-122: EnsureGasRebateDistributoris configured properly.The entry for
GasRebateDistributorhas been added with an empty value. Ensure this is updated with the correct address or configuration details before deployment.
123-123: EnsureLiFiDEXAggregatoris configured properly.The entry for
LiFiDEXAggregatorhas been added with an empty value. Ensure this is updated with the correct address or configuration details before deployment.deployments/polygon.diamond.json (7)
4-6: Specify contract details for address0xf7993A8df974AD022647E63402d6315137c58ABf.The contract entry has an empty
NameandVersion. Ensure these are specified to maintain clarity and traceability within the deployment configuration.
8-10: Specify contract details for address0xF5ba8Db6fEA7aF820De35C8D0c294e17DBC1b9D2.The contract entry has an empty
NameandVersion. Ensure these are specified to maintain clarity and traceability within the deployment configuration.
44-46: Specify contract details for address0x3a60730cbcD91715E31830f125bB3eF1FA0a2c66.The contract entry has an empty
NameandVersion. Ensure these are specified to maintain clarity and traceability within the deployment configuration.
100-102: Specify contract details for address0x9558CacEAC173Bdf32fb4cd7067e9e3c3b4c155e.The contract entry has an empty
NameandVersion. Ensure these are specified to maintain clarity and traceability within the deployment configuration.
141-141: EnsureGasRebateDistributoris configured properly.The entry for
GasRebateDistributorhas been added with an empty value. Ensure this is updated with the correct address or configuration details before deployment.
142-142: EnsureLiFiDEXAggregatoris configured properly.The entry for
LiFiDEXAggregatorhas been added with an empty value. Ensure this is updated with the correct address or configuration details before deployment.
145-145: VerifyReceiverStargateV2configuration.The
ReceiverStargateV2entry has been added. Ensure this is correctly configured and integrated within the system.deployments/optimism.diamond.json (12)
4-11: Ensure facets have defined names and versions.The facets with addresses
0xf7993A8df974AD022647E63402d6315137c58ABfand0xF5ba8Db6fEA7aF820De35C8D0c294e17DBC1b9D2have emptyNameandVersionfields. Ensure these are intentional placeholders or update them with meaningful values to avoid potential issues.
16-17: LGTM! Verify usage ofAcrossFacetPacked.The facet name has been updated to
AcrossFacetPacked. Ensure that all references to this facet in the system are updated accordingly.
64-66: LGTM! Verify compatibility ofLIFuelFacetversion update.The
LIFuelFacetversion has been updated to1.0.1. Ensure that this version is compatible with other components in the system.
82-82: LGTM! Verify compatibility ofCelerIMFacetMutableversion update.The
CelerIMFacetMutableversion has been updated to2.0.0. Ensure that this version is compatible with other components in the system.
84-87: LGTM! Verify integration ofGenericSwapFacetV3.The new facet
GenericSwapFacetV3has been added. Ensure it is properly integrated and tested within the system.
88-90: LGTM! Verify integration ofMayanFacet.The new facet
MayanFacethas been added. Ensure it is properly integrated and tested within the system.
96-98: LGTM! Verify compatibility ofStandardizedCallFacetversion update.The
StandardizedCallFacetversion has been updated to1.1.0. Ensure that this version is compatible with other components in the system.
108-111: Ensure facet has a defined name and version.The facet with address
0xF965f52046D7095d5080bD31459601F4Eb24f72Dhas emptyNameandVersionfields. Ensure these are intentional placeholders or update them with meaningful values to avoid potential issues.
116-117: LGTM! Verify integration ofWithdrawFacet.The
WithdrawFacethas been reintroduced. Ensure it is properly integrated and tested within the system.
132-134: LGTM! Verify compatibility ofStargateFacetV2version update.The
StargateFacetV2version has been updated to1.0.1. Ensure that this version is compatible with other components in the system.
141-142: EnsureGasRebateDistributorandLiFiDEXAggregatorhave defined values.The
GasRebateDistributorandLiFiDEXAggregatorhave empty values. Ensure these are intentional placeholders or update them with meaningful values to avoid potential issues.
145-145: LGTM! Verify integration ofReceiverStargateV2.The new entry
ReceiverStargateV2has been added. Ensure it is properly integrated and tested within the system.deployments/mainnet.diamond.json (12)
4-11: Ensure facets have defined names and versions.The facets with addresses
0xf7993A8df974AD022647E63402d6315137c58ABfand0xF5ba8Db6fEA7aF820De35C8D0c294e17DBC1b9D2have emptyNameandVersionfields. Ensure these are intentional placeholders or update them with meaningful values to avoid potential issues.
16-17: LGTM! Verify usage ofAcrossFacetPacked.The facet name has been updated to
AcrossFacetPacked. Ensure that all references to this facet in the system are updated accordingly.
28-31: Ensure facet has a defined name and version.The facet with address
0x0b5726b7348efBdA8620D5C374F85Cbe8f040B6ahas emptyNameandVersionfields. Ensure these are intentional placeholders or update them with meaningful values to avoid potential issues.
64-67: Ensure facet has a defined name and version.The facet with address
0x87C10910DA7258E55dA2C5d43739fB68B12E6a4bhas emptyNameandVersionfields. Ensure these are intentional placeholders or update them with meaningful values to avoid potential issues.
72-72: LGTM! Verify compatibility ofStargateFacetversion update.The
StargateFacetversion has been updated to2.2.0. Ensure that this version is compatible with other components in the system.
80-80: LGTM! Verify compatibility ofGenericSwapFacetversion update.The
GenericSwapFacetversion has been updated to2.0.0. Ensure that this version is compatible with other components in the system.
92-94: LGTM! Verify compatibility ofLIFuelFacetversion update.The
LIFuelFacetversion has been updated to1.0.1. Ensure that this version is compatible with other components in the system.
114-114: LGTM! Verify compatibility ofCelerIMFacetMutableversion update.The
CelerIMFacetMutableversion has been updated to2.0.0. Ensure that this version is compatible with other components in the system.
116-118: LGTM! Verify compatibility ofStandardizedCallFacetversion update.The
StandardizedCallFacetversion has been updated to1.1.0. Ensure that this version is compatible with other components in the system.
124-127: Ensure facet has a defined name and version.The facet with address
0xF965f52046D7095d5080bD31459601F4Eb24f72Dhas emptyNameandVersionfields. Ensure these are intentional placeholders or update them with meaningful values to avoid potential issues.
132-135: LGTM! Verify integration ofWithdrawFacet.The
WithdrawFacethas been reintroduced. Ensure it is properly integrated and tested within the system.
156-158: LGTM! Verify compatibility ofStargateFacetV2version update.The
StargateFacetV2version has been updated to1.0.1. Ensure that this version is compatible with other components in the system.script/deploy/safe/config.ts (1)
71-72: LGTM! Verify contract addresses for chainId 13371.Support for chainId 13371 (Boba, Metis, IMX) has been added. Ensure that the contract addresses are accurate and complete for these networks.
script/deploy/safe/confirm-safe-tx.ts (3)
10-10: Import Path Standardization.The removal of the file extension from the import path is a good practice for consistency and may align with TypeScript or bundler configurations.
82-82: Verify Network Name Usage fortxServiceUrl.The change to use
network.toLowerCase()fortxServiceUrlshould be verified to ensure it aligns with the intended logic of using network names over chain names.
87-87: Verify Network Name Usage forsafeAddress.The change to use
network.toLowerCase()forsafeAddressshould be verified to ensure it aligns with the intended logic of using network names over chain names.Verification successful
Isolated Usage of
network.toLowerCase()forsafeAddress.The change to use
network.toLowerCase()forsafeAddressis isolated to the specific line inscript/deploy/safe/confirm-safe-tx.ts. This suggests an intentional update for this context without conflicting with other parts of the codebase. Further manual verification might be needed if broader consistency is a concern.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that `network.toLowerCase()` is correctly used for `safeAddress`. # Test: Search for usage of `safeAddresses` to ensure consistency. rg --type typescript -A 3 $'safeAddresses[network.toLowerCase()]'Length of output: 101
Script:
#!/bin/bash # Description: Verify that `network.toLowerCase()` is correctly used for `safeAddress`. # Test: Search for usage of `safeAddresses` to ensure consistency. rg --type ts -A 3 $'safeAddresses[network.toLowerCase()]'Length of output: 367
Script:
#!/bin/bash # Description: Broader search for `network.toLowerCase()` to ensure consistent usage with `safeAddresses`. # Test: Search for `network.toLowerCase()` in the context of `safeAddresses`. rg --type ts -A 3 'network.toLowerCase()' | rg 'safeAddresses'Length of output: 159
script/scriptMaster.sh (1)
469-469: Verify Conditional Logic Change.The change to check
SELECTION_NETWORKinstead ofSELECTION_DIAMOND_TYPEshould be verified to ensure it aligns with the intended behavior of the script.Verification successful
Conditional Logic Change Verified.
The change from
SELECTION_DIAMOND_TYPEtoSELECTION_NETWORKis consistent with the script's logic, asSELECTION_NETWORKis used in multiple conditional checks throughout the script. This indicates that the change aligns with the intended behavior.
- The variable
SELECTION_NETWORKis assigned and checked in multiple places, confirming its role in the script's logic.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the logic change from `SELECTION_DIAMOND_TYPE` to `SELECTION_NETWORK`. # Test: Search for usage of `SELECTION_NETWORK` to ensure consistency. rg --type shell -A 3 $'SELECTION_NETWORK'Length of output: 70
Script:
#!/bin/bash # Description: Verify the logic change from `SELECTION_DIAMOND_TYPE` to `SELECTION_NETWORK`. # Find all shell script files and search for `SELECTION_NETWORK`. fd --extension sh --exec rg 'SELECTION_NETWORK' {}Length of output: 426
deployments/_deployments_log_file.json (15)
21479-21487: LGTM!The JSON entry for version "1.0.1" is well-structured and consistent with the expected format.
21503-21511: LGTM!The JSON entry for version "1.0.1" is well-structured and consistent with the expected format.
21527-21535: LGTM!The JSON entry for version "1.0.1" is well-structured and consistent with the expected format.
21551-21559: LGTM! Note theVERIFIEDstatus.The JSON entry for version "1.0.1" is well-structured. The
VERIFIEDstatus is "false", which may require attention.
21575-21583: LGTM!The JSON entry for version "1.0.1" is well-structured and consistent with the expected format.
21599-21607: LGTM!The JSON entry for version "1.0.1" is well-structured and consistent with the expected format.
21623-21631: LGTM!The JSON entry for version "1.0.1" is well-structured and consistent with the expected format.
21647-21655: LGTM!The JSON entry for version "1.0.1" is well-structured and consistent with the expected format.
21671-21679: LGTM!The JSON entry for version "1.0.1" is well-structured and consistent with the expected format.
21695-21703: LGTM!The JSON entry for version "1.0.1" is well-structured and consistent with the expected format.
21719-21727: LGTM!The JSON entry for version "1.0.1" is well-structured and consistent with the expected format.
21743-21751: LGTM! Note theVERIFIEDstatus.The JSON entry for version "1.0.1" is well-structured. The
VERIFIEDstatus is "false", which may require attention.
21767-21775: LGTM!The JSON entry for version "1.0.1" is well-structured and consistent with the expected format.
21803-21811: LGTM! Note theSALT.The JSON entry for version "1.0.1" is well-structured. The
SALTfield is non-empty, which is noted.
21802-21811: LGTM!The closing of the JSON structure is consistent with the expected format.
…nto redeployStargateV2
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- deployments/_deployments_log_file.json (15 hunks)
- deployments/linea.diamond.json (3 hunks)
- script/helperFunctions.sh (2 hunks)
Additional comments not posted (23)
deployments/linea.diamond.json (6)
32-35: Verify the correctness of the new address forLIFuelFacet.The address has been updated, and the version incremented to "1.0.1". Ensure that this reflects the intended deployment changes.
52-54: Verify the correctness of the new address forStargateFacet.The address has been updated, and the version incremented to "2.2.0". Ensure that this reflects the intended deployment changes.
104-106: Verify the correctness of the new address forStargateFacetV2.The address has been added with version "1.0.1". Ensure that this reflects the intended deployment changes.
117-117: Verify the correctness of theReceiverStargateV2entry.The entry has been added. Ensure that this reflects the intended deployment changes.
114-114: Verify the correctness of theLiFiDEXAggregatorentry.The entry for "GasRebateDistributor" has been replaced with "LiFiDEXAggregator". Ensure this change aligns with the deployment goals.
Verification successful
The change to
LiFiDEXAggregatoris consistent with the deployment strategy.The entry for
LiFiDEXAggregatoris present in multiple deployment files with similar configurations, indicating it is part of a standard setup. The empty string suggests it's either not yet configured or intentionally left blank for certain environments. This aligns with typical deployment practices.
deployments/linea.diamond.json:"LiFiDEXAggregator": ""deployments/immutablezkevm.diamond.json:"LiFiDEXAggregator": "0xAcD913Ad6936Bb662395ac9a66D75bFc77c165fF"deployments/bsc.staging.json:"LiFiDEXAggregator": "0xD6f02718B9df9FAd2665c7304BC5b26D5bbD8642"Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the entry change from GasRebateDistributor to LiFiDEXAggregator in the codebase. # Test: Search for references to LiFiDEXAggregator to confirm its correctness. rg --type json 'LiFiDEXAggregator'Length of output: 1623
48-50: Verify the correctness of the new address forStandardizedCallFacet.The address has been updated, and the version incremented to "1.1.0". Ensure that this reflects the intended deployment changes.
script/helperFunctions.sh (2)
3753-3755: Verify the correctness of updated variables.Ensure that the
CONTRACT,NETWORK, andADDRESSvalues are correct and intended for the redeployment of Stargate v2. Incorrect values can lead to failed contract verification.Verification successful
The updated contract address appears correct.
The address
0x113E97921874646413572F2C43562463c378b6f5is consistently used across deployment files, suggesting it is the correct address for theStargateFacetV2contract on thelineanetwork. The changes inscript/helperFunctions.shalign with the deployment configuration. No issues found.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the correctness of CONTRACT, NETWORK, and ADDRESS variables in the test_tmp function. # Test: Check if the contract address exists in the deployment logs. rg --type shell --word-regexp "0x113E97921874646413572F2C43562463c378b6f5"Length of output: 104
Script:
#!/bin/bash # Description: Verify the correctness of CONTRACT, NETWORK, and ADDRESS variables in the test_tmp function. # Test: Check if the contract address exists in the codebase. rg "0x113E97921874646413572F2C43562463c378b6f5"Length of output: 411
Line range hint
3769-3769:
Ensure theverifyContractfunction is called correctly.The function call should match the expected parameters for the updated contract and network. Verify that the
ARGSvariable is correctly formatted for the contract's constructor arguments.deployments/_deployments_log_file.json (15)
21478-21487: Entry is well-formed.This deployment entry is consistent and includes all necessary fields.
21502-21511: Entry is well-formed.This deployment entry is consistent and includes all necessary fields.
21526-21535: Entry is well-formed.This deployment entry is consistent and includes all necessary fields.
21550-21559: Verify theVERIFIEDstatus.The
VERIFIEDstatus is "false". Ensure this is intentional and that the contract verification process is complete.
21574-21583: Entry is well-formed.This deployment entry is consistent and includes all necessary fields.
21598-21607: Entry is well-formed.This deployment entry is consistent and includes all necessary fields.
21622-21631: Entry is well-formed.This deployment entry is consistent and includes all necessary fields.
21646-21655: Entry is well-formed.This deployment entry is consistent and includes all necessary fields.
21670-21679: Entry is well-formed.This deployment entry is consistent and includes all necessary fields.
21694-21703: Entry is well-formed.This deployment entry is consistent and includes all necessary fields.
21718-21727: Entry is well-formed.This deployment entry is consistent and includes all necessary fields.
21742-21751: Verify theVERIFIEDstatus.The
VERIFIEDstatus is "false". Ensure this is intentional and that the contract verification process is complete.
21766-21775: Entry is well-formed.This deployment entry is consistent and includes all necessary fields.
21802-21811: Entry is well-formed.This deployment entry is consistent and includes all necessary fields.
21803-21807: JSON structure is well-formed.The JSON structure is correctly closed and formatted.
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
audit/reports/2024.08.14_StargateFacetV2_ReAudit.pdfis excluded by!**/*.pdf
Files selected for processing (3)
- deployments/_deployments_log_file.json (14 hunks)
- script/deploy/safe/config.ts (1 hunks)
- script/helperFunctions.sh (1 hunks)
Files skipped from review as they are similar to previous changes (2)
- script/deploy/safe/config.ts
- script/helperFunctions.sh
Additional comments not posted (14)
deployments/_deployments_log_file.json (14)
21796-21804: Entry Approved: Consistent Deployment Log Entry.The entry adheres to the expected structure and format for deployment logs.
21820-21828: Entry Approved: Consistent Deployment Log Entry.The entry maintains the expected structure and data integrity.
21844-21852: Entry Approved: Consistent Deployment Log Entry.The entry follows the expected structure and format.
21892-21900: Entry Approved: Consistent Deployment Log Entry.The entry maintains data integrity and expected format.
21916-21924: Entry Approved: Consistent Deployment Log Entry.The entry follows the expected structure and format.
21940-21948: Entry Approved: Consistent Deployment Log Entry.The entry maintains data integrity and expected format.
21964-21972: Entry Approved: Consistent Deployment Log Entry.The entry maintains data integrity and expected format.
21988-21996: Entry Approved: Consistent Deployment Log Entry.The entry maintains data integrity and expected format.
22012-22020: Entry Approved: Consistent Deployment Log Entry.The entry follows the expected structure and format.
22036-22044: Entry Approved: Consistent Deployment Log Entry.The entry maintains data integrity and expected format.
22084-22092: Entry Approved: Consistent Deployment Log Entry.The entry maintains data integrity and expected format.
22120-22128: Entry Approved: Consistent Deployment Log Entry.The entry follows the expected structure and format.
21868-21876: Verify Unverified Status.The
VERIFIEDstatus is "false". Ensure this is intentional and verify the reason.
22060-22068: Verify Unverified Status.The
VERIFIEDstatus is "false". Ensure this is intentional and verify the reason.
Which Jira task belongs to this PR?
https://lifi.atlassian.net/browse/LF-9262
Why did I implement it this way?
Checklist before requesting a review
Checklist for reviewer (DO NOT DEPLOY and contracts BEFORE CHECKING THIS!!!)
Summary by CodeRabbit
New Features
Bug Fixes
StargateFacetV2, ensuring correct contract interactions across multiple networks.Documentation