Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase test coverage #785

Merged
merged 2 commits into from
Sep 4, 2024
Merged

Increase test coverage #785

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
48b4a00
temp - DO NOT PUSH
0xDEnYO Aug 6, 2024
e700e5b
Merge branch 'main' of github.com:lifinance/contracts into increaseTe…
0xDEnYO Sep 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
103 changes: 103 additions & 0 deletions test/solidity/LiFiDiamond.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,103 @@
// SPDX-License-Identifier: Unlicensed
pragma solidity 0.8.17;

import { LiFiDiamond } from "lifi/LiFiDiamond.sol";
import { DiamondCutFacet } from "lifi/Facets/DiamondCutFacet.sol";
import { DiamondLoupeFacet } from "lifi/Facets/DiamondLoupeFacet.sol";
import { OwnershipFacet } from "lifi/Facets/OwnershipFacet.sol";
import { IDiamondCut } from "lifi/Interfaces/IDiamondCut.sol";
import { DSTest } from "ds-test/test.sol";
import { Vm } from "forge-std/Vm.sol";

contract LiFiDiamondTest is DSTest {
Vm internal immutable vm = Vm(HEVM_ADDRESS);
LiFiDiamond public diamond;
DiamondCutFacet public diamondCutFacet;
OwnershipFacet public ownershipFacet;
address public diamondOwner;

event DiamondCut(
IDiamondCut.FacetCut[] _diamondCut,
address _init,
bytes _calldata
);

event OwnershipTransferred(
address indexed previousOwner,
address indexed newOwner
);

error FunctionDoesNotExist();

function setUp() public {
diamondOwner = address(123456);
diamondCutFacet = new DiamondCutFacet();
ownershipFacet = new OwnershipFacet();

// prepare function selector for diamondCut (OwnershipFacet)
bytes4[] memory functionSelectors = new bytes4[](1);
functionSelectors[0] = ownershipFacet.owner.selector;

// prepare parameters for diamondCut (OwnershipFacet)
IDiamondCut.FacetCut[] memory cut = new IDiamondCut.FacetCut[](1);
cut[0] = IDiamondCut.FacetCut({
facetAddress: address(ownershipFacet),
action: IDiamondCut.FacetCutAction.Add,
functionSelectors: functionSelectors
});

diamond = new LiFiDiamond(diamondOwner, address(diamondCutFacet));
}

function test_DeploysWithoutErrors() public {
diamond = new LiFiDiamond(diamondOwner, address(diamondCutFacet));
}

function test_ForwardsCallsViaDelegateCall() public {
// only one facet with one selector is registered (diamondCut)
vm.startPrank(diamondOwner);

DiamondLoupeFacet diamondLoupe = new DiamondLoupeFacet();

// make sure that this call fails (without ending the test)
bool failed = false;
try DiamondLoupeFacet(address(diamond)).facetAddresses() returns (
address[] memory
) {} catch {
failed = true;
}
if (!failed) revert("InvalidDiamondSetup");

// prepare function selectors
bytes4[] memory functionSelectors = new bytes4[](4);
functionSelectors[0] = diamondLoupe.facets.selector;
functionSelectors[1] = diamondLoupe.facetFunctionSelectors.selector;
functionSelectors[2] = diamondLoupe.facetAddresses.selector;
functionSelectors[3] = diamondLoupe.facetAddress.selector;

// prepare diamondCut
IDiamondCut.FacetCut[] memory cuts = new IDiamondCut.FacetCut[](1);
cuts[0] = IDiamondCut.FacetCut({
facetAddress: address(diamondLoupe),
action: IDiamondCut.FacetCutAction.Add,
functionSelectors: functionSelectors
});

DiamondCutFacet(address(diamond)).diamondCut(cuts, address(0), "");
}

function test_RevertsOnUnknownFunctionSelector() public {
// call random function selectors
bytes memory callData = hex"a516f0f3"; // getPeripheryContract(string)

vm.expectRevert(FunctionDoesNotExist.selector);
address(diamond).call(callData);
}

function test_CanReceiveETH() public {
(bool success, ) = address(diamond).call{ value: 1 ether }("");
if (!success) revert("ExternalCallFailed");

assertEq(address(diamond).balance, 1 ether);
}
}
132 changes: 132 additions & 0 deletions test/solidity/LiFiDiamondImmutable.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,132 @@
// SPDX-License-Identifier: Unlicensed
pragma solidity 0.8.17;

import { LiFiDiamondImmutable } from "lifi/LiFiDiamondImmutable.sol";
import { DiamondCutFacet } from "lifi/Facets/DiamondCutFacet.sol";
import { DiamondLoupeFacet } from "lifi/Facets/DiamondLoupeFacet.sol";
import { OwnershipFacet } from "lifi/Facets/OwnershipFacet.sol";
import { IDiamondCut } from "lifi/Interfaces/IDiamondCut.sol";
import { DSTest } from "ds-test/test.sol";
import { Vm } from "forge-std/Vm.sol";

contract LiFiDiamondImmutableTest is DSTest {
Vm internal immutable vm = Vm(HEVM_ADDRESS);
LiFiDiamondImmutable public diamond;
DiamondCutFacet public diamondCutFacet;
OwnershipFacet public ownershipFacet;
address public diamondOwner;

event DiamondCut(
IDiamondCut.FacetCut[] _diamondCut,
address _init,
bytes _calldata
);

event OwnershipTransferred(
address indexed previousOwner,
address indexed newOwner
);

error FunctionDoesNotExist();
error OnlyContractOwner();

function setUp() public {
diamondOwner = address(123456);
diamondCutFacet = new DiamondCutFacet();
ownershipFacet = new OwnershipFacet();

// prepare function selector for diamondCut (OwnershipFacet)
bytes4[] memory functionSelectors = new bytes4[](1);
functionSelectors[0] = ownershipFacet.owner.selector;

// prepare parameters for diamondCut (OwnershipFacet)
IDiamondCut.FacetCut[] memory cut = new IDiamondCut.FacetCut[](1);
cut[0] = IDiamondCut.FacetCut({
facetAddress: address(ownershipFacet),
action: IDiamondCut.FacetCutAction.Add,
functionSelectors: functionSelectors
});

diamond = new LiFiDiamondImmutable(
diamondOwner,
address(diamondCutFacet)
);
}

function test_DeploysWithoutErrors() public {
diamond = new LiFiDiamondImmutable(
diamondOwner,
address(diamondCutFacet)
);
}

function test_ForwardsCallsViaDelegateCall() public {
// only one facet with one selector is registered (diamondCut)
vm.startPrank(diamondOwner);

DiamondLoupeFacet diamondLoupe = new DiamondLoupeFacet();

// make sure that this call fails (without ending the test)
bool failed = false;
try DiamondLoupeFacet(address(diamond)).facetAddresses() returns (
address[] memory
) {} catch {
failed = true;
}
if (!failed) revert("InvalidDiamondSetup");

// prepare function selectors
bytes4[] memory functionSelectors = new bytes4[](4);
functionSelectors[0] = diamondLoupe.facets.selector;
functionSelectors[1] = diamondLoupe.facetFunctionSelectors.selector;
functionSelectors[2] = diamondLoupe.facetAddresses.selector;
functionSelectors[3] = diamondLoupe.facetAddress.selector;

// prepare diamondCut
IDiamondCut.FacetCut[] memory cuts = new IDiamondCut.FacetCut[](1);
cuts[0] = IDiamondCut.FacetCut({
facetAddress: address(diamondLoupe),
action: IDiamondCut.FacetCutAction.Add,
functionSelectors: functionSelectors
});

DiamondCutFacet(address(diamond)).diamondCut(cuts, address(0), "");
}

function test_NonOwnerCannotAddFacet() public {
DiamondLoupeFacet diamondLoupe = new DiamondLoupeFacet();

// prepare function selectors
bytes4[] memory functionSelectors = new bytes4[](4);
functionSelectors[0] = diamondLoupe.facets.selector;
functionSelectors[1] = diamondLoupe.facetFunctionSelectors.selector;
functionSelectors[2] = diamondLoupe.facetAddresses.selector;
functionSelectors[3] = diamondLoupe.facetAddress.selector;

// prepare diamondCut
IDiamondCut.FacetCut[] memory cuts = new IDiamondCut.FacetCut[](1);
cuts[0] = IDiamondCut.FacetCut({
facetAddress: address(diamondLoupe),
action: IDiamondCut.FacetCutAction.Add,
functionSelectors: functionSelectors
});

vm.expectRevert(OnlyContractOwner.selector);
DiamondCutFacet(address(diamond)).diamondCut(cuts, address(0), "");
}

function test_RevertsOnUnknownFunctionSelector() public {
// call random function selectors
bytes memory callData = hex"a516f0f3"; // getPeripheryContract(string)

vm.expectRevert(FunctionDoesNotExist.selector);
address(diamond).call(callData);
}

function test_CanReceiveETH() public {
(bool success, ) = address(diamond).call{ value: 1 ether }("");
if (!success) revert("ExternalCallFailed");

assertEq(address(diamond).balance, 1 ether);
}
}
41 changes: 41 additions & 0 deletions test/solidity/Periphery/ERC20Proxy.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
// SPDX-License-Identifier: Unlicensed
pragma solidity 0.8.17;

import { ERC20Proxy } from "lifi/Periphery/ERC20Proxy.sol";
import { DiamondCutFacet } from "lifi/Facets/DiamondCutFacet.sol";
import { DiamondLoupeFacet } from "lifi/Facets/DiamondLoupeFacet.sol";
import { OwnershipFacet } from "lifi/Facets/OwnershipFacet.sol";
import { IDiamondCut } from "lifi/Interfaces/IDiamondCut.sol";
import { DSTest } from "ds-test/test.sol";
import { Vm } from "forge-std/Vm.sol";

contract ERC20ProxyTest is DSTest {
Vm internal immutable vm = Vm(HEVM_ADDRESS);
ERC20Proxy public erc20Proxy;
DiamondCutFacet public diamondCutFacet;
OwnershipFacet public ownershipFacet;
address public proxyOwner;

error FunctionDoesNotExist();
error OnlyContractOwner();

function setUp() public {
proxyOwner = address(123456);
erc20Proxy = new ERC20Proxy(proxyOwner);
}

function test_DeploysWithoutErrors() public {
erc20Proxy = new ERC20Proxy(proxyOwner);

assertEq(erc20Proxy.owner(), proxyOwner);
}

function test_CannotReceiveETH() public {
(bool success, ) = address(erc20Proxy).call{ value: 1 ether }("");

assertTrue(
success == false,
"Contract can receive ETH but should not be able to"
);
}
}
Loading