Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable sushiswap cronos router #855

Merged
merged 1 commit into from
Nov 14, 2024
Merged

feat: enable sushiswap cronos router #855

merged 1 commit into from
Nov 14, 2024

Conversation

myz1237
Copy link
Contributor

@myz1237 myz1237 commented Nov 11, 2024

Which Jira task belongs to this PR?

https://lifi.atlassian.net/browse/LF-10525

Why did I implement it this way?

Checklist before requesting a review

  • I have performed a self-review of my code
  • This pull request is as small as possible and only tackles one problem
  • I have added tests that cover the functionality / test the bug
  • I have updated any required documentation

Checklist for reviewer (DO NOT DEPLOY and contracts BEFORE CHECKING THIS!!!)

  • I have checked that any arbitrary calls to external contracts are validated and or restricted
  • I have checked that any privileged calls (i.e. storage modifications) are validated and or restricted
  • I have ensured that any new contracts have had AT A MINIMUM 1 preliminary audit conducted on by <company/auditor>

Copy link
Contributor

coderabbitai bot commented Nov 11, 2024

Walkthrough

This pull request introduces modifications to the config/dexs.json file, primarily expanding the lists of blockchain addresses for various networks. New addresses have been added across several sections, including cronos, optimism, polygon, polygonzkevm, rootstock, sei, scroll, taiko, and velas. Additionally, the commit reference for the lib/openzeppelin-contracts directory has been updated without any changes to functionality or logic.

Changes

File Change Summary
config/dexs.json - Added multiple new addresses across sections: cronos, optimism, polygon, polygonzkevm, rootstock, sei, scroll, taiko, and velas.
lib/openzeppelin-contracts - Updated subproject commit reference from 54b3f14346da01ba0d159114b399197fea8b7cda to e50c24f5839db17f46991478384bfda14acfb830.

Possibly related PRs

Suggested labels

AuditNotRequired

Suggested reviewers

  • 0xDEnYO

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Outside diff range and nitpick comments (1)
config/dexs.json (1)

Line range hint 1-1006: Consider improving the file organization.

The file has a good structure with networks in alphabetical order and a clear separation between mainnet and testnet networks. However, consider:

  1. Using a cleaner separator between active and old networks instead of multiple dashes
  2. Adding comments to document the purpose of each network section or any special considerations

Consider replacing the separator line with:

-  "---------------FROM HERE ON JUST OLD NETWORKS - PLEASE ADD NEW NETWORKS ABOVE IN ALPHABETICAL ORDER ^^^^ ----------": [],
+  "// ===== DEPRECATED NETWORKS (Add new networks above this line in alphabetical order) ===== //": [],
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 8eb3773 and c56883e.

📒 Files selected for processing (2)
  • config/dexs.json (1 hunks)
  • lib/openzeppelin-contracts (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • lib/openzeppelin-contracts

config/dexs.json Show resolved Hide resolved
@lifi-action-bot
Copy link
Collaborator

Test Coverage Report

Line Coverage: 76.20% (1685 / 2211 lines)
Function Coverage: 82.94% ( 355 / 428 functions)
Branch Coverage: 35.67% ( 193 / 541 branches)
Test coverage (76.20%) is above min threshold (74%). Check passed.

@ezynda3 ezynda3 marked this pull request as ready for review November 14, 2024 07:55
@ezynda3 ezynda3 enabled auto-merge (squash) November 14, 2024 07:55
@ezynda3 ezynda3 merged commit e4fff16 into main Nov 14, 2024
28 checks passed
@ezynda3 ezynda3 deleted the add-openocean-cronos branch November 14, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants