-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable sushiswap cronos router #855
Conversation
WalkthroughThis pull request introduces modifications to the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (1)
config/dexs.json (1)
Line range hint
1-1006
: Consider improving the file organization.The file has a good structure with networks in alphabetical order and a clear separation between mainnet and testnet networks. However, consider:
- Using a cleaner separator between active and old networks instead of multiple dashes
- Adding comments to document the purpose of each network section or any special considerations
Consider replacing the separator line with:
- "---------------FROM HERE ON JUST OLD NETWORKS - PLEASE ADD NEW NETWORKS ABOVE IN ALPHABETICAL ORDER ^^^^ ----------": [], + "// ===== DEPRECATED NETWORKS (Add new networks above this line in alphabetical order) ===== //": [],
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (2)
config/dexs.json
(1 hunks)lib/openzeppelin-contracts
(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- lib/openzeppelin-contracts
Test Coverage ReportLine Coverage: 76.20% (1685 / 2211 lines) |
Which Jira task belongs to this PR?
https://lifi.atlassian.net/browse/LF-10525
Why did I implement it this way?
Checklist before requesting a review
Checklist for reviewer (DO NOT DEPLOY and contracts BEFORE CHECKING THIS!!!)