bugfix in git action, adds missing closing statement for if clause #877
Conversation
WalkthroughThe changes in this pull request enhance a GitHub Actions workflow file by refining the logic for protecting audit labels. Adjustments include correcting the indentation of the event types for the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
.github/workflows/protectAuditLabels.yml (2)
Line range hint
25-35: LGTM: Well-structured event type checkingThe implementation effectively filters relevant events and provides clear feedback. Good use of environment variables for flow control.
Consider adding the actual event type to the skip message for better debugging:
- echo -e "\033[32mAction was triggered by a non-label event, thus skipping checks (not required).\033[0m" + echo -e "\033[32mAction was triggered by '$EVENT_ACTION', thus skipping checks (not required).\033[0m"
Line range hint
48-94: Add error handling for GitHub CLI commandsWhile the implementation is solid, consider adding error handling for the GitHub CLI commands to ensure robustness:
##### Revert to the previous state of labels if [[ "$EVENT_ACTION" == "unlabeled" ]]; then - gh pr edit $PR_NUMBER --add-label "$TARGET_LABEL" + if ! gh pr edit $PR_NUMBER --add-label "$TARGET_LABEL"; then + echo -e "\033[31mFailed to add label '$TARGET_LABEL'\033[0m" + exit 1 + fi elif [[ "$EVENT_ACTION" == "labeled" ]]; then - gh pr edit $PR_NUMBER --remove-label "$TARGET_LABEL" + if ! gh pr edit $PR_NUMBER --remove-label "$TARGET_LABEL"; then + echo -e "\033[31mFailed to remove label '$TARGET_LABEL'\033[0m" + exit 1 + fi fi
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
.github/workflows/protectAuditLabels.yml(2 hunks)
🧰 Additional context used
📓 Learnings (1)
.github/workflows/protectAuditLabels.yml (1)
Learnt from: 0xDEnYO
PR: lifinance/contracts#782
File: .github/workflows/protectAuditLabels.yml:95-95
Timestamp: 2024-11-26T01:46:18.625Z
Learning: When reviewing shell scripts in `.github/workflows/protectAuditLabels.yml`, ensure that added `fi` statements properly close existing `if` blocks, recognizing that such additions in the diff may be fixing previous syntax errors rather than introducing new ones.
🔇 Additional comments (3)
.github/workflows/protectAuditLabels.yml (3)
14-14: LGTM: Correct YAML indentation
The indentation fix for the types array properly aligns with YAML syntax requirements.
Line range hint 36-47: LGTM: Proper authorization check
The implementation correctly handles bot authorization with appropriate early exit pattern.
95-95: LGTM: Added missing fi statement
The addition of the missing fi statement properly closes the if block, fixing the syntax error.
Test Coverage ReportLine Coverage: 76.10% (1675 / 2201 lines) |
Which Jira task belongs to this PR?
Why did I implement it this way?
Checklist before requesting a review
Checklist for reviewer (DO NOT DEPLOY and contracts BEFORE CHECKING THIS!!!)