-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add missed signature for OKX #881
Conversation
WalkthroughThe pull request modifies the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🔇 Additional comments (2)config/sigs.json (2)
The new signature follows the established format and is properly placed in the JSON array.
Let's verify that the new signature is unique and corresponds to the correct function. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Test Coverage ReportLine Coverage: 76.10% (1675 / 2201 lines) |
Which Jira task belongs to this PR?
https://lifi.atlassian.net/browse/LF-10597
Why did I implement it this way?
I got an error from our BE when testing okx dex:
Signature Allowlist] Unknown signature: 0x0d5f0e3b, chain: 1, contract: 0x7D0CcAa3Fac1e5A943c5168b6CEd828691b46B36
0x0d5f0e3b is uniswapV3SwapTo, another function to do swapChecklist before requesting a review
Checklist for reviewer (DO NOT DEPLOY and contracts BEFORE CHECKING THIS!!!)