feat: add lda on wld chain

[myz1237]

Which Jira task belongs to this PR?

https://lifi.atlassian.net/browse/LF-10920

Why did I implement it this way?

Checklist before requesting a review

• I have performed a self-review of my code
• This pull request is as small as possible and only tackles one problem
• I have added tests that cover the functionality / test the bug
• I have updated any required documentation

Checklist for reviewer (DO NOT DEPLOY and contracts BEFORE CHECKING THIS!!!)

• I have checked that any arbitrary calls to external contracts are validated and or restricted
• I have checked that any privileged calls (i.e. storage modifications) are validated and or restricted
• I have ensured that any new contracts have had AT A MINIMUM 1 preliminary audit conducted on by <company/auditor>

[coderabbitai]

Walkthrough

The changes in this pull request involve updates to the config/dexs.json file, specifically adding new blockchain addresses and correcting existing entries. The "worldchain" section has been modified to include a new address and correct the formatting of an existing address. Additionally, new addresses have been added to various other blockchain sections, including "optimism," "polygon," and "polygonzkevm," while maintaining the overall structure of the JSON file.

Changes

File	Change Summary
config/dexs.json	- Added new address "0x2321F1a63A683a1F3634Dbe1CbA0d657D5F56d54" in "worldchain" section.
	- Updated existing address "0x603a538477d44064eA5A5d8C345b4Ff6fca1142a" in "worldchain" (now includes a trailing comma).
	- Added new addresses in sections: "optimism", "polygon", and "polygonzkevm" among others.

Possibly related PRs

• config: addresses and signatures for sushiswap dex agg #818: This PR also modifies the config/dexs.json file by adding new addresses across various blockchain networks.
• config: add addresses and signatures for bebop #844: This PR updates the config/dexs.json file by adding a new address and modifying existing entries.
• feat: add cronos lifidex aggregator address #862: This PR adds new addresses in the config/dexs.json file, including updates to the "optimism" and "polygon" sections.
• fix: remove trailing comma and bad dex contract for bebop dex #880: This PR includes updates to the config/dexs.json file with new addresses and formatting corrections.
• config: add new dodo contracts #882: This PR adds new addresses in the config/dexs.json file, including updates to the "opbnb" section.

Suggested labels

AuditNotRequired

Suggested reviewers

• 0xDEnYO

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

config/dexs.json (1)

Line range hint 1-1000: Fix JSON syntax errors: Missing commas after array closings

There are missing commas after the closing brackets in several sections:

• "base" section: Missing comma after "0x57df6092665eb6058DE53939612413ff4B09114E"
• "fantom" section: Missing comma after "0x70cBb871E8f30Fc8Ce23609E9E0Ea87B6b222F58"
• "mode" section: Missing comma after "0x78bF01555bCF05e6B1d4dad017dBD0A105652DC9"
• "opbnb" section: Missing comma after "0x077A38b812e57E2e76849954c880E1a2f5e0A68d"
• "zksync" section: Missing comma after "0xc67879F4065d3B9fe1C09EE990B891Aa8E3a4c2f"

These syntax errors will cause JSON parsing failures. Please add the missing commas.

  "base": [
    ...
    "0x6b2c0c7be2048daa9b5527982c29f48062b34d58",
-   "0x57df6092665eb6058DE53939612413ff4B09114E"
+   "0x57df6092665eb6058DE53939612413ff4B09114E",
  ],

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 88172ce and 5ac9935.

📒 Files selected for processing (1)

• config/dexs.json (1 hunks)

🧰 Additional context used

📓 Learnings (1)

config/dexs.json (1)

Learnt from: ezynda3
PR: lifinance/contracts#861
File: config/dexs.json:748-752
Timestamp: 2024-11-21T08:39:29.530Z
Learning: In the 'worldchain' network, the addresses `0x50D5a8aCFAe13Dceb217E9a071F6c6Bd5bDB4155`, `0x8f023b4193a6b18C227B4a755f8e28B3D30Ef9a1`, and `0x603a538477d44064eA5A5d8C345b4Ff6fca1142a` are used as DEXs and should be included in `config/dexs.json`.

🔇 Additional comments (1)

config/dexs.json (1)

817-818: Verify the new address and ensure all required addresses are included

The worldchain section is missing two addresses that were previously validated:

• 0x50D5a8aCFAe13Dceb217E9a071F6c6Bd5bDB4155
• 0x8f023b4193a6b18C227B4a755f8e28B3D30Ef9a1

[lifi-action-bot]

Test Coverage Report

Line Coverage: 77.92% (2139 / 2745 lines)
Function Coverage: 84.00% ( 373 / 444 functions)
Branch Coverage: 37.47% ( 208 / 555 branches)
Test coverage (77.92%) is above min threshold (76%). Check passed.

[ezynda3]

Closed and added to new PR with formatting fixes