Permit 2 trusted forwarder lf 11862

[0xDEnYO]

Which Jira task belongs to this PR?

[{LF-11862}]

Why did I implement it this way?

Currently our EIP2612 implementation does not allow for relayers to execute the transaction, only for the token owner themselves. This PR adds a functionality to allow a whitelisted, trusted forwarder (e.g. Gelato) who implements ERC2771 to call our Permit2Proxy and execute gasless transactions.

Checklist before requesting a review

• I have performed a self-review of my code
• This pull request is as small as possible and only tackles one problem
• I have added tests that cover the functionality / test the bug
• For new facets: I have checked all points from this list: https://www.notion.so/lifi/New-Facet-Contract-Checklist-157f0ff14ac78095a2b8f999d655622e
• I have updated any required documentation

Checklist for reviewer (DO NOT DEPLOY and contracts BEFORE CHECKING THIS!!!)

• I have checked that any arbitrary calls to external contracts are validated and or restricted
• I have checked that any privileged calls (i.e. storage modifications) are validated and or restricted
• I have ensured that any new contracts have had AT A MINIMUM 1 preliminary audit conducted on by <company/auditor>

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request introduces significant changes to the LiFi contract ecosystem, focusing on enhancing the Permit2Proxy contract and its configuration. The modifications include restructuring the network configuration in permit2Proxy.json, updating deployment logs, and implementing trusted forwarder support in the Permit2Proxy contract. The changes aim to improve the flexibility and functionality of the contract, particularly in handling gasless transactions across multiple blockchain networks.

Changes

File	Change Summary
config/permit2Proxy.json	Restructured network configuration with nested Permit2 and TrustedForwarders fields for multiple blockchain networks
deployments/_deployments_log_file.json	Added new entries for version "1.1.0" in production and staging environments
deployments/arbitrum.*	Updated Permit2Proxy address and removed MayanFacet
deployments/optimism.*	Added Permit2Proxy address with new configuration
src/Periphery/Permit2Proxy.sol	Updated to version 1.1.0, added support for trusted forwarders, new constructor, and new transaction method
src/Security/ERC2771ContextCustom.sol	New contract for managing trusted forwarders and ERC-2771 context
test/solidity/Periphery/Permit2Proxy.t.sol	Added comprehensive tests for trusted forwarder functionality

Possibly related PRs

• Audit fixes [GasZipFacet v2.0.2] #910: Changes in Permit2Proxy contract handling of trusted forwarders
• Integrate WithdrawablePeriphery [ERC20Proxy v1.1.0,Executor v2.1.0,LiFiDEXAggregator v1.6.0,Receiver v2.1.0,ReceiverAcrossV3 v1.1.0,ReceiverStargateV2 v1.1.0,RelayerCelerIM v2.1.1,TokenWrapper v1.1.0] #909: Integration of WithdrawablePeriphery
• Use SafeTransferLib for ETH transfers [GasZipFacet v2.0.1,LibAsset v1.0.2,FeeCollector v1.0.1,GasZipPeriphery v1.0.1,LiFiDEXAggregator v1.5.1,LiFuelFeeCollector v1.0.2,Permit2Proxy v1.0.2,Receiver v2.0.3,ReceiverAcrossV3 v1.0.3,ReceiverStargateV2 v1.0.1,RelayerCelerIM v2.0.1,TokenWrapper v1.0.1] #912: Improvements in ETH transfer handling

Suggested labels

AuditCompleted

Suggested reviewers

• ezynda3

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0c49bae and f41cf66.

📒 Files selected for processing (12)

• config/permit2Proxy.json (1 hunks)
• deployments/_deployments_log_file.json (2 hunks)
• deployments/arbitrum.diamond.staging.json (1 hunks)
• deployments/arbitrum.staging.json (1 hunks)
• deployments/optimism.diamond.staging.json (1 hunks)
• deployments/optimism.staging.json (1 hunks)
• package.json (2 hunks)
• script/deploy/_targetState.json (2 hunks)
• script/deploy/facets/DeployPermit2Proxy.s.sol (2 hunks)
• src/Periphery/Permit2Proxy.sol (3 hunks)
• src/Security/ERC2771ContextCustom.sol (1 hunks)
• test/solidity/Periphery/Permit2Proxy.t.sol (4 hunks)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[lifi-action-bot]

Test Coverage Report

Line Coverage: 78.48% (2266 / 2887 lines)
Function Coverage: 84.73% ( 394 / 465 functions)
Branch Coverage: 39.64% ( 224 / 565 branches)
Test coverage (78.48%) is above min threshold (76%). Check passed.