chore: add coderabbit changes

liftedinit · Jan 14, 2025 · 7b1a642 · 7b1a642
1 parent 09bf705
commit 7b1a642
Show file tree

Hide file tree

Showing 3 changed files with 52 additions and 24 deletions.
diff --git a/components/bank/components/historyBox.tsx b/components/bank/components/historyBox.tsx
@@ -221,20 +221,34 @@ export function HistoryBox({
                       let metadata = metadatas?.metadatas.find(m => m.base === amt.denom);
 
                       if (amt.denom.startsWith('ibc/')) {
-                        metadata = {
-                          description: assetInfo?.description ?? '',
-                          denom_units:
-                            assetInfo?.denom_units?.map(unit => ({
-                              ...unit,
-                              aliases: unit.aliases || [],
-                            })) ?? [],
-                          base: assetInfo?.base ?? '',
-                          display: assetInfo?.display ?? '',
-                          name: assetInfo?.name ?? '',
-                          symbol: assetInfo?.symbol ?? '',
-                          uri: assetInfo?.logo_URIs?.svg ?? assetInfo?.logo_URIs?.png ?? '',
-                          uri_hash: assetInfo?.logo_URIs?.svg ?? assetInfo?.logo_URIs?.png ?? '',
-                        };
+                        if (assetInfo) {
+                          metadata = {
+                            description: assetInfo?.description ?? '',
+                            denom_units:
+                              assetInfo?.denom_units?.map(unit => ({
+                                ...unit,
+                                aliases: unit.aliases || [],
+                              })) ?? [],
+                            base: assetInfo?.base ?? '',
+                            display: assetInfo?.display ?? '',
+                            name: assetInfo?.name ?? '',
+                            symbol: assetInfo?.symbol ?? '',
+                            uri: assetInfo?.logo_URIs?.svg ?? assetInfo?.logo_URIs?.png ?? '',
+                            uri_hash: assetInfo?.logo_URIs?.svg ?? assetInfo?.logo_URIs?.png ?? '',
+                          };
+                        } else {
+                          //  assetInfo is undefined
+                          metadata = {
+                            description: '',
+                            denom_units: [],
+                            base: '',
+                            display: '',
+                            name: '',
+                            symbol: '',
+                            uri: '',
+                            uri_hash: '',
+                          };
+                        }
                       }
 
                       return <DenomImage key={index} denom={metadata} />;
@@ -252,8 +266,10 @@ export function HistoryBox({
 
                             if (amt.denom.startsWith('ibc/')) {
                               const assetInfo = denomToAsset(env.chain, amt.denom);
-                              if (assetInfo?.traces?.[0]?.counterparty?.base_denom) {
-                                display = assetInfo.traces[0].counterparty.base_denom.slice(1);
+                              if (assetInfo?.traces && assetInfo.traces.length > 0) {
+                                if (assetInfo.traces[0].counterparty?.base_denom) {
+                                  display = assetInfo.traces[0].counterparty.base_denom.slice(1);
+                                }
                               }
                             }
 
@@ -301,8 +317,10 @@ export function HistoryBox({
 
                           if (amt.denom.startsWith('ibc/')) {
                             const assetInfo = denomToAsset(env.chain, amt.denom);
-                            if (assetInfo?.traces?.[0]?.counterparty?.base_denom) {
-                              baseDenom = assetInfo.traces[0].counterparty.base_denom.slice(1);
+                            if (assetInfo?.traces && assetInfo.traces.length > 0) {
+                              if (assetInfo.traces[0].counterparty?.base_denom) {
+                                baseDenom = assetInfo.traces[0].counterparty.base_denom.slice(1);
+                              }
                             }
                           }
 

diff --git a/components/bank/forms/ibcSendForm.tsx b/components/bank/forms/ibcSendForm.tsx
@@ -81,6 +81,17 @@ export default function IbcSendForm({
   availableToChains: IbcChain[];
 }>) {
   const { address: osmosisAddress } = useChain(env.osmosisTestnetChain);
+
+  const formatTokenDisplayName = (displayName: string) => {
+    if (displayName.startsWith('factory')) {
+      return displayName.split('/').pop()?.toUpperCase();
+    }
+    if (displayName.startsWith('u')) {
+      return displayName.slice(1).toUpperCase();
+    }
+    return truncateString(displayName, 10).toUpperCase();
+  };
+
   const [isSending, setIsSending] = useState(false);
   const [searchTerm, setSearchTerm] = useState('');
   const [feeWarning, setFeeWarning] = useState('');
@@ -571,11 +582,7 @@ export default function IbcSendForm({
                             values.selectedToken?.denom ??
                             'Select';
 
-                          return tokenDisplayName.startsWith('factory')
-                            ? tokenDisplayName.split('/').pop()?.toUpperCase()
-                            : tokenDisplayName.startsWith('u')
-                              ? tokenDisplayName.slice(1).toUpperCase()
-                              : truncateString(tokenDisplayName, 10).toUpperCase();
+                          return formatTokenDisplayName(tokenDisplayName);
                         })()}
                         <PiCaretDownBold className="ml-1" />
                       </label>

diff --git a/components/groups/components/myGroups.tsx b/components/groups/components/myGroups.tsx
@@ -264,7 +264,10 @@ export function YourGroups({
         if (coreBalance.denom.startsWith('ibc/')) {
           const assetInfo = denomToAsset(env.chain, coreBalance.denom);
 
-          const baseDenom = assetInfo?.traces?.[1]?.counterparty?.base_denom;
+          let baseDenom = '';
+          if (assetInfo?.traces && assetInfo.traces.length > 1) {
+            baseDenom = assetInfo.traces[1]?.counterparty?.base_denom ?? '';
+          }
 
           return {
             denom: baseDenom ?? '', // normalized denom (e.g., 'umfx')