Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add memo field to tx detail #145

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Conversation

fmorency
Copy link
Contributor

@fmorency fmorency commented Dec 9, 2024

Fixes #140

2024-12-09_16-31

Summary by CodeRabbit

  • New Features

    • Added an optional "MEMO" field to transaction details, enhancing the information displayed in transaction history.
    • Introduced a new section in the transaction info modal to show the "MEMO" associated with transactions.
    • Launched new hooks for improved data fetching and handling of multiple proposal tally counts.
  • Bug Fixes

    • Improved error handling during transaction data fetching, ensuring better logging and response to issues.

@fmorency fmorency added the enhancement New feature or request label Dec 9, 2024
@fmorency fmorency requested a review from chalabi2 December 9, 2024 21:31
@fmorency fmorency self-assigned this Dec 9, 2024
Copy link
Contributor

coderabbitai bot commented Dec 9, 2024

Walkthrough

The changes in this pull request introduce enhancements to the transaction handling in the application. Specifically, an optional memo property has been added to the TransactionGroup interface, allowing for additional transaction details. The TxInfoModal component has been updated to display this memo information. Furthermore, the data fetching and transformation logic in hooks/useQueries.ts has been improved to include the memo in transaction messages and to enhance error handling during data fetching.

Changes

File Path Change Summary
components/bank/components/historyBox.tsx Updated TransactionGroup interface to include optional memo property.
components/bank/modals/txInfo.tsx Added "MEMO" field in TxInfoModal to display transaction memo, defaulting to 'N/A' if absent.
hooks/useQueries.ts Enhanced transaction transformation to include memo; improved error handling; introduced new hooks.

Assessment against linked issues

Objective Addressed Explanation
Add memo to Tx detail modal (#140)

Possibly related PRs

Suggested reviewers

  • chalabi2

🐰 In the meadow, transactions flow,
With memos added, watch them glow!
In modals bright, details unfold,
A tale of finance, now retold.
Hooray for changes, let’s all cheer,
For clearer insights, we hold dear! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 57.04%. Comparing base (5d12e77) to head (8f5c942).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
hooks/useQueries.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #145      +/-   ##
==========================================
+ Coverage   56.38%   57.04%   +0.66%     
==========================================
  Files         152      145       -7     
  Lines       16213    14426    -1787     
==========================================
- Hits         9141     8230     -911     
+ Misses       7072     6196     -876     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)
hooks/useQueries.ts (1)

959-959: Add test coverage for memo transformation.

The memo transformation logic lacks test coverage. Please add tests to verify:

  • Memo extraction from transaction body
  • Memo inclusion in transformed transactions
  • Handling of transactions without memos

Would you like me to help generate test cases for the memo transformation logic?

Also applies to: 972-972

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 215915e and 8f5c942.

📒 Files selected for processing (3)
  • components/bank/components/historyBox.tsx (1 hunks)
  • components/bank/modals/txInfo.tsx (1 hunks)
  • hooks/useQueries.ts (3 hunks)
🧰 Additional context used
🪛 GitHub Check: codecov/patch
hooks/useQueries.ts

[warning] 942-943: hooks/useQueries.ts#L942-L943
Added lines #L942 - L943 were not covered by tests

🔇 Additional comments (3)
components/bank/modals/txInfo.tsx (1)

93-95: LGTM! Memo field implementation looks good.

The implementation follows the existing pattern and properly handles cases where memo is undefined.

components/bank/components/historyBox.tsx (1)

22-22: LGTM! TransactionGroup interface updated correctly.

The optional memo field is properly typed and aligns with the PR objectives.

hooks/useQueries.ts (1)

942-943: LGTM! Clean memo extraction implementation.

The memo extraction is implemented correctly using optional chaining and object spread syntax.

🧰 Tools
🪛 GitHub Check: codecov/patch

[warning] 942-943: hooks/useQueries.ts#L942-L943
Added lines #L942 - L943 were not covered by tests

Copy link
Collaborator

@chalabi2 chalabi2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We did it the same way I believe Lgtm!

@fmorency fmorency merged commit 88e8e7b into liftedinit:main Dec 10, 2024
4 checks passed
@fmorency fmorency deleted the tx-info-memo branch December 10, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add memo to Tx detail modal
2 participants