fix: send form icons #177
fix: send form icons #177
Conversation
|
Warning Rate limit exceeded@fmorency has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 15 minutes and 39 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
WalkthroughThe pull request introduces a new optional Changes
Suggested labels
Suggested reviewers
Possibly related PRs
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
components/factory/components/DenomImage.tsx (1)
67-73: Maintain consistent hex color casing.The background color hex values have inconsistent casing:
- Line 104:
dark:bg-[#ffffff0f]andbg-[#0000000a]- Line 125:
dark:bg-[#FFFFFF0F]andbg-[#0000000A]While this works functionally, it's better to maintain consistency.
Apply this diff to standardize the casing:
- className={`w-11 h-11 p-2 rounded-md ${withBackground ? 'dark:bg-[#ffffff0f] bg-[#0000000a]' : ''}`} + className={`w-11 h-11 p-2 rounded-md ${withBackground ? 'dark:bg-[#FFFFFF0F] bg-[#0000000A]' : ''}`}Also applies to: 103-105, 124-126
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
components/bank/forms/ibcSendForm.tsx(3 hunks)components/bank/forms/sendForm.tsx(2 hunks)components/factory/components/DenomImage.tsx(3 hunks)utils/identicon.tsx(2 hunks)
🔇 Additional comments (3)
utils/identicon.tsx (1)
6-14: LGTM! Clean implementation of the background toggle.The changes introduce a well-typed optional
withBackgroundprop with sensible defaults and proper conditional styling implementation.Also applies to: 49-49
components/bank/forms/sendForm.tsx (1)
214-217: LGTM! Improved token selection UX.The changes address two key improvements:
- Consistent styling by setting
withBackground={false}for all token images.- Fixed dropdown collapse issue by properly handling focus after token selection.
Also applies to: 258-263, 268-268
components/bank/forms/ibcSendForm.tsx (1)
4-4: LGTM! Clean up and UX improvements.The changes include:
- Removed unused import.
- Fixed dropdown collapse issue by properly handling focus after token selection.
- Consistent styling by setting
withBackground={false}for all token images.Also applies to: 288-291, 330-335, 340-342
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #177 +/- ##
==========================================
- Coverage 55.07% 55.04% -0.03%
==========================================
Files 153 153
Lines 15485 15515 +30
==========================================
+ Hits 8528 8540 +12
- Misses 6957 6975 +18 ☔ View full report in Codecov by Sentry. |
This PR fixes the icon layout in the Send forms. This PR also fixes the token dropdown collapse on user selection.
= Before
= After
Summary by CodeRabbit
Release Notes
New Features
withBackgroundprop toDenomImageandProfileAvatarcomponents, allowing customizable image background renderingImprovements
Code Optimization