Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add denom prefix #182

Merged
merged 9 commits into from
Jan 8, 2025
Merged

Add denom prefix #182

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
4fe335f
chore: add 'u' to subdenom programatically
chalabi2 Jan 7, 2025
84e4cf1
fix: fix factory creation metadata issue
chalabi2 Jan 8, 2025
944b872
fix: revert metadata issues
chalabi2 Jan 8, 2025
202818f
fix: metadata & alias issues
chalabi2 Jan 8, 2025
f346182
fix: make denom creation simulation smoother
chalabi2 Jan 8, 2025
ec5c6d3
fix: remove slice on factory prefix
chalabi2 Jan 8, 2025
5608a08
chore: add code rabbit suggestions
chalabi2 Jan 8, 2025
cf58d6c
fix: alias
fmorency Jan 8, 2025
2d5e171
fix: tests
fmorency Jan 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions components/factory/forms/ConfirmationForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ export default function ConfirmationForm({
value: MsgCreateDenom.encode(
createDenom({
sender: formData.groupPolicyAddress || '',
subdenom: formData.subdenom,
subdenom: 'u' + formData.subdenom,
chalabi2 marked this conversation as resolved.
Show resolved Hide resolved
}).value
).finish(),
}),
Expand Down Expand Up @@ -99,7 +99,7 @@ export default function ConfirmationForm({
// First, create the denom
const createDenomMsg = createDenom({
sender: address,
subdenom: formData.subdenom,
subdenom: 'u' + formData.subdenom,
chalabi2 marked this conversation as resolved.
Show resolved Hide resolved
});

const createDenomFee = await estimateFee(address, [createDenomMsg]);
Expand Down
5 changes: 2 additions & 3 deletions components/factory/forms/CreateDenom.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ export default function CreateDenom({
const DenomSchema = Yup.object().shape({
subdenom: Yup.string()
.required('Subdenom is required')
.matches(/^[u][a-zA-Z0-9]+$/, 'Subdenom must start with the letter u')
.min(4, 'Subdenom must be at least 4 characters')
.max(44, 'Subdenom must not exceed 44 characters')
.noProfanity('Profanity is not allowed')
Expand Down Expand Up @@ -57,8 +56,7 @@ export default function CreateDenom({
<TextInput
label="Token Sub Denom"
name="subdenom"
placeholder="utoken"
helperText="Use a subdenom starting with a prefix (e.g., 'utoken')"
placeholder="token"
value={formData.subdenom}
onChange={(e: React.ChangeEvent<HTMLInputElement>) => {
dispatch({
Expand Down Expand Up @@ -126,6 +124,7 @@ export default function CreateDenom({
<button
className="w-[calc(50%-12px)] btn px-5 py-2.5 sm:py-3.5 btn-gradient text-white disabled:text-black"
onClick={() => handleSubmit()}
type="submit"
disabled={!isValid || isSubmitting || isValidating}
>
Next: Token Metadata
Expand Down
Loading