fix: only show successful tx in history

[fmorency]

Fixes #188

Summary by CodeRabbit

• Refactor
  • Removed unused imports in the HistoryBox component
  • Updated transaction processing logic to skip failed transactions
  • Modified transaction sorting to order by timestamp instead of block height

[coderabbitai]

Warning

Rate limit exceeded

@fmorency has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 23 minutes and 46 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 25d1d60 and ce887ea.

📒 Files selected for processing (1)

• pages/bank.tsx (1 hunks)

Walkthrough

The pull request focuses on refining transaction history handling by filtering out failed transactions and updating transaction sorting. In the historyBox.tsx component, unused imports have been removed, simplifying the code structure. In the useQueries.ts hook, a new conditional check was added to skip processing transactions with non-zero response codes, ensuring only successful transactions are processed. The transaction sorting mechanism was also updated to order transactions by timestamp instead of block height.

Changes

File	Change Summary
components/bank/components/historyBox.tsx	Removed unused imports: useMemo, useEffect, truncateString, and useIsMobile
hooks/useQueries.ts	Added conditional check to filter out failed transactions and updated sorting to use timestamp

Assessment against linked issues

Objective	Addressed	Explanation
Filter failed send tx from history [#188]	✅

Possibly related PRs

• feat: better history #98: Refactoring of transaction handling in the HistoryBox component
• test: improve history box #107: Enhancements to the test suite for the HistoryBox component
• fix: payout tx history #166: Modifications to message formatting logic in hooks/useQueries.ts

Suggested reviewers

• chalabi2

Poem

🐰 Transactions dance, now clean and bright,
Failed messages fade from coding's sight,
Imports pruned with a rabbit's care,
History flows with a timestamp's flair,
Code simplified, no clutter in view! 🚀

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[fmorency]

Superseded by liftedinit/yaci#35