Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: backdrop issues for proposal message modal #213

Merged
merged 1 commit into from
Jan 15, 2025
Merged

fix: backdrop issues for proposal message modal #213

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 10 additions & 14 deletions components/groups/modals/voteDetailsModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -752,7 +752,7 @@
)}
</div>
<dialog id="messages_modal" className="modal">
<div className="modal-box max-w-4xl ml-20 bg-secondary">
<div className="modal-box max-w-4xl ml-20 bg-secondary z-[1003]">

Check warning on line 755 in components/groups/modals/voteDetailsModal.tsx

View check run for this annotation

Codecov / codecov/patch

components/groups/modals/voteDetailsModal.tsx#L755 

Added line #L755 was not covered by tests
<form method="dialog">
<button className="btn btn-sm btn-circle btn-ghost absolute right-2 top-2">
✕
Expand Down Expand Up @@ -794,24 +794,20 @@
left: 0,
right: 0,
bottom: 0,
zIndex: 1001,
zIndex: 1002,

Check warning on line 797 in components/groups/modals/voteDetailsModal.tsx

View check run for this annotation

Codecov / codecov/patch

components/groups/modals/voteDetailsModal.tsx#L797 

Added line #L797 was not covered by tests
backgroundColor: 'rgba(0, 0, 0, 0.3)',
}}
onClick={e => {
e.preventDefault();
setShowVoteModal(false);
onClose();
e.stopPropagation();
const messagesModal = document.getElementById(
'messages_modal'
) as HTMLDialogElement;
if (messagesModal) {
messagesModal.close();
}

Check warning on line 807 in components/groups/modals/voteDetailsModal.tsx

View check run for this annotation

Codecov / codecov/patch

components/groups/modals/voteDetailsModal.tsx#L801-L807 

Added lines #L801 - L807 were not covered by tests
}}
>
<button
onClick={e => {
e.preventDefault();
setShowVoteModal(false);
onClose();
}}
>
close
</button>
<button>close</button>

Check warning on line 810 in components/groups/modals/voteDetailsModal.tsx

View check run for this annotation

Codecov / codecov/patch

components/groups/modals/voteDetailsModal.tsx#L810 

Added line #L810 was not covered by tests
</form>
</dialog>
<VotingPopup
Expand Down
Loading