-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add version display #73
Conversation
WalkthroughThe changes in this pull request involve modifications to the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #73 +/- ##
=======================================
Coverage 59.00% 59.00%
=======================================
Files 145 145
Lines 14060 14060
=======================================
Hits 8296 8296
Misses 5764 5764 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
components/react/sideNav.tsx (2)
9-9
: Consider security implications of package.json importWhile importing package.json for version display is supported in Next.js, be cautious about importing the entire package.json as it might contain sensitive information. Consider creating a dedicated version export file or using environment variables for version information.
Alternative approach:
// Create a new file: src/version.ts export const VERSION = process.env.NEXT_PUBLIC_VERSION || process.env.npm_package_version || '0.0.0';This approach provides better control over exposed information and allows for version override through environment variables.
Also applies to: 34-34
212-214
: Enhance version display accessibilityWhile the version display implementation is clean, consider adding accessibility attributes and a tooltip for better user experience.
<div className="flex flex-row justify-center items-center"> - <p className="text-sm text-gray-500">v{version}</p> + <p + className="text-sm text-gray-500 tooltip tooltip-top" + data-tip="Application version" + aria-label="Application version" + > + v{version} + </p> </div>
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
components/react/sideNav.tsx
(4 hunks)
🔇 Additional comments (1)
components/react/sideNav.tsx (1)
1-1
: Verify completeness of changes
The AI summary mentions removal of settings modal state (isSettingsModalOpen
) and onCloseModal
callback, but these changes are not visible in the provided code. Please verify if these changes are:
- Missing from this diff
- Made in separate commits
- Still pending implementation
Summary by CodeRabbit
New Features
Bug Fixes