Skip to content

Commit

Permalink
test: more poa and tokenfactory tests
Browse files Browse the repository at this point in the history
  • Loading branch information
@fmorency
fmorency committed May 23, 2024
1 parent 82cb2cb commit 417b8b4
Show file tree
Hide file tree
Showing 3 changed files with 179 additions and 53 deletions.
86 changes: 46 additions & 40 deletions interchaintest/helpers/group.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ import (
"path"
"testing"

"github.com/cockroachdb/errors"
"github.com/cosmos/cosmos-sdk/x/group"
"github.com/pkg/errors"
"github.com/strangelove-ventures/interchaintest/v8/chain/cosmos"
"github.com/strangelove-ventures/interchaintest/v8/dockerutil"
"github.com/strangelove-ventures/interchaintest/v8/ibc"
Expand All @@ -18,7 +18,7 @@ import (
// SubmitGroupProposal submits a group proposal to the chain.
// TODO: This function should be part of `interchaintest`
// See https://github.com/strangelove-ventures/interchaintest/issues/1138
func SubmitGroupProposal(ctx context.Context, t *testing.T, chain *cosmos.CosmosChain, config *ibc.ChainConfig, accAddr string, prop *group.MsgSubmitProposal) string {
func SubmitGroupProposal(ctx context.Context, t *testing.T, chain *cosmos.CosmosChain, config *ibc.ChainConfig, accAddr string, prop *group.MsgSubmitProposal) (string, error) {
file := "proposal.json"
propJson, err := json.MarshalIndent(prop, "", " ")
require.NoError(t, err)
Expand All @@ -37,70 +37,76 @@ func SubmitGroupProposal(ctx context.Context, t *testing.T, chain *cosmos.Cosmos
return exec(ctx, t, chain, config, tn.TxCommand(accAddr, submitCommand...))
}

// QueryGroupProposal queries a group proposal on the chain.
// TODO: This function should be part of `interchaintest`
// See https://github.com/strangelove-ventures/interchaintest/issues/1138
func QueryGroupProposal(ctx context.Context, t *testing.T, chain *cosmos.CosmosChain, config *ibc.ChainConfig, proposalId string) (string, error) {
query := []string{
"group", "proposal", proposalId,
}

tn := chain.GetNode()

o, _, err := tn.Exec(ctx, tn.QueryCommand(query...), config.Env)
if err != nil {
return "", errors.WithMessage(err, "failed to query group proposal")
}

var data interface{}
if err := json.Unmarshal([]byte(o), &data); err != nil {
return "", errors.WithMessage(err, "failed to unmarshal group proposal")

}

prettyJSON, err := json.MarshalIndent(data, "", " ")
if err != nil {
return "", errors.WithMessage(err, "failed to marshal group proposal")
}

return string(prettyJSON), nil
}
//// QueryGroupProposal queries a group proposal on the chain.
//// TODO: This function should be part of `interchaintest`
//// See https://github.com/strangelove-ventures/interchaintest/issues/1138
//func QueryGroupProposal(ctx context.Context, t *testing.T, chain *cosmos.CosmosChain, config *ibc.ChainConfig, proposalId string) (string, error) {
// query := []string{
// "group", "proposal", proposalId,
// }
//
// tn := chain.GetNode()
//
// o, _, err := tn.Exec(ctx, tn.QueryCommand(query...), config.Env)
// if err != nil {
// return "", errors.WithMessage(err, "failed to query group proposal")
// }
//
// var data interface{}
// if err := json.Unmarshal([]byte(o), &data); err != nil {
// return "", errors.WithMessage(err, "failed to unmarshal group proposal")
//
// }
//
// prettyJSON, err := json.MarshalIndent(data, "", " ")
// if err != nil {
// return "", errors.WithMessage(err, "failed to marshal group proposal")
// }
//
// return string(prettyJSON), nil
//}

// VoteGroupProposal votes on a group proposal on the chain.
// TODO: This function should be part of `interchaintest`
// See https://github.com/strangelove-ventures/interchaintest/issues/1138
func VoteGroupProposal(ctx context.Context, t *testing.T, chain *cosmos.CosmosChain, config *ibc.ChainConfig, proposalId, accAddr, vote, metadata string) string {
func VoteGroupProposal(ctx context.Context, t *testing.T, chain *cosmos.CosmosChain, config *ibc.ChainConfig, proposalId, accAddr, vote, metadata string) (string, error) {
voteCommand := []string{
"group", "vote", proposalId, accAddr, vote, metadata,
}
return exec(ctx, t, chain, config, chain.GetNode().TxCommand(accAddr, voteCommand...))
}

func ExecGroupProposal(ctx context.Context, t *testing.T, chain *cosmos.CosmosChain, config *ibc.ChainConfig, accAddr, proposalId string) string {
func ExecGroupProposal(ctx context.Context, t *testing.T, chain *cosmos.CosmosChain, config *ibc.ChainConfig, accAddr, proposalId string) (string, error) {
execCommand := []string{
"group", "exec", proposalId,
}
return exec(ctx, t, chain, config, chain.GetNode().TxCommand(accAddr, execCommand...))
}

func exec(ctx context.Context, t *testing.T, chain *cosmos.CosmosChain, config *ibc.ChainConfig, command []string) string {
func exec(ctx context.Context, t *testing.T, chain *cosmos.CosmosChain, config *ibc.ChainConfig, command []string) (string, error) {
tn := chain.GetNode()

o, _, err := tn.Exec(ctx, command, config.Env)
require.NoError(t, err)
if err != nil {
return "", errors.WithMessage(err, "failed to execute group proposal")
}

output := cosmos.CosmosTx{}
err = json.Unmarshal([]byte(o), &output)
require.NoError(t, err)
if err := json.Unmarshal([]byte(o), &output); err != nil {
return "", errors.WithMessage(err, "failed to unmarshal group proposal")
}

err = testutil.WaitForBlocks(ctx, 3, tn)
require.NoError(t, err)
if err := testutil.WaitForBlocks(ctx, 3, tn); err != nil {
return "", errors.WithMessage(err, "failed to wait for blocks")
}

txResp, err := chain.GetTransaction(output.TxHash)
require.NoError(t, err)
if err != nil {
return "", errors.WithMessage(err, "failed to get transaction")
}

// Check the transaction was successful
require.Equal(t, uint32(0x0), txResp.Code)

return txResp.TxHash
return txResp.TxHash, nil
}
131 changes: 119 additions & 12 deletions interchaintest/poa_group_test.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,12 @@ import (
"testing"
"time"

sdkmath "cosmossdk.io/math"
upgradetypes "cosmossdk.io/x/upgrade/types"
"github.com/cosmos/cosmos-sdk/codec"
"github.com/cosmos/cosmos-sdk/codec/types"
sdk "github.com/cosmos/cosmos-sdk/types"
banktypes "github.com/cosmos/cosmos-sdk/x/bank/types"
grouptypes "github.com/cosmos/cosmos-sdk/x/group"
"github.com/strangelove-ventures/interchaintest/v8"
"github.com/strangelove-ventures/interchaintest/v8/chain/cosmos"
Expand Down Expand Up @@ -118,6 +121,12 @@ var (
AllowValidatorSelfExit: true,
}

bankSendProposal = &banktypes.MsgSend{
FromAddress: groupAddr,
ToAddress: accAddr,
Amount: sdk.NewCoins(sdk.NewInt64Coin(Denom, 1)),
}

proposalId = 1
)

Expand Down Expand Up @@ -194,6 +203,9 @@ func TestGroupPOA(t *testing.T) {
// POA Update
testPOAParamsUpdateEmpty(t, ctx, chain, &cfgA, accAddr)
testPOAParamsUpdate(t, ctx, chain, &cfgA, accAddr, user1)
// Bank
testBankSend(t, ctx, chain, &cfgA, accAddr)
testBankSendIllegal(t, ctx, chain, &cfgA, accAddr)

t.Cleanup(func() {
// Copy coverage files from the container
Expand All @@ -219,7 +231,8 @@ func testSoftwareUpgrade(t *testing.T, ctx context.Context, chain *cosmos.Cosmos
require.NoError(t, err)

prop := createProposal(groupAddr, []string{accAddr}, []*types.Any{upgradeProposalAny}, "Software Upgrade Proposal", "Upgrade the software to the latest version")
submitVoteAndExecProposal(ctx, t, chain, config, accAddr, prop)
err = submitVoteAndExecProposal(ctx, t, chain, config, accAddr, prop)
require.NoError(t, err)

// Verify the upgrade plan is set
plan, err = chain.UpgradeQueryPlan(ctx)
Expand All @@ -232,7 +245,8 @@ func testSoftwareUpgrade(t *testing.T, ctx context.Context, chain *cosmos.Cosmos
require.NoError(t, err)

prop = createProposal(groupAddr, []string{accAddr}, []*types.Any{cancelUpgradeProposalAny}, "Cancel Upgrade Proposal", "Cancel the software upgrade")
submitVoteAndExecProposal(ctx, t, chain, config, accAddr, prop)
err = submitVoteAndExecProposal(ctx, t, chain, config, accAddr, prop)
require.NoError(t, err)

// Verify the upgrade plan is cancelled
plan, err = chain.UpgradeQueryPlan(ctx)
Expand All @@ -253,7 +267,8 @@ func testManifestParamsUpdate(t *testing.T, ctx context.Context, chain *cosmos.C
require.NoError(t, err)

prop := createProposal(groupAddr, []string{accAddr}, []*types.Any{manifestUpdateProposalAny}, "Manifest Params Update Proposal (without Inflation param)", "Update the manifest params (without Inflation param). https://github.com/liftedinit/manifest-ledger/issues/61")
submitVoteAndExecProposal(ctx, t, chain, config, accAddr, prop)
err = submitVoteAndExecProposal(ctx, t, chain, config, accAddr, prop)
require.NoError(t, err)

// Verify the updated manifest params
checkManifestParams(ctx, t, chain, &manifestUpdateProposal.Params)
Expand All @@ -278,7 +293,8 @@ func testManifestParamsUpdateWithInflation(t *testing.T, ctx context.Context, ch
require.NoError(t, err)

prop := createProposal(groupAddr, []string{accAddr}, []*types.Any{manifestUpdateProposalAny}, "Manifest Params Update Proposal (with Inflation param)", "Update the manifest params (with Inflation param)")
submitVoteAndExecProposal(ctx, t, chain, config, accAddr, prop)
err = submitVoteAndExecProposal(ctx, t, chain, config, accAddr, prop)
require.NoError(t, err)

// Verify the updated manifest params
checkManifestParams(ctx, t, chain, &manifestUpdateProposal2.Params)
Expand All @@ -300,7 +316,8 @@ func testManifestParamsUpdateEmpty(t *testing.T, ctx context.Context, chain *cos
require.NoError(t, err)

prop := createProposal(groupAddr, []string{accAddr}, []*types.Any{manifestUpdateProposalAny}, "Manifest Params Update Proposal (empty)", "Update the manifest params (empty)")
submitVoteAndExecProposal(ctx, t, chain, config, accAddr, prop)
err = submitVoteAndExecProposal(ctx, t, chain, config, accAddr, prop)
require.NoError(t, err)

// Verify the updated manifest params
checkManifestParams(ctx, t, chain, &manifestUpdateEmptyProposal.Params)
Expand All @@ -324,7 +341,8 @@ func testPOAParamsUpdateEmpty(t *testing.T, ctx context.Context, chain *cosmos.C
require.NoError(t, err)

prop := createProposal(groupAddr, []string{accAddr}, []*types.Any{poaUpdateProposalAny}, "POA Params Update Proposal", "Update the POA params")
submitVoteAndExecProposal(ctx, t, chain, config, accAddr, prop)
err = submitVoteAndExecProposal(ctx, t, chain, config, accAddr, prop)
require.NoError(t, err)

// Verify the POA params are unchanged
checkPOAParams(ctx, t, chain, poaDefaultParams)
Expand All @@ -344,7 +362,8 @@ func testPOAParamsUpdate(t *testing.T, ctx context.Context, chain *cosmos.Cosmos
require.NoError(t, err)

prop := createProposal(groupAddr, []string{accAddr}, []*types.Any{poaUpdateProposalAny}, "POA Params Update Proposal", "Update the POA params")
submitVoteAndExecProposal(ctx, t, chain, config, accAddr, prop)
err = submitVoteAndExecProposal(ctx, t, chain, config, accAddr, prop)
require.NoError(t, err)

checkPOAParams(ctx, t, chain, &poaUpdateProposal.Params)

Expand All @@ -364,13 +383,91 @@ func testPOAParamsUpdate(t *testing.T, ctx context.Context, chain *cosmos.Cosmos
checkPOAParams(ctx, t, chain, poaDefaultParams)
}

// testBankSend tests the sending of funds from one account to another using a group proposal
func testBankSend(t *testing.T, ctx context.Context, chain *cosmos.CosmosChain, config *ibc.ChainConfig, accAddr string) {
t.Log("\n===== TEST GROUP BANK SEND =====")

// Verify the initial balances
accAddrInitialBal, err := chain.BankQueryBalance(ctx, accAddr, Denom)
require.NoError(t, err)
require.Equal(t, DefaultGenesisAmt, accAddrInitialBal)

groupAddrInitialBal, err := chain.BankQueryBalance(ctx, groupAddr, Denom)
require.NoError(t, err)
require.Equal(t, sdkmath.NewInt(0), groupAddrInitialBal)

// Send funds from accAddr to groupAddr
err = chain.SendFunds(ctx, accAddr, ibc.WalletAmount{
Address: groupAddr,
Denom: Denom,
Amount: sdkmath.NewInt(1),
})
require.NoError(t, err)

// Verify the funds were sent
groupAddrBal, err := chain.BankQueryBalance(ctx, groupAddr, Denom)
require.NoError(t, err)
require.Equal(t, sdkmath.NewInt(1), groupAddrBal)

// Send funds from groupAddr back to accAddr using a Group Proposal
bankSendProposalAny, err := types.NewAnyWithValue(bankSendProposal)
require.NoError(t, err)

prop := createProposal(groupAddr, []string{accAddr}, []*types.Any{bankSendProposalAny}, "Bank Send Proposal", "Send funds from groupAddr back to accAddr")
err = submitVoteAndExecProposal(ctx, t, chain, config, accAddr, prop)
require.NoError(t, err)

// Verify the funds were sent
accAddrBal, err := chain.BankQueryBalance(ctx, accAddr, Denom)
require.NoError(t, err)
require.Equal(t, DefaultGenesisAmt, accAddrBal)

groupAddrBal, err = chain.BankQueryBalance(ctx, groupAddr, Denom)
require.NoError(t, err)
require.Equal(t, sdkmath.NewInt(0), groupAddrBal)
}

func testBankSendIllegal(t *testing.T, ctx context.Context, chain *cosmos.CosmosChain, config *ibc.ChainConfig, accAddr string) {
t.Log("\n===== TEST GROUP BANK SEND (ILLEGAL) =====")
newProp := bankSendProposal
newProp.FromAddress = accAddr
newProp.ToAddress = acc2Addr

// Verify initial balances
accAddrBal, err := chain.BankQueryBalance(ctx, accAddr, Denom)
require.NoError(t, err)
require.Equal(t, DefaultGenesisAmt, accAddrBal)

acc2AddrBal, err := chain.BankQueryBalance(ctx, acc2Addr, Denom)
require.NoError(t, err)
require.Equal(t, DefaultGenesisAmt, acc2AddrBal)

// Send funds from groupAddr back to accAddr using a Group Proposal
bankSendProposalAny, err := types.NewAnyWithValue(newProp)
require.NoError(t, err)

prop := createProposal(groupAddr, []string{accAddr}, []*types.Any{bankSendProposalAny}, "Bank Send Proposal (Illegal)", "Should not be executed")
err = submitVoteAndExecProposal(ctx, t, chain, config, accAddr, prop)
require.Error(t, err)

// Verify the funds were not sent
accAddrBal, err = chain.BankQueryBalance(ctx, accAddr, Denom)
require.NoError(t, err)
require.Equal(t, DefaultGenesisAmt, accAddrBal)

acc2AddrBal, err = chain.BankQueryBalance(ctx, acc2Addr, Denom)
require.NoError(t, err)
require.Equal(t, DefaultGenesisAmt, acc2AddrBal)
}

// resetManifestParams resets the manifest params back to the default
func resetManifestParams(t *testing.T, ctx context.Context, chain *cosmos.CosmosChain, config *ibc.ChainConfig, accAddr string) {
manifestDefaultProposalAny, err := types.NewAnyWithValue(manifestDefaultProposal)
require.NoError(t, err)

prop := createProposal(groupAddr, []string{accAddr}, []*types.Any{manifestDefaultProposalAny}, "Manifest Params Update Proposal (reset)", "Reset the manifest params to the default")
submitVoteAndExecProposal(ctx, t, chain, config, accAddr, prop)
err = submitVoteAndExecProposal(ctx, t, chain, config, accAddr, prop)
require.NoError(t, err)

checkManifestParams(ctx, t, chain, &manifestDefaultProposal.Params)
}
Expand Down Expand Up @@ -407,16 +504,26 @@ func checkPOAParams(ctx context.Context, t *testing.T, chain *cosmos.CosmosChain
}

// submitVoteAndExecProposal submits, votes, and executes a group proposal
func submitVoteAndExecProposal(ctx context.Context, t *testing.T, chain *cosmos.CosmosChain, config *ibc.ChainConfig, accAddr string, prop *grouptypes.MsgSubmitProposal) {
func submitVoteAndExecProposal(ctx context.Context, t *testing.T, chain *cosmos.CosmosChain, config *ibc.ChainConfig, accAddr string, prop *grouptypes.MsgSubmitProposal) error {
pid := strconv.Itoa(proposalId)

marshalProposal(t, prop)

helpers.SubmitGroupProposal(ctx, t, chain, config, accAddr, prop)
helpers.VoteGroupProposal(ctx, t, chain, config, pid, accAddr, grouptypes.VOTE_OPTION_YES.String(), metadata)
helpers.ExecGroupProposal(ctx, t, chain, config, accAddr, pid)
_, err := helpers.SubmitGroupProposal(ctx, t, chain, config, accAddr, prop)
if err != nil {
return err
}
_, err = helpers.VoteGroupProposal(ctx, t, chain, config, pid, accAddr, grouptypes.VOTE_OPTION_YES.String(), metadata)
if err != nil {
return err
}
_, err = helpers.ExecGroupProposal(ctx, t, chain, config, accAddr, pid)
if err != nil {
return err
}

proposalId = proposalId + 1
return nil
}

// createProposal creates a group proposal
Expand Down
15 changes: 14 additions & 1 deletion scripts/test_node.sh
View file
Original file line number Diff line number Diff line change
Expand Up @@ -94,8 +94,21 @@ from_scratch () {
update_test_genesis '.app_state["manifest"]["params"]["inflation"]["automatic_enabled"]=false'
update_test_genesis '.app_state["manifest"]["params"]["stake_holders"]=[{"address":"manifest1hj5fveer5cjtn4wd6wstzugjfdxzl0xp8ws9ct","percentage":100000000}]'

# tokenfactory
# SPDT
update_test_genesis '.app_state["tokenfactory"]["factory_denoms"]=[{"denom": "factory/manifest1afk9zr2hn2jsac63h4hm60vl9z3e5u69gndzf7c99cqge3vzwjzsfmy9qj/uspdt", "authority_metadata": {"admin": "manifest1afk9zr2hn2jsac63h4hm60vl9z3e5u69gndzf7c99cqge3vzwjzsfmy9qj"}}]'
update_test_genesis '.app_state["bank"]["denom_metadata"]=[{"description": "SpaceData", "denom_units": [{"denom": "factory/manifest1afk9zr2hn2jsac63h4hm60vl9z3e5u69gndzf7c99cqge3vzwjzsfmy9qj/uspdt", "exponent": 0, "aliases": ["SPDT"]}, {"denom": "SPDT", "exponent": 6, "aliases": ["factory/manifest1afk9zr2hn2jsac63h4hm60vl9z3e5u69gndzf7c99cqge3vzwjzsfmy9qj/uspdt"]}], "base": "factory/manifest1afk9zr2hn2jsac63h4hm60vl9z3e5u69gndzf7c99cqge3vzwjzsfmy9qj/uspdt", "display": "SPDT", "name": "SpaceData", "symbol": "SPDT", "uri": "", "uri_hash": ""}]'

#ABUS
update_test_genesis '.app_state["tokenfactory"]["factory_denoms"] |= . + [{"denom": "factory/manifest1afk9zr2hn2jsac63h4hm60vl9z3e5u69gndzf7c99cqge3vzwjzsfmy9qj/uabus", "authority_metadata": {"admin": "manifest1afk9zr2hn2jsac63h4hm60vl9z3e5u69gndzf7c99cqge3vzwjzsfmy9qj"}}]'
update_test_genesis '.app_state["bank"]["denom_metadata"] |= . + [{"description": "Arebus Gas Token", "denom_units": [{"denom": "factory/manifest1afk9zr2hn2jsac63h4hm60vl9z3e5u69gndzf7c99cqge3vzwjzsfmy9qj/uabus", "exponent": 0, "aliases": ["ABUS"]}, {"denom": "ABUS", "exponent": 6, "aliases": ["factory/manifest1afk9zr2hn2jsac63h4hm60vl9z3e5u69gndzf7c99cqge3vzwjzsfmy9qj/uabus"]}], "base": "factory/manifest1afk9zr2hn2jsac63h4hm60vl9z3e5u69gndzf7c99cqge3vzwjzsfmy9qj/uabus", "display": "ABUS", "name": "Arebus Gas Token", "symbol": "ABUS", "uri": "", "uri_hash": ""}]'

# Add all other MANY tokens
# ...
# ...

# Allocate genesis accounts
BINARY genesis add-genesis-account $KEY 1000000upoa,10000000umfx,1000utest --keyring-backend $KEYRING
BINARY genesis add-genesis-account $KEY 1000000upoa,10000000umfx,1000utest,1000000000000000000000factory/manifest1afk9zr2hn2jsac63h4hm60vl9z3e5u69gndzf7c99cqge3vzwjzsfmy9qj/uspdt,100000000000000000000000factory/manifest1afk9zr2hn2jsac63h4hm60vl9z3e5u69gndzf7c99cqge3vzwjzsfmy9qj/uabus --keyring-backend $KEYRING
BINARY genesis add-genesis-account $KEY2 100000umfx,1000utest --keyring-backend $KEYRING

# Set 1 POAToken -> user
Expand Down

0 comments on commit 417b8b4

Please sign in to comment.