Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump cosmossdk.io/x/tx #115

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Conversation

fmorency
Copy link
Collaborator

@fmorency fmorency commented Jan 6, 2025

Address govulncheck findings.

Summary by CodeRabbit

  • Dependency Updates
    • Updated cosmossdk.io/x/tx from v0.13.3 to v0.13.7
    • Updated cosmossdk.io/core to v0.11.0
    • Updated github.com/cosmos/cosmos-sdk to a specific liftedinit fork version v0.50.8-liftedinit.1

@fmorency fmorency self-assigned this Jan 6, 2025
@fmorency fmorency requested a review from Reecepbcups January 6, 2025 19:54
Copy link

coderabbitai bot commented Jan 6, 2025

Walkthrough

The pull request focuses on updating dependency versions in go.mod files for the main project and the interchaintest module. The primary changes involve upgrading the cosmossdk.io/x/tx module from version v0.13.3 to v0.13.7. Additionally, the interchaintest/go.mod file includes updates to cosmossdk.io/core and github.com/cosmos/cosmos-sdk dependencies, pointing to specific versions that ensure compatibility with the project's requirements.

Changes

File Changes
go.mod Updated cosmossdk.io/x/tx from v0.13.3 to v0.13.7
interchaintest/go.mod - Updated cosmossdk.io/x/tx from v0.13.3 to v0.13.7
- Updated cosmossdk.io/core to v0.11.0
- Updated github.com/cosmos/cosmos-sdk to v0.50.8-liftedinit.1

Poem

🐰 Hop, hop, dependencies dance!
Versions bump with each new chance
TX module grows, SDK takes flight
Interchaintest's modules shine bright
Upgrade complete, code's looking neat! 🚀


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 46d0c1f and f91ffc1.

⛔ Files ignored due to path filters (2)
  • go.sum is excluded by !**/*.sum
  • interchaintest/go.sum is excluded by !**/*.sum
📒 Files selected for processing (2)
  • go.mod (1 hunks)
  • interchaintest/go.mod (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (6)
  • GitHub Check: e2e-tests (ictest-group-poa)
  • GitHub Check: e2e-tests (ictest-manifest)
  • GitHub Check: e2e-tests (ictest-tokenfactory)
  • GitHub Check: e2e-tests (ictest-ibc)
  • GitHub Check: Analyze
  • GitHub Check: build
🔇 Additional comments (2)
go.mod (1)

34-34: Verify security status of cosmossdk.io/x/tx v0.13.7

The version update from v0.13.3 to v0.13.7 appears to address govulncheck findings.

Let's verify if this is the latest secure version and check for any known vulnerabilities:

✅ Verification successful

✅ Security update to v0.13.7 verified as secure

The update to v0.13.7 is confirmed to be the latest version and specifically patches HIGH severity vulnerabilities (ASA-2024-0012, ASA-2024-0013) related to transaction decoding security issues.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check for the latest version and security advisories for cosmossdk.io/x/tx

# Get the latest version from pkg.go.dev
curl -s "https://pkg.go.dev/cosmossdk.io/x/tx?tab=versions" | grep -o 'v0.13.[0-9]*' | sort -V | tail -n 1

# Check for any security advisories
gh api graphql -f query='
{
  securityVulnerabilities(first: 5, ecosystem: GO, package: "cosmossdk.io/x/tx") {
    nodes {
      advisory {
        summary
        severity
        publishedAt
      }
      vulnerableVersionRange
      firstPatchedVersion {
        identifier
      }
    }
  }
}'

Length of output: 746

interchaintest/go.mod (1)

49-49: LGTM! Version update is consistent

The update to cosmossdk.io/x/tx v0.13.7 matches the version in the main module, maintaining consistency across the codebase.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@fmorency fmorency merged commit b35e460 into liftedinit:main Jan 6, 2025
14 checks passed
@fmorency fmorency deleted the bump-tx branch January 6, 2025 20:17
@coderabbitai coderabbitai bot mentioned this pull request Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant