Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: qol #55

Merged
merged 6 commits into from
May 9, 2024
Merged

fix: qol #55

merged 6 commits into from
May 9, 2024

Conversation

fmorency
Copy link
Collaborator

@fmorency fmorency commented May 8, 2024

  • Add make format, make vet and make govulncheck
  • Run lint and govulncheck in CI
  • Fix lint and format
  • Bump go to 1.22.3 (fixes GO-2024-2824)

@fmorency fmorency self-assigned this May 8, 2024
Copy link

codecov bot commented May 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 72.40%. Comparing base (3a343bc) to head (a6e95f0).

Files Patch % Lines
app/upgrades/noop/upgrades.go 0.00% 0 Missing and 1 partial ⚠️
x/manifest/client/cli/query.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #55   +/-   ##
=======================================
  Coverage   72.40%   72.40%           
=======================================
  Files          32       32           
  Lines        1689     1689           
=======================================
  Hits         1223     1223           
  Misses        407      407           
  Partials       59       59           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fmorency fmorency marked this pull request as ready for review May 8, 2024 13:33
@fmorency fmorency requested a review from Reecepbcups May 8, 2024 13:33
@fmorency fmorency merged commit 35ecd70 into liftedinit:main May 9, 2024
13 of 14 checks passed
@fmorency fmorency deleted the qol branch May 9, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants