-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: more tests and cleanup #69
Conversation
Remove legacy code no longer needed as per https://github.com/cosmos/cosmos-sdk/blob/4fea3fba73abafc80d4f5b840b04f787d1138a3c/UPGRADING.md?plain=1#L700
I'll rerun the failed job tomorrow as we reached Docker request limits.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #69 +/- ##
==========================================
+ Coverage 73.41% 74.32% +0.91%
==========================================
Files 31 31
Lines 1685 1675 -10
==========================================
+ Hits 1237 1245 +8
+ Misses 395 377 -18
Partials 53 53 ☔ View full report in Codecov by Sentry. |
Disregard the codecov/patch complain. |
sdk "github.com/cosmos/cosmos-sdk/types" | ||
"github.com/cosmos/cosmos-sdk/types/msgservice" | ||
) | ||
|
||
var amino = codec.NewLegacyAmino() | ||
|
||
func init() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I remember removing this in the past for a network & it causing issues. They did come up from SDK v47 -> v50 though, so it's possible it was specific to that vs being on SDK v50 from the start like manifest. Just want to call it out now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you remember the issue?
This PR adds