Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: documenting persistent dev mode #1918

Merged
merged 5 commits into from
Dec 15, 2023
Merged

Conversation

aludwiko
Copy link
Contributor

No description provided.

@github-actions github-actions bot added Documentation Improvements or additions to the documentation java-sdk java-sdk-protobuf kalix-runtime Runtime and SDKs sub-team scala-sdk-protobuf labels Dec 14, 2023
@@ -3,11 +3,15 @@ services:
kalix-runtime:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once we agree that the docker-compose change is ok, I will change all compose files in samples.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unless in a specific sample we demonstrate something that needs persistence, I would not change all the sample compose files to include this. I think maybe in the archetype we can put this (we have other flags there as well) but on the samples I don't see much benefit.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit biased because I was using this a lot the last few days, but for me, the benefit is that the config is there, I don't have to look for it in the docs and copy-paste some lines. It's just a matter of uncommenting and I'm ready to go.

@aludwiko aludwiko marked this pull request as ready for review December 14, 2023 08:58
Copy link
Member

@ennru ennru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ennru ennru merged commit 26f045f into main Dec 15, 2023
@ennru ennru deleted the documenting-dev-mode-persistence branch December 15, 2023 11:10
aklikic pushed a commit to aklikic/kalix-jvm-sdk that referenced this pull request Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements or additions to the documentation java-sdk java-sdk-protobuf kalix-runtime Runtime and SDKs sub-team scala-sdk-protobuf
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants