Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(javasdk): support multiple values in a static claim #1925

Merged
merged 3 commits into from
Jan 9, 2024

Conversation

efgpinto
Copy link
Member

Refs https://github.com/lightbend/kalix-runtime/issues/2193

Review for review but needs to wait for next runtime release thus marking as draft.

@github-actions github-actions bot added Documentation Improvements or additions to the documentation java-sdk kalix-runtime Runtime and SDKs sub-team labels Dec 18, 2023
Copy link
Contributor

@franciscolopezsancho franciscolopezsancho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked with latest runtime and it LGTM

----
<1> When declaring multiple values for the same claim, **all** of them will be required when validating the request.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@octonato octonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@efgpinto efgpinto marked this pull request as ready for review January 9, 2024 18:17
@efgpinto efgpinto merged commit 92feccf into main Jan 9, 2024
66 checks passed
@efgpinto efgpinto deleted the efgpinto/javasdk-multiple-static-claim-values branch January 9, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements or additions to the documentation java-sdk kalix-runtime Runtime and SDKs sub-team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants