Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unbreak docker-compose.yml #60

Merged
merged 2 commits into from
Jan 5, 2024
Merged

fix: unbreak docker-compose.yml #60

merged 2 commits into from
Jan 5, 2024

Conversation

johanandren
Copy link
Contributor

Something wrong with some brackets there (not sure why they are in there to start with though)

@efgpinto
Copy link
Member

efgpinto commented Jan 5, 2024

Feels like a copy-pasta-gone-wrong from previous commit copied from the maven archetype one, where we use those weird things to be able to declare a container_name with a artifatId, see here.

So I think we could remove those here. (we could also probably add the container name here, not sure what the syntax looks like in g8).

@johanandren
Copy link
Contributor Author

Removed. Note that there is templating/substitution for g8 templates as well, with a dont-substitute-list in default.properties, I wonder if that is needed here to to not replace the envs https://github.com/akka/akka-grpc-quickstart-scala.g8/blob/main/src/main/g8/default.properties#L8C1-L8C10

@johanandren johanandren merged commit e279cae into main Jan 5, 2024
1 check passed
@johanandren johanandren deleted the johanandren-patch-1 branch January 5, 2024 13:48
@johanandren
Copy link
Contributor Author

Created a new project and verified nothing funky ends up happening to the docker-compose.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants