Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added anchor support to commitment HTLC outputs #3

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ksedgwic
Copy link

@ksedgwic ksedgwic commented Nov 15, 2021

Still needed:

  • rebase onto upstream (requires updating r-l-s)

@ksedgwic
Copy link
Author

I can't reconcile the WEIGHT_{OFFERED,RECEIVED}_HTLC calculations at
https://github.com/lightning-signer/rust-lightning/blob/master/lightning/src/chain/package.rs#L48
with
https://github.com/lightning/bolts/blob/master/03-transactions.md#expected-weight-of-htlc-timeout-and-htlc-success-transactions

rust-lightning sez 139 and 133 and the BOLT specs 140 and 133 (w/o anchors)

I wanted to understand this before adding the anchors weight estimates ...

@ksedgwic ksedgwic force-pushed the 2021-11-fix-anchors-2 branch from a34d45e to f08000b Compare November 15, 2021 20:12
@ksedgwic ksedgwic force-pushed the 2021-11-fix-anchors-2 branch from f08000b to dd090d4 Compare November 15, 2021 20:54
@ksedgwic ksedgwic force-pushed the 2021-11-fix-anchors-2 branch 2 times, most recently from 1e73c0b to f988991 Compare November 15, 2021 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants