2021 11 cherry anchors #4
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # lightning/src/ln/chan_utils.
ksedgwic
force-pushed
the
2021-11-cherry-anchors
branch
from
2df5f4d to
0e3c95c
Compare
ksedgwic
force-pushed
the
2021-11-cherry-anchors
branch
from
5635359 to
6837b75
Compare
devrandom
reviewed
Nov 17, 2021
| @@ -42,8 +42,10 @@ use chain; | |||
|
|
|||
| pub(crate) const MAX_HTLCS: u16 = 483; | |||
|
|
|||
| pub(super) const HTLC_SUCCESS_TX_WEIGHT: u64 = 703; | |||
| pub(super) const HTLC_TIMEOUT_TX_WEIGHT: u64 = 663; | |||
| /// The fee for an HTLC-success transaction | |||
There was a problem hiding this comment.
it's the weight, not the fee
|
One more nit - commit descriptions are usually in the present tense. Any ideas about the PR title for upstream? maybe "Anchor support for HTLCs"? |
|
Also, I think this can be submitted as a single PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is
v0.0.102with our anchor MRs cherry-picked, plus more fixes.The plan is to get this working and then divide it into sensible upstream PR(s) ...