-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feeadjuster: various updates/fixes #525
Merged
chrisguida
merged 10 commits into
lightningd:master
from
daywalker90:feeadjuster/basefee_switch
May 25, 2024
Merged
feeadjuster: various updates/fixes #525
chrisguida
merged 10 commits into
lightningd:master
from
daywalker90:feeadjuster/basefee_switch
May 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixed a potential crash when the user did not touch the CLN default values for fee-base or fee-per-satoshi
Excellent work! |
@m-schmoock @telelvis care to approve this? |
fantastic work by @daywalker90 , imo. |
This was referenced Jun 4, 2024
This was referenced Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ok so i was bored and went over the feeadjuster plugin because @grubles said there were problems with it.
I found a compatibility issue in #457 with
listconfigs
so i made a wrapper function to support both the old and new structure oflistconfigs
.I went over all the feeadjuster issues that were reporting bugs and most of them are probably users who updated their node but not their
pyln-client
, since we can't raise the version inrequirements.txt
ourselves because that would also break compatibility (maybe fixed by this ?).But i also found an actual issue in #199 which i fixed by always getting the channel balance from a rpc call to
listpeers
/listpeerchannels
instead of doing math with the data from theforward_event
. We need to do this because between forwards there can be invoices getting paid, payments sent out or channel splices. Listening for these events is rather pointless since they don't contain data about what channel balances changed, so we would have to do rpc calls anyways. Unfortunatelylistpeers
/listpeerchannels
does not update quite as fast as theforward_event
so we have to wait a bit.Then @grubles pointed me to the PR #467 from @m-schmoock and i incorporated it together with my fixes.
Then i tested
feeadjuster
against CLN 23.02.2, 23.05.2, 23.08.1, 23.11.2 and 24.02.2I had to adjust the tests a bit to accomodate for the bad gossip retransmission in older CLN versions (it's still slightly flaky but who cares)
just rewrite it in rust lul