sauron: make tests more robust #649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cln-grpc was dying and taking the rest of lightningd with it (because it's important) because it was trying to listen on port 9736 in multiple tests simlutaneously. this PR allows the sauron tests to take advantage of the new plyn-testing feature that assigns the grpc plugin a random unused port by default. sauron's tests were previously overriding these values in its override fixtures, and this PR corrects that. there is still some brittle- ness around the `TEST_NETWORK` global variable, but setting it in the override `LightningNode` fixture at the top of each test, immediately before the call to init the superclass, appears to make the tests pass, so we'll leave it like this for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cln-grpc was dying and taking the rest of lightningd with it (because it's important) because it was trying to listen on port 9736 in multiple tests simlutaneously. this PR allows the sauron tests to take advantage of the new plyn-testing feature that assigns the grpc plugin a random unused port by default. sauron's tests were previously overriding these values in its override fixtures, and this PR corrects that. there is still some brittle- ness around the
TEST_NETWORKglobal variable, but setting it in the overrideLightningNodefixture at the top of each test, immediately before the call to init the superclass, appears to make the tests pass, so we'll leave it like this for now.we also remove the pin to
pyln-client24.05, as this requirement no longer seems necessary.this fixes #618