Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustfmt: Run on lightning-invoice #3221

Merged

Conversation

tnull
Copy link
Contributor

@tnull tnull commented Aug 2, 2024

We run rustfmt on the lightning-invoice crate.

@tnull tnull marked this pull request as draft August 2, 2024 17:06
Copy link

codecov bot commented Aug 2, 2024

Codecov Report

Attention: Patch coverage is 93.03797% with 33 lines in your changes missing coverage. Please review.

Project coverage is 89.68%. Comparing base (4322b19) to head (b5b70e7).
Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
lightning-invoice/src/de.rs 88.30% 9 Missing and 11 partials ⚠️
lightning-invoice/src/lib.rs 95.59% 12 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3221      +/-   ##
==========================================
- Coverage   89.70%   89.68%   -0.02%     
==========================================
  Files         129      129              
  Lines      105437   105460      +23     
  Branches   105437   105460      +23     
==========================================
+ Hits        94582    94585       +3     
- Misses       8113     8130      +17     
- Partials     2742     2745       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tnull tnull force-pushed the 2024-08-rustfmt-lightning-invoice branch from 1c6c7f1 to e175cf5 Compare August 2, 2024 21:10
@tnull tnull marked this pull request as ready for review August 2, 2024 21:10
@TheBlueMatt
Copy link
Collaborator

There's a lot going on in this crate right now for the bech32 upgrade, sadly, so I'm afraid this might want to wait :/

@tnull
Copy link
Contributor Author

tnull commented Aug 9, 2024

There's a lot going on in this crate right now for the bech32 upgrade, sadly, so I'm afraid this might want to wait :/

Yeah, I agree. Happy to rebase once the changes landed.

@tnull tnull force-pushed the 2024-08-rustfmt-lightning-invoice branch from e175cf5 to 61cd611 Compare August 17, 2024 07:21
@tnull
Copy link
Contributor Author

tnull commented Aug 17, 2024

Rebased to resolve conflicts with main

@tnull tnull requested a review from TheBlueMatt August 17, 2024 07:24
@TheBlueMatt
Copy link
Collaborator

Blocked on #3270

@tnull tnull force-pushed the 2024-08-rustfmt-lightning-invoice branch from 61cd611 to 73df283 Compare October 7, 2024 08:18
@tnull
Copy link
Contributor Author

tnull commented Oct 7, 2024

Rebased after #3270 landed.

@tnull tnull force-pushed the 2024-08-rustfmt-lightning-invoice branch from 73df283 to d53788d Compare November 5, 2024 09:09
@tnull
Copy link
Contributor Author

tnull commented Nov 5, 2024

Rebased once more to address minor conflicts.

Copy link
Collaborator

@TheBlueMatt TheBlueMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs rebase again but the changes are mostly fine.

lightning-invoice/src/de.rs Outdated Show resolved Hide resolved
lightning-invoice/src/ser.rs Show resolved Hide resolved
lightning-invoice/src/lib.rs Outdated Show resolved Hide resolved
lightning-invoice/src/lib.rs Outdated Show resolved Hide resolved
@tnull tnull force-pushed the 2024-08-rustfmt-lightning-invoice branch from d53788d to 06c183a Compare November 14, 2024 10:53
@tnull
Copy link
Contributor Author

tnull commented Nov 14, 2024

Rebased and addressed comments.

@tnull tnull force-pushed the 2024-08-rustfmt-lightning-invoice branch from 06c183a to b5b70e7 Compare November 14, 2024 12:51
@TheBlueMatt TheBlueMatt merged commit 41f0623 into lightningdevkit:main Nov 14, 2024
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants