-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustfmt
: Run on lightning-invoice
#3221
rustfmt
: Run on lightning-invoice
#3221
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3221 +/- ##
==========================================
- Coverage 89.70% 89.68% -0.02%
==========================================
Files 129 129
Lines 105437 105460 +23
Branches 105437 105460 +23
==========================================
+ Hits 94582 94585 +3
- Misses 8113 8130 +17
- Partials 2742 2745 +3 ☔ View full report in Codecov by Sentry. |
1c6c7f1
to
e175cf5
Compare
There's a lot going on in this crate right now for the bech32 upgrade, sadly, so I'm afraid this might want to wait :/ |
Yeah, I agree. Happy to rebase once the changes landed. |
e175cf5
to
61cd611
Compare
Rebased to resolve conflicts with |
Blocked on #3270 |
61cd611
to
73df283
Compare
Rebased after #3270 landed. |
73df283
to
d53788d
Compare
Rebased once more to address minor conflicts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs rebase again but the changes are mostly fine.
d53788d
to
06c183a
Compare
Rebased and addressed comments. |
06c183a
to
b5b70e7
Compare
We run
rustfmt
on thelightning-invoice
crate.