Pin cc on Windows MSRV. #3357
Pin cc on Windows MSRV. #3357
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3357 +/- ##
==========================================
- Coverage 89.61% 89.58% -0.04%
==========================================
Files 127 127
Lines 103533 103533
Branches 103533 103533
==========================================
- Hits 92785 92750 -35
- Misses 8051 8076 +25
- Partials 2697 2707 +10 ☔ View full report in Codecov by Sentry. |
Sorry to be annoying here, but just for context do you have the stack trace/error that this PR is fixing? |
|
Ah, alas, the error was a timeout that wasn't actually leaving any actionable stack trace. Take a look at any (other) currently open or recently closed PR and check the Windows/1.63.0 build logs. |
|
With debug-level logging enabled, there would have been a stack trace which I described here: rust-bitcoin/rust-secp256k1#748 |
| - name: Pin cc on Windows MSRV | ||
| if: "matrix.toolchain == '1.63.0' && matrix.platform == 'windows-latest'" | ||
| run: | | ||
| cargo update -p [email protected] --precise "0.23.0" --verbose |
There was a problem hiding this comment.
Can't we just pin cc?
I don't think we should pin rustls and all the other crypto crates (even if it's just on Windows).
There was a problem hiding this comment.
I had originally tried to pin an older version of cc, so I tried again for this one. The short answer is no, I'm afraid.
|
Lol the build is still failing....should we just not have an MSRV on windows? |
|
Yeah I can open a different PR to just turn it off. I've tried digging into the documentation path issue but don't think it's worth pursuing. |
|
If we're not gonna get the full job to pass, I'm not sure having it better is worth much. IMO we should just close this. |
|
Oh well. So long, Windows. |
This ought to fix the CI issues.