Skip to content

Bump lnd to v0.18.5, enforce min version #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 18, 2025
Merged

Bump lnd to v0.18.5, enforce min version #211

merged 5 commits into from
Mar 18, 2025

Conversation

guggero
Copy link
Member

@guggero guggero commented Mar 13, 2025 •
edited
Loading

Also replaces:

Pull Request Checklist

  • PR is opened against correct version branch.
  • Version compatibility matrix in the README and minimal required version
    in lnd_services.go are updated.
  • Update macaroon_recipes.go if your PR adds a new method that is called
    differently than the RPC method it invokes.

@guggero guggero requested review from bhandras and ellemouton March 13, 2025 16:07
@guggero
GitHub: update actions, remove caching
b174ab3 
The latest version of the Go setup action now supports automated
caching.
bhandras
bhandras approved these changes Mar 13, 2025
View reviewed changes
Copy link
Member

@bhandras bhandras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you! 🎉

This was referenced Mar 13, 2025
Closed
Closed
Closed
Closed
@guggero
mod: bump old dependencies with known CVEs
a3f8e51 
Replaces a bunch of dependabot PRs.
ellemouton
ellemouton approved these changes Mar 15, 2025
View reviewed changes
Copy link
Member

@ellemouton ellemouton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noice 🙏

@starius
Copy link
Contributor

starius commented Mar 15, 2025

This commit is not needed now: 41eb830
I propose to revert it in this PR.

@guggero
Revert "bumpfee: check LND>=0.18.5 if target_conf is used"
0b04aff 
This reverts commit e683d8a.

Since we now increase the minimum lnd version to v0.18.5 we no longer
need this specific version check.
@guggero
Copy link
Member Author

guggero commented Mar 18, 2025

This commit is not needed now: 41eb830 I propose to revert it in this PR.

Makes sense, done.

@guggero guggero merged commit 84cb481 into master Mar 18, 2025
1 check passed
@guggero guggero deleted the lnd-bump branch March 18, 2025 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhandras bhandras bhandras approved these changes

@ellemouton ellemouton ellemouton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@guggero @starius @bhandras @ellemouton