tapdb+universe: implement initial version of universe ignore tree #1420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roasbeef
force-pushed
the
ignore-tree-impl
branch
from
9db6b54 to
9d067df
Compare
Pull Request Test Coverage Report for Build 13711567323Details
💛 - Coveralls |
… table This commit introduces a new migration (Migration 30) that modifies the unique index on the `universe_leaves` table. The unique constraint is updated from two columns (`minting_point`, `script_key_bytes`) to three columns (`minting_point`, `script_key_bytes`, `leaf_node_namespace`). Additionally, a new test case, `TestMigration30`, is added to verify the behavior of the database before and after the migration. The test ensures that inserting a duplicate row with the same `minting_point` and `script_key_bytes` but a different `leaf_node_namespace` fails before the migration and succeeds after the migration is applied. Furthermore, the `universe_leaves` table schema is updated in the generated SQL schema file to reflect the new unique constraint. Other minor changes include the addition of new proof types in the `universe` package and the introduction of new types related to ignore tuples, enhancing the overall functionality of the codebase.
Roasbeef
force-pushed
the
ignore-tree-impl
branch
from
2f50f47 to
11b67f8
Compare
Roasbeef
requested review from
a team,
ffranr and
GeorgeTsagk
and removed request for
a team
|
Removed from draft. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we implement the initial version of the universe Ignore Tree.
Along the way, we need a migration to the universe leaves, as the current unique index structure prevents us from adding two leaves that have the same script key, but distinct namespace (eg: transfer to a script key, then a burn of that).
With that in place, we're able to implement the ignore tree using the existing MS-SMT/Universe routines we already have in the database.
TODO