Skip to content

Commit

Permalink
GitHub: only run cover on some itests, send completion
Browse files Browse the repository at this point in the history
We only want to run the coverage on some select tests, since we don't
want to make tests with slow backends even slower.
And because we use "parallel: true" when uploading the coverage results,
those will only be assembled once we send "parallel-finished: true"
using the goveralls action.
So we do that with a new "finish" job.
  • Loading branch information
guggero committed Apr 23, 2024
1 parent 8a5160e commit 7468eb3
Showing 1 changed file with 16 additions and 5 deletions.
21 changes: 16 additions & 5 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -241,13 +241,13 @@ jobs:
matrix:
include:
- name: btcd
args: backend=btcd
args: backend=btcd cover=1
- name: bitcoind
args: backend=bitcoind
args: backend=bitcoind cover=1
- name: bitcoind-notxindex
args: backend="bitcoind notxindex"
- name: bitcoind-rpcpolling
args: backend="bitcoind rpcpolling"
args: backend="bitcoind rpcpolling" cover=1
- name: bitcoind-etcd
args: backend=bitcoind dbbackend=etcd
- name: bitcoind-postgres
Expand All @@ -259,7 +259,7 @@ jobs:
- name: bitcoind-sqlite-nativesql
args: backend=bitcoind dbbackend=sqlite nativesql=true
- name: neutrino
args: backend=neutrino
args: backend=neutrino cover=1
steps:
- name: git checkout
uses: actions/checkout@v3
Expand All @@ -274,9 +274,10 @@ jobs:
run: ./scripts/install_bitcoind.sh $BITCOIN_VERSION

- name: run ${{ matrix.name }}
run: make itest-parallel ${{ matrix.args }} cover=1
run: make itest-parallel ${{ matrix.args }}

- name: Send coverage
if: ${{ contains(matrix.args, 'cover=1') }}
uses: shogo82148/actions-goveralls@v1
with:
path-to-profile: coverage.txt
Expand Down Expand Up @@ -407,3 +408,13 @@ jobs:

- name: release notes check
run: scripts/check-release-notes.sh

# Notify about the completion of all coverage collecting jobs.
finish:
if: ${{ always() }}
needs: [unit-test, ubuntu-integration-test]
runs-on: ubuntu-latest
steps:
- uses: shogo82148/actions-goveralls@v1
with:
parallel-finished: true

0 comments on commit 7468eb3

Please sign in to comment.