Skip to content

Commit

Permalink
Merge pull request #8156 from hieblmi/improve-fc-logging
Browse files Browse the repository at this point in the history
contractcourt: log amount if incoming htlc times out
  • Loading branch information
ellemouton authored Nov 9, 2023
2 parents 6122452 + dd49c01 commit a3f8011
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 4 deletions.
8 changes: 4 additions & 4 deletions contractcourt/channel_arbitrator.go
Original file line number Diff line number Diff line change
Expand Up @@ -1743,10 +1743,10 @@ func (c *ChannelArbitrator) checkCommitChainActions(height uint32,
int64(height)

log.Infof("ChannelArbitrator(%v): go to chain for "+
"outgoing htlc %x: timeout=%v, "+
"outgoing htlc %x: timeout=%v, amount=%v, "+
"blocks_until_expiry=%v, broadcast_delta=%v",
c.cfg.ChanPoint, htlc.RHash[:],
htlc.RefundTimeout, remainingBlocks,
htlc.RefundTimeout, htlc.Amt, remainingBlocks,
c.cfg.OutgoingBroadcastDelta,
)
}
Expand Down Expand Up @@ -1778,10 +1778,10 @@ func (c *ChannelArbitrator) checkCommitChainActions(height uint32,
int64(height)

log.Infof("ChannelArbitrator(%v): go to chain for "+
"incoming htlc %x: timeout=%v, "+
"incoming htlc %x: timeout=%v, amount=%v, "+
"blocks_until_expiry=%v, broadcast_delta=%v",
c.cfg.ChanPoint, htlc.RHash[:],
htlc.RefundTimeout, remainingBlocks,
htlc.RefundTimeout, htlc.Amt, remainingBlocks,
c.cfg.IncomingBroadcastDelta,
)
}
Expand Down
8 changes: 8 additions & 0 deletions docs/release-notes/release-notes-0.18.0.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
- [Code Health](#code-health)
- [Breaking Changes](#breaking-changes)
- [Performance Improvements](#performance-improvements)
- [Misc](#misc)
- [Technical and Architectural Updates](#technical-and-architectural-updates)
- [BOLT Spec Updates](#bolt-spec-updates)
- [Testing](#testing)
Expand Down Expand Up @@ -65,6 +66,12 @@
* [Bool was added](https://github.com/lightningnetwork/lnd/pull/8057) to the
primitive type of the tlv package.

## Misc
### Logging
* [Add the htlc amount](https://github.com/lightningnetwork/lnd/pull/8156) to
contract court logs in case of timed-out htlcs in order to easily spot dust
outputs.

## RPC Updates

* [Deprecated](https://github.com/lightningnetwork/lnd/pull/7175)
Expand Down Expand Up @@ -118,6 +125,7 @@
* Elle Mouton
* Keagan McClelland
* Matt Morehouse
* Slyghtning
* Turtle
* Ononiwu Maureen Chiamaka
* Yong Yu

0 comments on commit a3f8011

Please sign in to comment.