require bitcoind >= v24.0 or conditionally use gettxspendingprevout

[Crypt-iQ]

The mempool issues should be solvable by using the gettxspendingprevout RPC so we don't have to scan the mempool at the btcwallet level. We could either conditionally call this if the bitcoind version is >= v24.0 or we could require people to upgrade their bitcoind versions.

[shaurya947]

Hi @Crypt-iQ I was hoping to learn more about the specific mempool issues that you mentioned. Could you please offer a high-level explanation or link me to any other issues/docs that have some explanations? I would like to potentially attempt this once I can understand it better 🙏

[Crypt-iQ]

Hi @shaurya947 unfortunately I don't think this is suitable for newer contributors to attempt and we'll probably do this one internally

[yyforyongyu]

If we are upgrading bitcoind version, we can also make use of getblockfrompeer when running pruned bitcoins, and deprecate the custom logic introduced in btcwallet.chain.

[Crypt-iQ]

If we are upgrading bitcoind version, we can also make use of getblockfrompeer when running pruned bitcoins, and deprecate the custom logic introduced in btcwallet.chain.

What do we do in btcwallet.chain? I think getblockfrompeer can fail

[yyforyongyu]

What do we do in btcwallet.chain?

We use it here. When running in pruned mode we'd fetch blocks from our peers when needed.

I think getblockfrompeer can fail

Fail as the block cannot be found or the peer doesn't support it?

[Crypt-iQ]

What do we do in btcwallet.chain?

We use it here. When running in pruned mode we'd fetch blocks from our peers when needed.

I think getblockfrompeer can fail

Fail as the block cannot be found or the peer doesn't support it?

It should be fine to use, since we're copying what it does already. It uses regular block fetching under the hood

[Crypt-iQ]

PR btcsuite/btcwallet#887

[Roasbeef]

btcsuite/btcwallet#887 has been merged, so we can close this after we bump the btcwallet version in lnd.

[Crypt-iQ]

This should be fixed with #8019 since the batch PR will get merged after the already merged btcsuite/btcwallet#887