Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gomod: update btcwallet version #8019

Merged
merged 1 commit into from
Oct 16, 2023
Merged

gomod: update btcwallet version #8019

merged 1 commit into from
Oct 16, 2023

Conversation

yyforyongyu
Copy link
Member

@yyforyongyu yyforyongyu commented Sep 20, 2023 •
edited by Roasbeef
Loading

Update btcwallet to include updates made in this PR, which fixes the slow response from calling getinfo.

Fixes #8009
Fixes #7703

@yyforyongyu yyforyongyu added backend Related to the node backend software/interface (e.g. btcd, bitcoin-core) P1 MUST be fixed or reviewed mempool labels Sep 20, 2023
@yyforyongyu yyforyongyu self-assigned this Sep 20, 2023
@yyforyongyu yyforyongyu mentioned this pull request Sep 20, 2023
Closed
@yyforyongyu yyforyongyu added this to the v0.17.1 milestone Sep 21, 2023
@Crypt-iQ Crypt-iQ mentioned this pull request Oct 2, 2023
Closed
@yyforyongyu yyforyongyu force-pushed the use-batch-rpc-mempool branch from 10019f2 to 371fcc8 Compare October 12, 2023 15:41
Roasbeef
Roasbeef approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@Roasbeef Roasbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🦋

@Roasbeef
Copy link
Member

I think let's also add a release notes entry? Since for those before v0.24 (bitcoind), CPU usage should be lower, and for those after v0.24, we no longer need to poll at all.

@yyforyongyu yyforyongyu force-pushed the use-batch-rpc-mempool branch from 371fcc8 to efd39c8 Compare October 13, 2023 05:33
@yyforyongyu
Copy link
Member Author

I think let's also add a release notes entry? Since for those before v0.24 (bitcoind), CPU usage should be lower, and for those after v0.24, we no longer need to poll at all.

Done!

@guggero guggero merged commit 6a80530 into lightningnetwork:master Oct 16, 2023
20 of 25 checks passed
@yyforyongyu yyforyongyu deleted the use-batch-rpc-mempool branch October 16, 2023 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guggero guggero guggero approved these changes

@Roasbeef Roasbeef Roasbeef approved these changes

Assignees

@yyforyongyu yyforyongyu

Labels
backend Related to the node backend software/interface (e.g. btcd, bitcoin-core) mempool P1 MUST be fixed or reviewed
Projects
None yet
Milestone
v0.17.1
3 participants
@yyforyongyu @Roasbeef @guggero