mod: bump btcwallet to latest version #8630

guggero · 2024-04-08T09:07:19Z

This commit updates btcwallet to the latest version that correctly includes the MasterKeyFingerprint for all generated addresses, including change addresses derived from imported watch-only accounts.

coderabbitai · 2024-04-08T09:07:26Z

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Walkthrough

The release 0.18.0 of lnd addresses critical issues, notably correcting a function call where arguments were misplaced and ensuring that addresses from imported watch-only accounts now properly include the master key's fingerprint. This update enhances security and functionality, particularly for users employing external signing devices like Coldcard.

Changes

File Path	Change Summary
`docs/release-notes/release-notes-0.18.0.md`	Fixed argument order in a function call and ensured correct inclusion of master key's fingerprint for addresses derived from imported watch-only accounts.

Assessment against linked issues

Objective	Addressed	Explanation
Ensure change output includes the master fingerprint (XFP) for transactions crafted from external watch-only accounts (#8626)	✅
Address the issue related to the assumption of a change output in the code, allowing for transactions without change (#5739)	❓	The release notes do not explicitly mention handling transactions without change outputs, but the fix may indirectly address this by ensuring correct handling of outputs.

Possibly related issues

[bug]: 0.15.3 requires additional sats to spend a UTXO completely when P2TR #7079: The issue revolves around estimation method failure and spending to P2TR outputs. This PR might indirectly affect it by improving the handling of outputs, but without explicit mention, it's not clear.
Can't remove remote watchtower that is reporting error "StateUpdateCodeSeqNumOutOfOrder in StateUpdateReply for seqnum=1021". #6397: Involves watchtower sequence number errors and removal issues. This PR does not seem to address watchtower-specific functionalities.
[bug]: channel open transaction fails to broadcast because lnd is unaware of own mempool transaction after rescan #7300: Focuses on channel state management and mempool scanning. The changes in this PR do not directly relate to these areas.

🐰✨
In the burrow of code, a fix was made,
Where arguments swapped and fingerprints laid.
With each line refined, and bugs chased away,
lnd shines brighter, leading the way.
🌟🐾

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 2

Review Status

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 6377f98 and 434e432e466d33dcc29ddc03bc5ca69ab7febeab.

Files ignored due to path filters (2)

go.mod is excluded by !**/*.mod
go.sum is excluded by !**/*.sum

Files selected for processing (1)

docs/release-notes/release-notes-0.18.0.md (1 hunks)

coderabbitai · 2024-04-08T09:11:34Z

docs/release-notes/release-notes-0.18.0.md

+* [Fixed](https://github.com/lightningnetwork/lnd/pull/8609) a function
+  call where arguments were swapped.


Correct the function call where arguments were swapped.

This fix is crucial for ensuring the correct operation of the affected functionality. It's important to verify that this correction does not introduce any side effects in related components.

coderabbitai · 2024-04-08T09:11:34Z

docs/release-notes/release-notes-0.18.0.md

+* [Addresses derived from imported watch-only accounts now correctly include
+  their master key's
+  fingerprint](https://github.com/lightningnetwork/lnd/pull/8630).


Ensure addresses derived from imported watch-only accounts include their master key's fingerprint.

This change is significant for hardware wallet integration and should be thoroughly tested with various hardware wallets to confirm that the master key's fingerprint is correctly included and recognized.

kaloudis · 2024-04-11T22:51:50Z

tACK

Fixes lightningnetwork#8626. This commit updates btcwallet to the latest version that correctly includes the MasterKeyFingerprint for all generated addresses, including change addresses derived from imported watch-only accounts.

bhandras

LGTM 🎉

saubyk

Ack

guggero mentioned this pull request Apr 8, 2024

[bug]: Remote Signer: FundPsbt: change output lacking master fingerprint (XFP) #8626

Closed

coderabbitai bot reviewed Apr 8, 2024

View reviewed changes

guggero added 2 commits April 12, 2024 08:34

mod: bump btcwallet to latest version

333fc6e

Fixes lightningnetwork#8626. This commit updates btcwallet to the latest version that correctly includes the MasterKeyFingerprint for all generated addresses, including change addresses derived from imported watch-only accounts.

docs: update release notes

f35ce09

guggero force-pushed the addr-master-fingerprint branch from 434e432 to f35ce09 Compare April 12, 2024 06:35

guggero requested review from a team, bhandras and morehouse and removed request for a team April 15, 2024 06:17

bhandras approved these changes Apr 15, 2024

View reviewed changes

saubyk assigned guggero Apr 15, 2024

saubyk added this to the v0.18.0 milestone Apr 15, 2024

guggero requested review from ellemouton and removed request for morehouse April 15, 2024 20:10

saubyk approved these changes Apr 15, 2024

View reviewed changes

guggero merged commit 2ccf58e into lightningnetwork:master Apr 16, 2024
26 of 27 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

mod: bump btcwallet to latest version #8630

mod: bump btcwallet to latest version #8630

guggero commented Apr 8, 2024 •

edited

Loading

coderabbitai bot commented Apr 8, 2024 •

edited

Loading

Auto Review Skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

Documentation and Community

coderabbitai bot left a comment

coderabbitai bot Apr 8, 2024

coderabbitai bot Apr 8, 2024

kaloudis commented Apr 11, 2024

bhandras left a comment

saubyk left a comment

		* [Fixed](https://github.com/lightningnetwork/lnd/pull/8609) a function
		call where arguments were swapped.

mod: bump btcwallet to latest version #8630

mod: bump btcwallet to latest version #8630

Conversation

guggero commented Apr 8, 2024 • edited Loading

coderabbitai bot commented Apr 8, 2024 • edited Loading

Auto Review Skipped

Walkthrough

Changes

Assessment against linked issues

Possibly related issues

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot Apr 8, 2024

Choose a reason for hiding this comment

coderabbitai bot Apr 8, 2024

Choose a reason for hiding this comment

kaloudis commented Apr 11, 2024

bhandras left a comment

Choose a reason for hiding this comment

saubyk left a comment

Choose a reason for hiding this comment

guggero commented Apr 8, 2024 •

edited

Loading

coderabbitai bot commented Apr 8, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)