Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beat itest [1/3]: remove the usage of standby nodes #9306

Open
wants to merge 12 commits into
base: yy-waiting-on-merge
Choose a base branch
from
10 changes: 7 additions & 3 deletions itest/lnd_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,9 @@ func TestLightningNetworkDaemon(t *testing.T) {
// among all the test cases.
harnessTest.SetupStandbyNodes()

// Get the current block height.
height := harnessTest.CurrentHeight()

// Run the subset of the test cases selected in this tranche.
for idx, testCase := range testCases {
testCase := testCase
Expand Down Expand Up @@ -151,9 +154,10 @@ func TestLightningNetworkDaemon(t *testing.T) {
}
}

height := harnessTest.CurrentHeight()
t.Logf("=========> tests finished for tranche: %v, tested %d "+
"cases, end height: %d\n", trancheIndex, len(testCases), height)
//nolint:forbidigo
fmt.Printf("=========> tranche %v finished, tested %d cases, mined "+
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we switch from t.Logf() to fmt.Printf()? Just to get rid of the indentation? Or also so it's always printed, no matter if -test.v is specified?

"blocks: %d\n", trancheIndex, len(testCases),
harnessTest.CurrentHeight()-height)
}

// getTestCaseSplitTranche returns the sub slice of the test cases that should
Expand Down