Reapply 8644 on 9260 #9313

aakselrod · 2024-11-27T02:42:46Z

Rebase of #9242 on #9260. Now includes btcsuite/btcwallet#967.

coderabbitai · 2024-11-27T02:42:55Z

Important

Review skipped

Auto reviews are limited to specific labels.

🏷️ Labels to auto review (1)

llm-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

aakselrod · 2024-11-27T19:25:19Z

Looks like a postgres itest failed. Looking into it. Doesn't appear to be related to the btcwallet deadlock fixed recently, so that's good!

aakselrod · 2024-11-27T21:07:23Z

It looks like the shutdown came too early and the sweeper in monitorFeeBumpResult didn't get time to process the result of the sweep broadcast (exited at sweeper.go:1665). I don't think that's related to the SQL DB?

This seems to happen rarely enough that I can't seem to reproduce it locally.

bhandras

Looks really good! I think we just need some comments and perhaps some direct coverage for the batch package, then it's good to go!

bhandras · 2024-11-27T21:13:12Z

batch/batch.go

+					// sqldb retry and still re-execute the
+					// failing request individually.
+					dbErr := sqldb.MapSQLError(err)
+					if !sqldb.IsSerializationError(dbErr) {


nit: It'd be nice to cover batch with a simple unit test to make sure the serialization errors are correctly handled and we don't regress later.

channeldb/graph.go

sqldb/sqlerrors.go

bhandras · 2024-11-27T21:17:57Z

Makefile

+	# each can run concurrently. Note that many of the settings here are
+	# specifically for integration testing and are not fit for running
+	# production nodes.
+	docker run --name lnd-postgres -e POSTGRES_PASSWORD=postgres -p 6432:5432 -d postgres:13-alpine -N 1500 -c max_pred_locks_per_transaction=1024 -c max_locks_per_transaction=128 -c jit=off -c work_mem=8MB -c checkpoint_timeout=10min -c enable_seqscan=off


Does settings work_mem=8MB and jit=off add to the test case stability? If yes could you please add some comments why these were changed (along with other params)?

I got those settings from @djkazic's suggestions. I think it's likely they're unnecessary for the itests because the databases they're working with are pretty small. Will try running without them to see how it goes, and add comments for the rest.

Yeah, for context those are the settings I'm using in my production postgres backed LND. DB size is ~5GB. jit=off should help in all scenarios as JIT'ing mostly benefits long-running queries whereas postgres_kvdb tends to spawn many small and fast-executing queries. work_mem=8MB on the other hand benefits larger DBs as it gives postgres more breathing room for each individual query to do sorts etc.

aakselrod · 2024-11-27T23:35:00Z

Updated to address comments, add release notes, and do a CI run. I'm still running this locally to see if the new DB settings give me any trouble.

aakselrod · 2024-11-28T00:20:28Z

Got a postgres unit test failure. Looking into it...

Error is here. Looks similar to errors (chain notification-related) that happened on both postgres and sqlite unit test runs on #9260, which doesn't have parallel DB transactions re-enabled.

I believe this is actually related to a flake in chainntnfs where a certain series of events makes the notifier attempt to send one more event than the (unread) channel has room for. The easiest fix is to add 2 to the channel allocation here, which has eliminated similar errors from all of our (Lightspark) CI runs in our private fork. This is in lieu of actually tracking down the flake further and fixing it "properly." I'll push it as soon as this CI run is complete.

The updated DB settings seem to be working OK locally on my machine as well.

yyforyongyu · 2024-11-28T05:15:13Z

I believe this is actually related to a flake in chainntnfs where a certain series of events makes the notifier attempt to send one more event than the (unread) channel has room for.

Thanks a lot for digging into the unit test flake! That certainly was an easy way to fix and was originally used in #9258. Then I realized there's another place we need the dedup check which was fixed in 4632044. Since this PR is based on #9260 and that PR has this commit in its upstream, I'd expect it to be fixed properly there but it seems not? The other related fix is #9309 which fixed another flake.

Moving forward, I think we can focus on getting the postgres-related merged, then open new PRs to fix the unit test flakes.

aakselrod · 2024-11-28T19:24:02Z

Moving forward, I think we can focus on getting the postgres-related merged, then open new PRs to fix the unit test flakes.

I'm off until Monday but will remove the latest commit then. Thanks!

This reverts commit 67419a7.

To make this itest work reliably with multiple parallel SQL transactions, we need to count both the settle and final HTLC events. Otherwise, sometimes the final events from earlier forwards are counted before the forward events from later forwards, causing a miscount of the settle events. If we expect both the settle and final event for each forward, we don't miscount.

aakselrod · 2024-12-02T21:24:12Z

I tried to take off the latest commit and force-push but GitHub got stuck on processing latest update so I rearranged the order of the remaining commits a little and force-pushed again.

aakselrod mentioned this pull request Nov 27, 2024

Reapply #8644 #9242

Open

8 tasks

saubyk assigned aakselrod Nov 27, 2024

aakselrod force-pushed the reapply-8644-on-9260 branch 2 times, most recently from 81e4188 to 9452cf8 Compare November 27, 2024 18:06

saubyk requested review from bhandras and Roasbeef November 27, 2024 20:51

saubyk added this to the v0.19.0 milestone Nov 27, 2024

bhandras reviewed Nov 27, 2024

View reviewed changes

aakselrod force-pushed the reapply-8644-on-9260 branch from 9452cf8 to a94aa1c Compare November 27, 2024 23:34

aakselrod added 11 commits December 2, 2024 13:21

go.mod: update to latest btcwallet

b645f9c

go.mod: use local kvdb to reapply removal of global postgres lock

70529e1

Reapply "kvdb/postgres: remove global application level lock"

563fff9

This reverts commit 67419a7.

batch: handle serialization errors correctly

235de40

channeldb: handle previously-unhandled errors

77a1817

sqldb: improve serialization error handling

c9e1fd6

Makefile: tune params for db-instance for postgres itests

440c151

Makefile: log to file instead of console

3b04232

github workflow: save postgres log to zip file

6cca186

docs: update release-notes for 0.19.0

fb50cec

aakselrod force-pushed the reapply-8644-on-9260 branch from a94aa1c to fb50cec Compare December 2, 2024 21:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Reapply 8644 on 9260 #9313

Reapply 8644 on 9260 #9313

aakselrod commented Nov 27, 2024 •

edited

Loading

coderabbitai bot commented Nov 27, 2024

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

aakselrod commented Nov 27, 2024

aakselrod commented Nov 27, 2024 •

edited

Loading

bhandras left a comment

bhandras Nov 27, 2024

bhandras Nov 27, 2024

aakselrod Nov 27, 2024

djkazic Nov 28, 2024 •

edited

Loading

aakselrod commented Nov 27, 2024

aakselrod commented Nov 28, 2024 •

edited

Loading

yyforyongyu commented Nov 28, 2024

aakselrod commented Nov 28, 2024

aakselrod commented Dec 2, 2024

Reapply 8644 on 9260 #9313

Are you sure you want to change the base?

Reapply 8644 on 9260 #9313

Conversation

aakselrod commented Nov 27, 2024 • edited Loading

coderabbitai bot commented Nov 27, 2024

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

aakselrod commented Nov 27, 2024

aakselrod commented Nov 27, 2024 • edited Loading

bhandras left a comment

Choose a reason for hiding this comment

bhandras Nov 27, 2024

Choose a reason for hiding this comment

bhandras Nov 27, 2024

Choose a reason for hiding this comment

aakselrod Nov 27, 2024

Choose a reason for hiding this comment

djkazic Nov 28, 2024 • edited Loading

Choose a reason for hiding this comment

aakselrod commented Nov 27, 2024

aakselrod commented Nov 28, 2024 • edited Loading

yyforyongyu commented Nov 28, 2024

aakselrod commented Nov 28, 2024

aakselrod commented Dec 2, 2024

aakselrod commented Nov 27, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

aakselrod commented Nov 27, 2024 •

edited

Loading

djkazic Nov 28, 2024 •

edited

Loading

aakselrod commented Nov 28, 2024 •

edited

Loading