Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd: fix default timeout for estimateroutefee #9322

Merged
merged 2 commits into from
Nov 29, 2024
Merged

cmd: fix default timeout for estimateroutefee #9322

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
85d89a5
cmd: fix default timeout for estimateroutefee
hieblmi Nov 29, 2024
440cdb3
docs: update release notes
hieblmi Nov 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions cmd/commands/cmd_payments.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1920,9 +1920,7 @@ func estimateRouteFee(ctx *cli.Context) error {

case ctx.IsSet("pay_req"):
req.PaymentRequest = StripPrefix(ctx.String("pay_req"))
if ctx.IsSet("timeout") {
req.Timeout = uint32(ctx.Duration("timeout").Seconds())
}
req.Timeout = uint32(ctx.Duration("timeout").Seconds())

default:
return fmt.Errorf("fee estimation arguments missing")
Expand Down
3 changes: 3 additions & 0 deletions docs/release-notes/release-notes-0.19.0.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,9 @@
* [Make the contract resolutions for the channel arbitrator optional](
https://github.com/lightningnetwork/lnd/pull/9253)

* [Fixed a bug](https://github.com/lightningnetwork/lnd/pull/9322) that caused
estimateroutefee to ignore the default payment timeout.

# New Features

* [Support](https://github.com/lightningnetwork/lnd/pull/8390) for
Expand Down
Loading