Skip to content

Commit

Permalink
Update to latest version of lightstep-tracer-common (#109)
Browse files Browse the repository at this point in the history
  • Loading branch information
MatthewDolan authored Sep 27, 2017
1 parent ad2fc76 commit 1e25a64
Show file tree
Hide file tree
Showing 7 changed files with 102 additions and 97 deletions.
4 changes: 2 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,8 @@ collectorpb/collector.pb.go:
else
collectorpb/collector.pb.go: lightstep-tracer-common/collector.proto
docker run --rm -v $(shell pwd)/lightstep-tracer-common:/input:ro -v $(shell pwd)/collectorpb:/output \
lightstep/protoc:latest \
protoc --go_out=plugins=grpc:/output --proto_path=/input /input/collector.proto
lightstep/grpc-gateway:latest \
protoc -I/root/go/src/tmp/vendor/github.com/grpc-ecosystem/grpc-gateway/third_party/googleapis --go_out=plugins=grpc:/output --proto_path=/input /input/collector.proto
endif

# gRPC
Expand Down
140 changes: 72 additions & 68 deletions collectorpb/collector.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions grpc_logencoder.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,11 @@ func marshalFields(
buffer *reportBuffer,
) {
lfe := grpcLogFieldEncoder{recorder, buffer, nil}
protoLog.Keyvalues = make([]*cpb.KeyValue, len(fields))
protoLog.Fields = make([]*cpb.KeyValue, len(fields))
for i, f := range fields {
lfe.currentKeyValue = &cpb.KeyValue{}
f.Marshal(&lfe)
protoLog.Keyvalues[i] = lfe.currentKeyValue
protoLog.Fields[i] = lfe.currentKeyValue
}
}

Expand Down
2 changes: 1 addition & 1 deletion lightstep-tracer-common
46 changes: 23 additions & 23 deletions lightsteppb/lightstep_carrier.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion test_utils_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ func (matcher haveKeyValuesMatcher) Match(actual interface{}) (bool, error) {
case []*cpb.KeyValue:
actualKeyValues = v
case *cpb.Log:
actualKeyValues = v.GetKeyvalues()
actualKeyValues = v.GetFields()
default:
return false, fmt.Errorf("HaveKeyValues matcher expects either a []*KeyValue or a *Log")
}
Expand Down

0 comments on commit 1e25a64

Please sign in to comment.