Merge pull request #91 from lightstep/jmacd/sampler

Add comments describing probabilisticsampler, tailsampler processor components

arrow/otelcolarrow-build.yaml

@@ -117,11 +117,17 @@ processors:
   - gomod: github.com/open-telemetry/opentelemetry-collector-contrib/processor/remotetapprocessor v0.107.0
   - gomod: github.com/open-telemetry/opentelemetry-collector-contrib/processor/transformprocessor v0.107.0
 
-  # ServiceNow does not at this time recommend the probabilistic sampler processor,
-  # because it leads to undercounting of spans.  We will update this recommendation
-  # when the sampler is fully supported.
+  # ServiceNow recommends the probabilistic sampler processor in order to support
+  # probability sampling in the collector pipieline.  This sampler component supports
+  # OpenTelemetry sampling specifications that enable correctly adjusting counts, in
+  # metrics derived from sampled spans.
   - gomod: github.com/open-telemetry/opentelemetry-collector-contrib/processor/probabilisticsamplerprocessor v0.107.0
 
+  # The tail sampling processor is included, by request.  Please note that this component
+  # does not provide the necessary information to correctly adjust counts in metrics derived
+  # from sampled spans.
+  - gomod: github.com/open-telemetry/opentelemetry-collector-contrib/processor/tailsamplingprocessor v0.103.0
+
   # You may be interested in other transform components in the
   # Collector-Contrib repository.  Here are some that might be useful:
   #

charts/collector-k8s/Chart.yaml

@@ -2,8 +2,8 @@ apiVersion: v2
 name: otelcollector
 description: Deprecated chart for using the OpenTelemetry Collector to scape static or dynamic metric targets.
 type: application
-version: 0.3.3
-appVersion: 0.106.1
+version: 0.4.0
+appVersion: 0.107.0
 deprecated: true
 dependencies: []
 # cert manager must be manually installed because it has CRDs

charts/kube-otel-stack/Chart.yaml

@@ -2,8 +2,8 @@ apiVersion: v2
 name: kube-otel-stack
 description: Chart for sending Kubernetes metrics to Lightstep using the OpenTelemetry Operator.
 type: application
-version: 0.9.0
-appVersion: 0.106.1
+version: 0.10.0
+appVersion: 0.107.0
 dependencies:
   # cert manager must be manually installed because it has CRDs
   # https://github.com/kubernetes-sigs/security-profiles-operator/issues/1062

charts/otel-cloud-stack/Chart.yaml

@@ -15,10 +15,10 @@ type: application
 # This is the chart version. This version number should be incremented each time you make changes
 # to the chart and its templates, including the app version.
 # Versions are expected to follow Semantic Versioning (https://semver.org/)
-version: "0.8.0"
+version: "0.9.0"
 
 # This is the version number of the application being deployed. This version number should be
 # incremented each time you make changes to the application. Versions are not expected to
 # follow Semantic Versioning. They should reflect the version the application is using.
 # It is recommended to use it with quotes.
-appVersion: "1.30.0"
+appVersion: "1.31.0"

charts/otel-cloud-stack/values.yaml

@@ -247,6 +247,16 @@ daemonCollector:
         send_batch_size: 1000
         send_batch_max_size: 1500
         timeout: 1s
+      # To apply probability sampling in the traces pipeline uncomment
+      # probabilistic_sampler in the list of processors below.
+      probabilistic_sampler:
+        # The desired sampling percentage:
+        sampling_percentage: 25
+        # "Equalizing" mode is recommended.  This mode permits SDKs to apply
+        # sampling earlier in the pipeline, leading to correspondingly less
+        # sampling in the collector.  See
+        # https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/processor/probabilisticsamplerprocessor/README.md#equalizing
+        mode: equalizing
     exporters:
       logging:
         verbosity: detailed
@@ -292,6 +302,10 @@ daemonCollector:
           exporters:
             - otlp
           processors:
+            # To configure probability sampling in the collector pipeline,
+            # enable the probabilistic sampler.
+            # - probabilisticsampler
+
             - resourcedetection/env
             - k8sattributes
             - batch