Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generator config allows us to specify tag sets for each route.
It's convenient to use the
error: true
span attribute to mark a span as an error (I think it came from opentracing). But some systems ignore this tag and only look at the span status.What is the current behavior?
If the
error
tag is specified in route configuration, it's added to the span attributes and propagated to parental spans.Span status is not modified.
What is the new behavior?
Now when a span has the
error
attribute, the span status is updated toError
as suggested in the OpenTelemetry docs.Pull request checklist
Please check if your PR fulfills the following requirements:
make test
) for the changes have been added (for bug fixes / features) and passmake lint
) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
Does this introduce a breaking change?
Other information