LS-60099 addressing code warnings. #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adil-sultan
changed the title
gdfast
reviewed
Mar 26, 2024
| 1. `$ git clone https://github.com/lightstep/telemetry-generator` | ||
| 1. `$ cd telemetry-generator` | ||
| 1. Copy `hipster_shop.yaml` to `dev.yaml` for local development. Not strictly necessary (you can point the `TOPO_FILE` environment variable to any config file) but will potentially save heartache and hassle 😅 This file is in .gitignore, so it won't be included in your commits. If you want to share config changes, add them to a new example config file. | ||
| 2. `$ git clone https://github.com/lightstep/telemetry-generator` |
There was a problem hiding this comment.
just so you know, this change probably isn't necessary, lists with all value of 1. should render with actual numbers. But I don't mind the change. It makes the raw markdown text more readable
There was a problem hiding this comment.
TIL, thank you! I was trying to address all the low hanging fruit code warnings in this PR.
gdfast
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
Cleaning up some repo warnings to address:
commenting
removing unused parameters
hostandtopoinlinechanging a slice declaration to nil
renamed
minandmaxtominimumandmaximumto eliminate the collision warnings with builtin functionsWhat is the new behavior?
Behavior is the same, just cleaned up some warnings
Pull request checklist
Please check if your PR fulfills the following requirements:
make test) for the changes have been added (for bug fixes / features) and passmake lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
Does this introduce a breaking change?
Other information
I was going to update the deprecated rand.Seed usage but after starting this I think it should be it's own PR due to the amount of work it will be. We have LS-60180 for TODO comments.